Page MenuHomePhabricator
Create Task
Maniphest T289361

Rename $wgIPInfoGeoIP2Path or hard code the GeoLite2/GeoIP2- prefix [S]
Closed, ResolvedPublic
Actions

Description

wgIPInfoGeoIP2Path must contain a path and a prefix. Quoting the documentation:

Then set the $wgIPInfoGeoIP2Path variable to the path to the directory containing the .mmdb files, plus either the GeoLite2- or GeoIP2- prefixes.

We could either:

  1. Just add a note to the inline documentation with a note that it must contain either the GeoLite2- or GeoIP2- prefix depending on which database(s) you downloaded 🤷
  2. Do #1 and also rename it to $wgIPInfoGeoIP2Prefix
  3. Hard code the prefix. I (@phuedx) have checked and all databases that I have access to (including the Anonymous IP and Enterprise databases) share the prefix.

Details

SubjectRepoBranchLines +/-
Rename $wgIPInfoGeoIP2Pathmediawiki/extensions/IPInfomaster+4 -4
[beta] Rename $wgIPInfoGeoIP2Path to $wgIPInfoGeoIP2Prefixoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

phuedx created this task.Aug 20 2021, 3:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2021, 3:41 PM
• Niharika added a project: Anti-Harassment.Aug 20 2021, 10:55 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
• Niharika moved this task from Backlog to Up Next on the IP Info board.Aug 25 2021, 4:00 PM
• Niharika added a comment.Sep 1 2021, 4:49 PM

Meeting notes:
Some questions about the preferred way to do this. Consideration about the "GeoLite" prefix.
We said we'll discuss this in engineering.

phuedx renamed this task from Rename $wgIPInfoGeoIP2Path or hard code the GeoIP2- prefix to Rename $wgIPInfoGeoIP2Path or hard code the GeoLite2/GeoIP2- prefix.Sep 2 2021, 12:56 PM
phuedx updated the task description. (Show Details)
phuedx mentioned this in T288933: Fetch information about an IP from the MaxMind GeoIP2 Enterprise database.Sep 22 2021, 12:30 PM
ARamirez_WMF renamed this task from Rename $wgIPInfoGeoIP2Path or hard code the GeoLite2/GeoIP2- prefix to Rename $wgIPInfoGeoIP2Path or hard code the GeoLite2/GeoIP2- prefix [S].Sep 29 2021, 4:42 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
• TThoabala subscribed.Sep 29 2021, 5:05 PM

Decision from engineering/estimation is to rename wgIPInfoGeoIP2Path and update it to $wgIPInfoGeoIP2Prefix .

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Oct 13 2021, 4:57 PM
• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
gerritbot added a comment.Oct 17 2021, 4:14 PM

Change 731281 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Rename $wgIPInfoGeoIP2Path

https://gerrit.wikimedia.org/r/731281

gerritbot added a project: Patch-For-Review.Oct 17 2021, 4:14 PM
• TThoabala added a comment.Oct 17 2021, 4:15 PM

once this gets merged we also need to update documentation here
https://www.mediawiki.org/wiki/Extension:IPInfo#Free_test_data

• TThoabala claimed this task.Oct 17 2021, 4:16 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 17 2021, 4:21 PM
gerritbot added a comment.Oct 18 2021, 10:02 AM

Change 731346 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] [beta] Rename $wgIPInfoGeoIP2Path to $wgIPInfoGeoIP2Prefix

https://gerrit.wikimedia.org/r/731346

gerritbot added a comment.Oct 18 2021, 2:22 PM

Change 731281 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Rename $wgIPInfoGeoIP2Path

https://gerrit.wikimedia.org/r/731281

• TThoabala mentioned this in rEIPIf807270cd28b: Rename $wgIPInfoGeoIP2Path.Oct 18 2021, 2:23 PM
gerritbot added a comment.Oct 18 2021, 2:30 PM

Change 731346 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta] Rename $wgIPInfoGeoIP2Path to $wgIPInfoGeoIP2Prefix

https://gerrit.wikimedia.org/r/731346

Stashbot added a comment.Oct 18 2021, 2:36 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T14:36:36Z] <phuedx@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:731346|[beta] Rename $wgIPInfoGeoIP2Path to $wgIPInfoGeoIP2Prefix (T289361)]] (duration: 00m 56s)

phuedx moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Oct 18 2021, 2:38 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 3:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 4:00 PM
dom_walden subscribed.Oct 20 2021, 12:10 PM
In T289361#7434455, @TThoabala wrote:

once this gets merged we also need to update documentation here
https://www.mediawiki.org/wiki/Extension:IPInfo#Free_test_data

Good point. We should do this before we consider this task complete.

• TThoabala added a comment.Oct 20 2021, 12:19 PM
In T289361#7443968, @dom_walden wrote:
In T289361#7434455, @TThoabala wrote:

once this gets merged we also need to update documentation here
https://www.mediawiki.org/wiki/Extension:IPInfo#Free_test_data

Good point. We should do this before we consider this task complete.

Updated.
https://www.mediawiki.org/wiki/Extension:IPInfo#Free_test_data

• imaigwilo subscribed.Oct 26 2021, 7:00 PM

Verification steps done:
I used the new name in my local settings only, and data loaded in my IP info box
$wgIPInfoGeoIP2Prefix = '/var/www/html/w/GeoLite2-'

Note:
Previous name($wgIPInfoGeoIP2Path = '/var/www/html/w/GeoLite2-';) still generates data

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Oct 26 2021, 7:02 PM
phuedx moved this task from Up Next to Closed on the IP Info board.Nov 5 2021, 4:37 PM
• Niharika closed this task as Resolved.Nov 11 2021, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL