Page MenuHomePhabricator
Create Task
Maniphest T289544

Deprecate and remove PageProps::getInstance()
Closed, ResolvedPublic
Actions

Description

PageProps has been converted to a service (see T253188). PageProps::getInstance() relies on global state and thus should be deprecated and later removed in favor of MediaWikiServices::getInstance()->getPageProps().

https://codesearch.wmcloud.org/search/?q=PageProps%5Cs*%3A%3A%5Cs*getInstance&i=fosho&files=&excludeFiles=&repos=

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Aug 23 2021, 11:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2021, 11:53 PM
Zabe renamed this task from Remove PageProps::getInstance() to Deprecate and remove PageProps::getInstance().Sep 26 2021, 12:17 AM
gerritbot added a comment.Sep 26 2021, 12:21 AM

Change 723722 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Soft deprecate PageProps::getInstance()

https://gerrit.wikimedia.org/r/723722

gerritbot added a project: Patch-For-Review.Sep 26 2021, 12:21 AM
gerritbot added a comment.Sep 26 2021, 12:40 AM

Change 723726 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikibase@master] Replace usage of depreacted PageProps::getInstance()

https://gerrit.wikimedia.org/r/723726

gerritbot added a comment.Sep 26 2021, 12:42 AM

Change 723727 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikibaseLexeme@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723727

gerritbot added a comment.Sep 26 2021, 12:46 AM

Change 723722 merged by jenkins-bot:

[mediawiki/core@master] Soft deprecate PageProps::getInstance()

https://gerrit.wikimedia.org/r/723722

gerritbot added a comment.Sep 26 2021, 12:48 AM

Change 723725 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/DiscussionTools@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723725

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 26 2021, 1:00 AM
gerritbot added a comment.Sep 26 2021, 4:35 AM

Change 723725 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723725

gerritbot added a comment.Sep 26 2021, 4:53 AM

Change 723726 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723726

gerritbot added a comment.Sep 26 2021, 12:07 PM

Change 723745 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/PageImages@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723745

gerritbot added a comment.Sep 26 2021, 12:12 PM

Change 723747 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/TemplateData@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723747

Zabe updated the task description. (Show Details)Sep 26 2021, 12:13 PM
gerritbot added a comment.Sep 26 2021, 6:48 PM

Change 723745 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723745

gerritbot added a comment.Sep 26 2021, 7:30 PM

Change 723747 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723747

gerritbot added a comment.Sep 27 2021, 5:11 PM

Change 723727 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/723727

gerritbot added a comment.Sep 27 2021, 10:01 PM

Change 724195 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate PageProps::getInstance()

https://gerrit.wikimedia.org/r/724195

gerritbot added a comment.Oct 3 2021, 9:59 PM

Change 725488 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/PageForms@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/725488

gerritbot added a comment.Oct 3 2021, 10:19 PM

Change 725489 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CommentStreams@master] Inject PageProps service

https://gerrit.wikimedia.org/r/725489

gerritbot added a comment.Oct 4 2021, 3:19 PM

Change 725488 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/725488

gerritbot added a comment.Oct 18 2021, 9:21 PM

Change 725489 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Inject PageProps service

https://gerrit.wikimedia.org/r/725489

CCicalese_WMF mentioned this in rECOS5571bc7ce079: Inject PageProps service.Oct 18 2021, 9:24 PM
gerritbot added a comment.Mar 15 2022, 10:48 PM

Change 724195 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate PageProps::getInstance()

https://gerrit.wikimedia.org/r/724195

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 15 2022, 11:00 PM
gerritbot added a comment.Mar 19 2022, 6:27 PM

Change 771995 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/JSBreadCrumbs@master] Use non-deprecated method in MW 1.38+

https://gerrit.wikimedia.org/r/771995

Seb35 moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.Mar 19 2022, 6:42 PM
gerritbot added a comment.Mar 19 2022, 8:00 PM

Change 771995 merged by jenkins-bot:

[mediawiki/extensions/JSBreadCrumbs@master] Replace usage of deprecated PageProps::getInstance()

https://gerrit.wikimedia.org/r/771995

Restricted Repository Identity mentioned this in rEJSB63369ac2bb2b: Replace usage of deprecated PageProps::getInstance().Mar 19 2022, 8:01 PM
Umherirrender removed a project: Patch-For-Review.Mar 20 2022, 9:21 AM
Umherirrender updated the task description. (Show Details)
gerritbot added a comment.Mar 20 2022, 9:45 AM

Change 772005 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DisplayTitle@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772005

gerritbot added a project: Patch-For-Review.Mar 20 2022, 9:45 AM

Change 772006 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageProperties@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772006

gerritbot added a comment.Mar 20 2022, 9:49 AM

Change 772007 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiSEO@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772007

gerritbot added a comment.Mar 20 2022, 12:53 PM

Change 772006 merged by Zabe:

[mediawiki/extensions/PageProperties@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772006

Umherirrender mentioned this in rEPPRabfd7ede4ccb: Replace deprecated PageProps::getInstance.Mar 20 2022, 12:54 PM
gerritbot added a comment.Mar 20 2022, 12:54 PM

Change 772005 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772005

Umherirrender mentioned this in rEDPT5949476fb263: Replace deprecated PageProps::getInstance.Mar 20 2022, 1:35 PM
gerritbot added a comment.Mar 28 2022, 5:18 PM

Change 772007 merged by Umherirrender:

[mediawiki/extensions/WikiSEO@master] Replace deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/772007

Umherirrender closed this task as Resolved.Mar 28 2022, 5:18 PM
Umherirrender removed a project: Patch-For-Review.
Umherirrender mentioned this in rEWSE163ccfdc5f3e: Replace deprecated PageProps::getInstance.Mar 28 2022, 5:52 PM
Zabe removed a project: User-Zabe.Apr 13 2022, 12:47 AM
gerritbot added a comment.Oct 24 2022, 7:27 PM

Change 848479 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/848479

gerritbot added a project: Patch-For-Review.Oct 24 2022, 7:27 PM
gerritbot added a comment.Oct 25 2022, 8:14 AM

Change 848479 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated PageProps::getInstance

https://gerrit.wikimedia.org/r/848479

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 9:00 AM
Umherirrender removed a project: Patch-For-Review.Oct 26 2022, 5:35 PM
Octfx mentioned this in rEWSE6a6ad2ec6131: refactor: Add declare strict_types.Dec 27 2022, 1:31 PM
Physikerwelt mentioned this in T339834: HookContainer change: Error: Class 'PSExtensionHandler' not found.Jul 23 2023, 10:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits