Page MenuHomePhabricator

Impossible to close "Mention" popup: Uncaught TypeError: this.transclusionModel.abortRequests is not a function
Closed, ResolvedPublicBUG REPORT

Description

Uncaught TypeError: this.transclusionModel.abortRequests is not a function
    getTeardownProcess mw.flow.ve.ui.MentionInspector.js:346
    proceed Process.js:62
    execute Process.js:97
    teardown Window.js:690
    closeWindow WindowManager.js:549
    setTimeout handler*OO.ui.WindowManager.prototype.closeWindow/</</< WindowManager.js:548
    jQuery 16
    hold Window.js:661
    closeWindow WindowManager.js:546
    setTimeout handler*OO.ui.WindowManager.prototype.closeWindow/< WindowManager.js:545
    jQuery 3
    closeWindow WindowManager.js:537
    close Window.js:601
    afterContextChange ve.ui.LinearContext.js:132
    afterContextChange ve.ui.DesktopContext.js:72
    setTimeout handler*ve.ui.LinearContext.prototype.onContextChange ve.ui.LinearContext.js:87
    emit oojs.js:901
    stopQueueingContextChanges ve.dm.Surface.js:687
    changeInternal ve.dm.Surface.js:1027
    change ve.dm.Surface.js:941
    changeModel ve.ce.Surface.js:4694
    handleObservedChanges ve.ce.Surface.js:3486
    pollOnceInternal ve.ce.SurfaceObserver.js:152
    pollOnce ve.ce.SurfaceObserver.js:108
    activate ve.ce.Surface.js:780
    onDocumentFocus ve.ce.Surface.js:875
    onFocusChange ve.ce.Surface.js:690
mw.flow.ve.ui.MentionInspector.js:346:28
    getTeardownProcess mw.flow.ve.ui.MentionInspector.js:346
    proceed Process.js:62
    execute Process.js:97
    teardown Window.js:690
    closeWindow WindowManager.js:549
    (Async: setTimeout handler)
    closeWindow WindowManager.js:548
    jQuery 16
    hold Window.js:661
    closeWindow WindowManager.js:546
    (Async: setTimeout handler)
    closeWindow WindowManager.js:545
    jQuery 3
    closeWindow WindowManager.js:537
    close Window.js:601
    afterContextChange ve.ui.LinearContext.js:132
    afterContextChange ve.ui.DesktopContext.js:72
    <anonymous> self-hosted:1181
    (Async: setTimeout handler)
    onContextChange ve.ui.LinearContext.js:87
    emit oojs.js:901
    stopQueueingContextChanges ve.dm.Surface.js:687
    changeInternal ve.dm.Surface.js:1027
    change ve.dm.Surface.js:941
    changeModel ve.ce.Surface.js:4694
    handleObservedChanges ve.ce.Surface.js:3486
    pollOnceInternal ve.ce.SurfaceObserver.js:152
    pollOnce ve.ce.SurfaceObserver.js:108
    activate ve.ce.Surface.js:780
    onDocumentFocus ve.ce.Surface.js:875
    onFocusChange ve.ce.Surface.js:690
    <anonymous> self-hosted:1181

Event Timeline

Basically: Use Visual mode, enter @, wait for "Mention" dialog, enter random rubbish which has no match, then click the x button and try to close, fail.
Firefox 91.

Change 714697 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Flow@master] Remove reference to abortRequests method

https://gerrit.wikimedia.org/r/714697

kostajh triaged this task as Medium priority.
kostajh changed the subtype of this task from "Task" to "Bug Report".

Change 714697 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Fix reference to renamed abortAllApiRequests method

https://gerrit.wikimedia.org/r/714697

Change 714678 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Flow@wmf/1.37.0-wmf.20] Fix reference to renamed abortAllApiRequests method

https://gerrit.wikimedia.org/r/714678

Change 714678 merged by jenkins-bot:

[mediawiki/extensions/Flow@wmf/1.37.0-wmf.20] Fix reference to renamed abortAllApiRequests method

https://gerrit.wikimedia.org/r/714678

Mentioned in SAL (#wikimedia-operations) [2021-08-25T18:25:19Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/Flow/modules/editor/editors/visualeditor/ui/inspectors/mw.flow.ve.ui.MentionInspector.js: dd464b4522effbfabea371f8b95b0b25d53da43e: Fix reference to renamed abortAllApiRequests method (T289648) (duration: 01m 04s)