TypeError: Argument 4 passed to MediaWiki\Content\Transform\ContentTransformer::preloadTransform() must be of the type array, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	brennen
	Aug 25 2021, 7:39 PM

Description

Error

mwversion: 1.37.0-wmf.20
reqId: 6c7f5188-0809-44e7-bf1c-040967f2272f
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 4 passed to MediaWiki\Content\Transform\ContentTransformer::preloadTransform() must be of the type array, null given, called in /srv/mediawiki/php-1.37.0-wmf.20/extensions/VisualEditor/includes/ApiVisualEdit

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.20/includes/content/Transform/ContentTransformer.php(60)
#0 /srv/mediawiki/php-1.37.0-wmf.20/extensions/VisualEditor/includes/ApiVisualEditor.php(121): MediaWiki\Content\Transform\ContentTransformer->preloadTransform(WikitextContent, Title, ParserOptions, NULL)
#1 /srv/mediawiki/php-1.37.0-wmf.20/extensions/VisualEditor/includes/ApiVisualEditor.php(272): ApiVisualEditor->getPreloadContent(string, NULL)
#2 /srv/mediawiki/php-1.37.0-wmf.20/includes/api/ApiMain.php(1844): ApiVisualEditor->execute()
#3 /srv/mediawiki/php-1.37.0-wmf.20/includes/api/ApiMain.php(823): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.37.0-wmf.20/includes/api/ApiMain.php(794): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.37.0-wmf.20/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.37.0-wmf.20/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Impact

Notes

4 of these in 1.37.0-wmf.20 (T281161), shortly after rollout to group1.

Tentatively marking as a blocker.

Details

Request URL: https://uk.wiktionary.org/w/api.php?action=visualeditor&format=*&paction=*&page=*&uselang=*&editintro=*&preload=*&formatversion=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make sure params is an array	mediawiki/extensions/VisualEditor	wmf/1.37.0-wmf.20	+1 -1
	Make sure params is an array	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281161 1.37.0-wmf.20 deployment blockers
		Resolved	PRODUCTION ERROR	Zabe	T289730 TypeError: Argument 4 passed to MediaWiki\Content\Transform\ContentTransformer::preloadTransform() must be of the type array, null given

Event Timeline

brennen created this task.Aug 25 2021, 7:39 PM

brennen triaged this task as Unbreak Now! priority.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2021, 7:39 PM

brennen added a project: User-brennen.Aug 25 2021, 7:40 PM

brennen added a parent task: T281161: 1.37.0-wmf.20 deployment blockers.

brennen added a project: Editing-team.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Zabe subscribed.Aug 25 2021, 7:43 PM

Change 714826 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/VisualEditor@master] Make sure params is an array

https://gerrit.wikimedia.org/r/714826

gerritbot added a project: Patch-For-Review.Aug 25 2021, 7:50 PM

Caused by rEVEDe6c93bfbdafd: Replace Content::preloadTransform call to ContentTransformer::preloadTransform.

brennen added a subscriber: dancy.Aug 25 2021, 7:55 PM

ppelberg subscribed.Aug 25 2021, 8:02 PM

matmarex subscribed.Aug 25 2021, 8:03 PM

Change 714826 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make sure params is an array

https://gerrit.wikimedia.org/r/714826

Change 714681 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.20] Make sure params is an array

https://gerrit.wikimedia.org/r/714681

Zabe claimed this task.Aug 25 2021, 8:16 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 25 2021, 9:00 PM

Zabe moved this task from Untriaged to Aug 2021 on the Wikimedia-production-error board.Aug 25 2021, 9:35 PM

Change 714681 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.37.0-wmf.20] Make sure params is an array

https://gerrit.wikimedia.org/r/714681

Mentioned in SAL (#wikimedia-operations) [2021-08-25T22:04:58Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.20/extensions/VisualEditor/includes/ApiVisualEditor.php: rEVED73478bc9c722: Make sure params is an array (T289730) (duration: 01m 04s)