Page MenuHomePhabricator
Create Task
Maniphest T290295

Remove on-wiki Growth config from operations/mediawiki-config
Closed, ResolvedPublic
Actions

Description

Before GrowthExperiments-CommunityConfiguration was a thing, Growth features were configured server-side, in the operations/mediawiki-config repository. Now that we use on-wiki config for it, the server-side config is not in use (and potentially, out of date).

Initially, in-repo config was kept, to act as a fallback for cases when the on-wiki store fails. Since community configuration is with us for some time, we would likely notice if it had bugs.

All newly deployed wikis (as part of Growth-Deployments) don't have server-side config at all.

After considering the current state of community configuration, and after discussion with @Tgr, I think we're safe now to remove config that's now on-wiki from operatons/mediawiki-config.

Details

SubjectRepoBranchLines +/-
Growth: Remove config that moved on-wikioperations/mediawiki-configmaster+0 -1 K
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Sep 3 2021, 6:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2021, 6:50 AM
Urbanecm_WMF triaged this task as Lowest priority.Sep 3 2021, 6:51 AM
gerritbot added a comment.Sep 3 2021, 7:00 AM

Change 717039 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Growth: Remove config that moved on-wiki

https://gerrit.wikimedia.org/r/717039

gerritbot added a project: Patch-For-Review.Sep 3 2021, 7:00 AM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 3 2021, 7:00 AM
Tgr awarded a token.Sep 3 2021, 8:06 PM
gerritbot added a comment.Sep 8 2021, 6:06 PM

Change 717039 merged by jenkins-bot:

[operations/mediawiki-config@master] Growth: Remove config that moved on-wiki

https://gerrit.wikimedia.org/r/717039

Stashbot added a comment.Sep 8 2021, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-08T18:10:23Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: bbefce6a3778f159ad68587c830dff4a1da0c792: Growth: Remove config that moved on-wiki (T290295) (duration: 00m 58s)

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2021, 6:10 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 8 2021, 6:12 PM
Urbanecm_WMF added a subscriber: Etonkovidova.

Moving to QA for @Etonkovidova's awareness. I tested a few wikis while deploying this change, and they continued to work as I would expect. Still, this can theoretically make wikis to ignore their config (although I'm 99% sure all wikis use only the on-wiki config store at this point).

Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Sep 8 2021, 6:12 PM
Etonkovidova closed this task as Resolved.Sep 13 2021, 9:49 PM
In T290295#7340296, @Urbanecm_WMF wrote:

Moving to QA for @Etonkovidova's awareness. I tested a few wikis while deploying this change, and they continued to work as I would expect. Still, this can theoretically make wikis to ignore their config (although I'm 99% sure all wikis use only the on-wiki config store at this point).

Thanks, @Urbanecm_WMF for letting me know. When I reviewed deployed Growthexperiments features T289680: Deploy Growth features to Round 4 wikis - all worked as expected. So I'm closing the task as Resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL