Maniphest T290936

NOTOC magic word removed in a DiscussionTools edit
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Sep 14 2021, 12:31 AM

Tags

Referenced Files

None

Subscribers

Description

__NOTOC__ magic word removed in a DiscussionTools edit: https://tr.wikipedia.org/?diff=26116676

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.20.0-a11	mediawiki/vendor	master	+361 -419
	Lint fostered rendering transparent nodes unless from a template	mediawiki/services/parsoid	master	+24 -10

Customize query in gerrit

Related Objects

Mentioned In: T269548: Parsoid doesn't detect fostered content from a table and causes corruption on DiscussionTools edits
Mentioned Here: T162919: Disable fostering lint error for category and other transparent tags
T269548: Parsoid doesn't detect fostered content from a table and causes corruption on DiscussionTools edits

Event Timeline

matmarex created this task.Sep 14 2021, 12:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2021, 12:31 AM

I suspect this is just a fostered content issue. Didn't Linter flag this page with that error?

Oh, you're right, I didn't notice that it was in the wrong position. I guess this is a dupe of T269548 then?

Didn't Linter flag this page with that error?

The linter skips rendering transparent nodes from T162919
https://github.com/wikimedia/parsoid/blob/master/src/Wt2Html/PP/Processors/Linter.php#L1239

Change 721355 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Lint fostered rendering transparent nodes

https://gerrit.wikimedia.org/r/721355

gerritbot added a project: Patch-For-Review.Sep 15 2021, 4:43 PM

Arlolra triaged this task as Medium priority.Sep 15 2021, 4:44 PM

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Arlolra mentioned this in T269548: Parsoid doesn't detect fostered content from a table and causes corruption on DiscussionTools edits.Sep 15 2021, 5:41 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Sep 17 2021, 1:30 AM

ABreault-WMF claimed this task.Thu, Jun 27, 1:44 AM

ABreault-WMF added projects: Essential-Work, Content-Transform-Team-WIP.

ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

Change #721355 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Lint fostered rendering transparent nodes unless from a template

https://gerrit.wikimedia.org/r/721355

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Fri, Jun 28, 4:33 PM

Maintenance_bot removed a project: Patch-For-Review.Fri, Jun 28, 5:31 PM

Change #1051079 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11

https://gerrit.wikimedia.org/r/1051079

gerritbot added a project: Patch-For-Review.Mon, Jul 1, 9:23 AM

Change #1051079 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11

https://gerrit.wikimedia.org/r/1051079

Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 1, 11:33 AM

ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Tue, Jul 2, 8:46 PM

ABreault-WMF closed this task as Resolved.Thu, Jul 4, 5:15 PM