Page MenuHomePhabricator
Create Task
Maniphest T290936

__NOTOC__ magic word removed in a DiscussionTools edit
Closed, ResolvedPublic
Actions

Description

__NOTOC__ magic word removed in a DiscussionTools edit: https://tr.wikipedia.org/?diff=26116676

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a17mediawiki/vendormaster+387 -263
Emit fostered rendering transparent lints as a separate categorymediawiki/services/parsoidmaster+57 -39
Add a "fostered-transparent" lint categorymediawiki/extensions/Lintermaster+12 -0
Bump wikimedia/parsoid to 0.20.0-a11mediawiki/vendormaster+361 -419
Lint fostered rendering transparent nodes unless from a templatemediawiki/services/parsoidmaster+24 -10
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Sep 14 2021, 12:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2021, 12:31 AM
ssastry subscribed.Sep 14 2021, 12:39 AM

I suspect this is just a fostered content issue. Didn't Linter flag this page with that error?

matmarex added a comment.Sep 14 2021, 1:13 AM

Oh, you're right, I didn't notice that it was in the wrong position. I guess this is a dupe of T269548 then?

Arlolra subscribed.Sep 15 2021, 4:35 PM

Didn't Linter flag this page with that error?

The linter skips rendering transparent nodes from T162919
https://github.com/wikimedia/parsoid/blob/master/src/Wt2Html/PP/Processors/Linter.php#L1239

gerritbot added a comment.Sep 15 2021, 4:43 PM

Change 721355 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Lint fostered rendering transparent nodes

https://gerrit.wikimedia.org/r/721355

gerritbot added a project: Patch-For-Review.Sep 15 2021, 4:43 PM
Arlolra triaged this task as Medium priority.Sep 15 2021, 4:44 PM
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra mentioned this in T269548: Parsoid doesn't detect fostered content from a table and causes corruption on DiscussionTools edits.Sep 15 2021, 5:41 PM
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Sep 17 2021, 1:30 AM
ABreault-WMF claimed this task.Jun 27 2024, 1:44 AM
ABreault-WMF added projects: Essential-Work, Content-Transform-Team-WIP.
ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Jun 28 2024, 4:32 PM

Change #721355 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Lint fostered rendering transparent nodes unless from a template

https://gerrit.wikimedia.org/r/721355

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Jun 28 2024, 4:33 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 28 2024, 5:31 PM
gerritbot added a comment.Jul 1 2024, 9:23 AM

Change #1051079 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11

https://gerrit.wikimedia.org/r/1051079

gerritbot added a project: Patch-For-Review.Jul 1 2024, 9:23 AM
gerritbot added a comment.Jul 1 2024, 11:04 AM

Change #1051079 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11

https://gerrit.wikimedia.org/r/1051079

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 11:33 AM
ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Jul 2 2024, 8:46 PM
ABreault-WMF closed this task as Resolved.Jul 4 2024, 5:15 PM
ABreault-WMF mentioned this in T369317: False positive Linter "fostered content" errors apparently caused by noinclude tags.Jul 12 2024, 7:33 PM
ABreault-WMF mentioned this in T371142: Add a new "fostered-transparent" lint category for when all the fostered content in rendering transparent.Jul 26 2024, 7:16 PM
gerritbot added a comment.Jul 26 2024, 8:41 PM

Change #1057265 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Linter@master] Add a "fostered-transparent" lint category

https://gerrit.wikimedia.org/r/1057265

gerritbot added a project: Patch-For-Review.Jul 26 2024, 8:41 PM
gerritbot added a comment.Jul 26 2024, 8:49 PM

Change #1054409 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Emit fostered rendering transparent lints as a separate category

https://gerrit.wikimedia.org/r/1054409

gerritbot added a comment.Jul 27 2024, 12:36 AM

Change #1057265 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Add a "fostered-transparent" lint category

https://gerrit.wikimedia.org/r/1057265

gerritbot added a comment.Aug 16 2024, 7:53 PM

Change #1054409 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Emit fostered rendering transparent lints as a separate category

https://gerrit.wikimedia.org/r/1054409

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2024, 8:31 PM
gerritbot added a comment.Mon, Aug 19, 1:53 PM

Change #1063811 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

gerritbot added a project: Patch-For-Review.Mon, Aug 19, 1:53 PM
gerritbot added a comment.Mon, Aug 19, 2:32 PM

Change #1063811 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a17

https://gerrit.wikimedia.org/r/1063811

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits