Page MenuHomePhabricator

[interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
*An error is shown: Bad username given Cannot look for contributions without a user or with a user that does not exist.
*Error is sourced from: (mobile-frontend-contributions-404-title)(mobile-frontend-contributions-404-desc)

What should have happened instead?:
*The contributions should be listed.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

image.png (457×862 px, 21 KB)

QA Results - Beta

ACStatusDetails
1T291233#7366148

QA Results - Prod

ACStatusDetails
1T291233#7377105

Event Timeline

Xaosflux renamed this task from MobileFrontend errors out when attempting to view contriutions for IP editors to MobileFrontend errors out when attempting to view contributions for IP editors.Sep 17 2021, 1:11 AM
Xaosflux updated the task description. (Show Details)

Note: it only happens with the old mobile frontend, doesn't occur using the advanced mode.

Note: "Advanced mode" is not available for IP editors if I recall correctly.

It isn't, just a "note" for the reproduction steps.

@Xaosflux, thanks for reporting. I'll have a look at this quickly. This patch touches the History special page and not the Contributions special page. Never the less, I'll look and see what caused the error. Thank you!

I spoke too soon :(, I think I found out what the problem is, I'll work on a fix and submit shortly. Thanks!

Change 721774 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/MobileFrontend@master] specials: Make SpecialContributions be able to view IP editors contribs

https://gerrit.wikimedia.org/r/721774

Locally, this is what I see when logged in:

Screen Shot 2021-09-17 at 10.55.55 AM.png (1×2 px, 192 KB)

Let me know if this is what you expected. Thanks!

I believe that is what is expected, for any testing it may be useful if you can validate that contributions actually appear if they exist (on your test bed have at least 1 edit by an IP, then look at that IP's contribution while using non-advanced mobilefrontend view)

I think I have the correct behaviors now. You can also test the patch to make sure everything works too for you. Thanks!

Locally, this is what I see when logged in:

Screen Shot 2021-09-17 at 10.55.55 AM.png (1×2 px, 192 KB)

Let me know if this is what you expected. Thanks!

That is not Special:MobileContributions that is the desktop version. To show the mobile version using a default configuration you need to log out

Change 721774 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] specials: Make SpecialContributions be able to view IP editors contribs

https://gerrit.wikimedia.org/r/721774

Jdlrobson renamed this task from MobileFrontend errors out when attempting to view contributions for IP editors to [interrupt work/regression] MobileFrontend errors out when attempting to view contributions for IP editors.Sep 17 2021, 3:23 PM
Jdlrobson removed xSavitar as the assignee of this task.
Jdlrobson triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

List of steps to reproduce (step by step, including full links if applicable):

View https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/127.0.0.1 (beta)
(Do not have the opt-in "Advanced Mode" enabled)

✅ AC1: The contributions should be listed.

Screen Shot 2021-09-20 at 9.47.30 AM.png (932×1 px, 103 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

List of steps to reproduce (step by step, including full links if applicable):

View https://test.m.wikipedia.org/wiki/Special:Contributions/127.0.0.1
(Do not have the opt-in "Advanced Mode" enabled)

✅ AC1: The contributions should be listed.

Screen Shot 2021-09-24 at 12.08.04 PM.png (765×1 px, 104 KB)

Edtadros updated the task description. (Show Details)