Page MenuHomePhabricator
Create Task
Maniphest T291474

Library should display in the user's selected language
Closed, ResolvedPublic
Actions

Description

Bug reproduction steps: login → change your language to Deutsch → open the site in incognito/in some other browser then your current browser/ in your smartphone, with browser set to English, and login again you will see the language set to Deutsch in your profile but the interface will be in English.

This is unintended behaviour. When users select a language which differs from their browser language we should respect that and always update the interface to display in the language selected in their preferences.

Related Objects

Event Timeline

• Samwalton9-WMF created this task.Sep 21 2021, 9:40 AM

This was reported in T226804 and may be fixed as part of that task.

• Samwalton9-WMF mentioned this in T226804: Allow users to change their interface language from any page.Sep 21 2021, 9:43 AM
• Samwalton9-WMF edited projects, added The-Wikipedia-Library (Kanban); removed The-Wikipedia-Library.Feb 24 2022, 10:51 AM
• Samwalton9-WMF updated the task description. (Show Details)
• Samwalton9-WMF mentioned this in T302325: Let users know if a collection or url has already been suggested.
jsn.sherman claimed this task.Feb 24 2022, 3:59 PM
jsn.sherman moved this task from Ready to In Progress on the The-Wikipedia-Library (Kanban) board.
jsn.sherman added a comment.Feb 24 2022, 4:17 PM

The cause of this is the code that maintains the browser-configured language during the oauth process. That's the right thing to do when users haven't logged in and set their language yet, but clearly the account preference should take priority once signed in.

jsn.sherman removed jsn.sherman as the assignee of this task.Mar 2 2022, 2:50 PM
jsn.sherman moved this task from Open tasks to Incoming tasks on the Library-Card-Platform board.
jsn.sherman subscribed.
Scardenasmolinar moved this task from In Progress to Ready on the The-Wikipedia-Library (Kanban) board.Mar 2 2022, 2:51 PM
• Samwalton9-WMF merged a task: T277448: Library Card Platform doesn't set the chosen user interface language after logging out.Mar 27 2022, 8:33 AM
• Samwalton9-WMF added subscribers: Amire80, Aklapper.
• Samwalton9-WMF triaged this task as High priority.Apr 14 2022, 2:50 PM
• Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed The-Wikipedia-Library (Kanban).Apr 19 2022, 11:10 AM
Scardenasmolinar claimed this task.Apr 19 2022, 5:25 PM
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Apr 25 2022, 9:41 PM

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/997

jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Apr 26 2022, 6:02 PM

merged

• Samwalton9-WMF added a comment.May 2 2022, 9:44 AM

LGTM, tested by setting my language to French then logging in via incognito window, and everything was in French as expected!

• Samwalton9-WMF closed this task as Resolved.May 2 2022, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits