PostgreSQL passwords containing "\%" do not work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DanielsThomas
	Sep 25 2021, 8:38 PM

Description

During the installation of MediaWiki, when a password containing \% (backslash percent) is used for PostgreSQL, the installer fails to connect to the database. The error shown is not very helpful:

Details

	Subject	Repo	Branch	Lines +/-
	rdbms: escape backslashes in makeConnectionString for PostgreSQL	mediawiki/core	REL1_39	+1 -1
	rdbms: escape backslashes in makeConnectionString for PostgreSQL	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

DanielsThomas created this task.Sep 25 2021, 8:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2021, 8:38 PM

Reedy added a project: MediaWiki-libs-Rdbms.Sep 25 2021, 10:22 PM

Restricted Application added a project: Performance-Team. · View Herald TranscriptSep 25 2021, 10:22 PM

From a quick look at the installer code, it seems it does not do any escaping on its end, which means per @Reedy this is likely an issue in the rdmbs layer indeed. The password is passed from PostgressInstaller::openConnectionToAnyDB to the DatabasePostgress class where makeConnectionString() does some basic quote escaping and then call pg_connect().

Krinkle removed a project: Performance-Team.Sep 27 2021, 7:07 PM

• Thatsthewheelrightthere renamed this task from PostgreSQL passwords containing "\%" do not work to Wow.Apr 3 2022, 8:55 AM

• Thatsthewheelrightthere closed this task as Declined.

• Thatsthewheelrightthere removed projects: MediaWiki-libs-Rdbms, MediaWiki-Installer, PostgreSQL.

• Thatsthewheelrightthere updated the task description. (Show Details)

• Thatsthewheelrightthere removed subscribers: Krinkle, Reedy, Aklapper, DanielsThomas.

RhinosF1 renamed this task from Wow to PostgreSQL passwords containing "\%" do not work .Apr 3 2022, 9:00 AM

RhinosF1 reopened this task as Open.

RhinosF1 added projects: MediaWiki-libs-Rdbms, MediaWiki-Installer, PostgreSQL.

RhinosF1 updated the task description. (Show Details)

RhinosF1 added subscribers: Krinkle, Reedy, Aklapper, DanielsThomas.

Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptApr 3 2022, 9:00 AM

Change 808549 had a related patch set uploaded (by Thomas Daniels; author: Thomas Daniels):

[mediawiki/core@master] rdbms: escape backslashes in makeConnectionString for PostgreSQL

https://gerrit.wikimedia.org/r/808549

gerritbot added a project: Patch-For-Review.Jun 27 2022, 12:53 AM

TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:35 PM

Change 808549 merged by jenkins-bot:

[mediawiki/core@master] rdbms: escape backslashes in makeConnectionString for PostgreSQL

https://gerrit.wikimedia.org/r/808549

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 3 2023, 6:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2023, 6:10 AM

Change 894083 had a related patch set uploaded (by Krinkle; author: Thomas Daniels):

[mediawiki/core@REL1_39] rdbms: escape backslashes in makeConnectionString for PostgreSQL

https://gerrit.wikimedia.org/r/894083

gerritbot added a project: Patch-For-Review.Mar 5 2023, 1:58 AM

Krinkle closed this task as Resolved.Mar 5 2023, 1:58 AM

Krinkle assigned this task to aaron.

Krinkle added a project: Performance-Team.

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.

Change 894083 merged by jenkins-bot:

[mediawiki/core@REL1_39] rdbms: escape backslashes in makeConnectionString for PostgreSQL

https://gerrit.wikimedia.org/r/894083

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2023, 2:10 AM

ReleaseTaggerBot added a project: MW-1.39-notes.Mar 5 2023, 3:00 AM

PostgreSQL passwords containing "\%" do not work Closed, ResolvedPublicActions

Description

Details

Event Timeline

PostgreSQL passwords containing "\%" do not work
Closed, ResolvedPublic
Actions