Page MenuHomePhabricator

Error: Class 'IP' not found
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Class 'IP' not found
exception.trace
from /srv/mediawiki/private/PrivateSettings.php(100)
#0 /srv/mediawiki/php-1.38.0-wmf.2/includes/HookContainer/HookContainer.php(338): {closure}(User, string, boolean, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.2/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.38.0-wmf.2/includes/HookContainer/HookRunner.php(2986): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.38.0-wmf.2/includes/user/User.php(1693): MediaWiki\HookContainer\HookRunner->onPingLimiter(User, string, boolean, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiStashEdit.php(195): User->pingLimiter(string)
#5 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(1874): ApiStashEdit->execute()
#6 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(853): ApiMain->executeAction()
#7 /srv/mediawiki/php-1.38.0-wmf.2/includes/api/ApiMain.php(824): ApiMain->executeActionWithErrorHandling()
#8 /srv/mediawiki/php-1.38.0-wmf.2/api.php(90): ApiMain->execute()
#9 /srv/mediawiki/php-1.38.0-wmf.2/api.php(45): wfApiMain()
#10 /srv/mediawiki/w/api.php(3): require(string)
#11 {main}
Impact

Large number of new errors (~300) spotted within a 15 minute window immediately following 1.38.0-wmf.2 promotion to group0. User impact unknown.

Notes

The deprecated IP class was recently removed as part of T291008: Remove deprecated IP class. However, private settings is still referencing it.

Details

Request URL
https://office.wikimedia.org/w/api.php

Event Timeline

Yeah, caused by me. But since it is PrivateSettings I can't realy do anything about it. Someone who can access that needs to volunteer.

Edit: I see Legoktm is already working on it.

Mentioned in SAL (#wikimedia-operations) [2021-09-28T19:35:43Z] <legoktm@deploy1002> Synchronized private/PrivateSettings.php: Use IPUtils instead of removed IP class (T292010) (duration: 01m 09s)

Legoktm claimed this task.
Legoktm added a subscriber: Legoktm.

Should be fixed now

legoktm@deploy1002:/srv/mediawiki-staging/private$ git show
commit d1df4753484bc334253a383855a2da1eb26a665f (HEAD -> master)
Author: Kunal Mehta <legoktm@wikimedia.org>
Date:   Tue Sep 28 19:29:48 2021 +0000

    Use IPUtils instead of removed IP class

Oops, I didn't think to look there. Sorry, all.