Page MenuHomePhabricator
Create Task
Maniphest T292535

ZObjectStore creation and edition methods return a Status object, should they return Z5 instead?
Closed, ResolvedPublic
Actions

Description

If the ZObjectStore create and update methods need to return Status anyway, find a way to wrap the whole Z5 of an unsuccessful validation

Details

SubjectRepoBranchLines +/-
Add ZObjectPage to wrap WikiPage and ZErrors on ZObject creationmediawiki/extensions/WikiLambdamaster+214 -60
Update function-schemata sub-module to HEAD (1e03e46)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (1e03e46)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (1e03e46)mediawiki/extensions/WikiLambdamaster+2 -1
Add ZObjectStore related error typesmediawiki/services/function-schematamaster+306 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Oct 5 2021, 2:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2021, 2:05 PM
DVrandecic assigned this task to gengh.Oct 20 2021, 4:45 PM
DVrandecic triaged this task as Medium priority.
Jdforrester-WMF moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 25 2021, 11:33 PM
gerritbot added a comment.Nov 3 2021, 11:20 AM

Change 736444 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-schemata@master] Add ZObjectStore related error types

https://gerrit.wikimedia.org/r/736444

gerritbot added a project: Patch-For-Review.Nov 3 2021, 11:20 AM
gerritbot added a comment.Nov 3 2021, 11:30 AM

Change 736446 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add ZObjectPage to wrap WikiPage and ZErrors on ZObject creation

https://gerrit.wikimedia.org/r/736446

gerritbot added a comment.Nov 3 2021, 2:39 PM

Change 736444 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add ZObjectStore related error types

https://gerrit.wikimedia.org/r/736444

gengh mentioned this in rMSFS1e03e46722bb: Add ZObjectStore related error types.Nov 3 2021, 2:40 PM
gerritbot added a comment.Nov 3 2021, 3:04 PM

Change 736491 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736491

gerritbot added a comment.Nov 3 2021, 3:04 PM

Change 736492 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736492

gerritbot added a comment.Nov 3 2021, 3:04 PM

Change 736493 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736493

gerritbot added a comment.Nov 4 2021, 3:58 PM

Change 736493 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736493

gerritbot added a comment.Nov 4 2021, 4:00 PM

Change 736491 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736491

gerritbot added a comment.Nov 4 2021, 4:00 PM

Change 736492 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (1e03e46)

https://gerrit.wikimedia.org/r/736492

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 4 2021, 4:00 PM
Jdforrester-WMF mentioned this in rMSFE5107e6f710b8: Update function-schemata sub-module to HEAD (1e03e46).Nov 4 2021, 4:02 PM
Jdforrester-WMF mentioned this in rMSFO767df81f1299: Update function-schemata sub-module to HEAD (1e03e46).
gerritbot added a comment.Nov 5 2021, 5:43 PM

Change 736446 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add ZObjectPage to wrap WikiPage and ZErrors on ZObject creation

https://gerrit.wikimedia.org/r/736446

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 6:10 PM
Jdforrester-WMF moved this task from Ready to do to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 6 2021, 9:30 PM
DVrandecic closed this task as Resolved.Nov 10 2021, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits