Page MenuHomePhabricator

Update Fresnel to Puppeteer 7 (Chromium 90)
Closed, ResolvedPublic

Description

We're currently on Puppeteer 4 (Chromium 83), which seems to have some difficulty installing itself on Debian Buster / Node 10 / npm 7. It worked fine on npm 6.

The upgrade to npm was accidental, because the quibble-buster docker image forgot to pin the npm.git checkout version (details at T292684), and should be fixed soon by either restoring the npm version and ultimately by upgrading to Node 12 proper.

Meanwhile, @hashar and I reproduced the issue both locally on a clean install, so Quibble itself, nor the Docker image around it isn't part of the problem, it's purely a puppeteer<>npm problem. My bet is on the lock file format since it seems to work fine when I bypass the lock file.

We're overdue for a general release and upgrade of puppeteer and Chromium so I'll just do that at the same time as all the other overhead with a release and pull throughs, tracking on this task.

Event Timeline

Change 730349 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/fresnel@master] build: Update to puppeteer 7 (Chromium 90) and js-yaml 4

https://gerrit.wikimedia.org/r/730349

Change 730352 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/fresnel@master] Release 1.1.0

https://gerrit.wikimedia.org/r/730352

Change 730349 merged by jenkins-bot:

[performance/fresnel@master] build: Update to puppeteer 7 (Chromium 90) and js-yaml 4

https://gerrit.wikimedia.org/r/730349

Change 730352 merged by jenkins-bot:

[performance/fresnel@master] Release 1.1.0

https://gerrit.wikimedia.org/r/730352

Change 730949 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] dockerfiles: Update quibble-fresnel to use Fresnel 1.1.0

https://gerrit.wikimedia.org/r/730949

Change 730951 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] jjb: Update fresnel job to quibble-fresnel:1.1.1-s1

https://gerrit.wikimedia.org/r/730951

Change 730960 had a related patch set uploaded (by Krinkle; author: Krinkle):

[performance/fresnel@master] build: Use lockVersion 2 to fix puppeteer postinstall

https://gerrit.wikimedia.org/r/730960

Change 730960 merged by jenkins-bot:

[performance/fresnel@master] build: Use lockVersion 2 to fix puppeteer postinstall

https://gerrit.wikimedia.org/r/730960

Change 730949 merged by jenkins-bot:

[integration/config@master] dockerfiles: Update quibble-fresnel to use Fresnel 1.1.1

https://gerrit.wikimedia.org/r/730949

Change 730951 merged by jenkins-bot:

[integration/config@master] jjb: Update fresnel job to quibble-fresnel:1.1.1-s1

https://gerrit.wikimedia.org/r/730951