Page MenuHomePhabricator

TablePager on Special:ListFiles shows contextless "Yes" above each picture with small screen width
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

"Yes" above each picture.

What should have happened instead?:
File title should be showing instead perhaps.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

In our mobile browser if we go into settings and click desktop view, we see what the problem originates from. Apparently we are seeing the last three items in each table row: the picture, what it was uploaded by, and the current status: if it is a current picture it is "yes".

I would love to upload a screenshot, but due to bugs with phabricator, that will have to wait until I walk over the hill tomorrow to the high-speed Network.

Aklapper renamed this task from "Yes" above each picture to TablePager on Special:ListFiles shows contextless "Yes" above each picture with small screen width.Oct 17 2021, 4:29 PM
Aklapper edited projects, added MediaWiki-Special-pages; removed Commons.

Hi @Jidanni, thanks for taking the time to report this and for the good steps to reproduce! I can confirm this; it also happens on non-mobile.
This is loosely related to T214208: mw-datatable/TablePager tables need to be visually updated and aligned to wikitable.

Screenshot from 2021-10-17 18-24-10.png (933×645 px, 366 KB)

Screenshot from 2021-10-17 18-24-03.png (933×644 px, 280 KB)

Change 771618 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771618

Change 771618 merged by jenkins-bot:

[mediawiki/core@master] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771618

Change 771646 had a related patch set uploaded (by Reedy; author: Func):

[mediawiki/core@REL1_38] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771646

Change 771647 had a related patch set uploaded (by Reedy; author: Func):

[mediawiki/core@REL1_37] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771647

Change 771648 had a related patch set uploaded (by Reedy; author: Func):

[mediawiki/core@REL1_36] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771648

Change 771649 had a related patch set uploaded (by Reedy; author: Func):

[mediawiki/core@REL1_35] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771649

Change 771649 merged by jenkins-bot:

[mediawiki/core@REL1_35] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771649

Change 771648 merged by jenkins-bot:

[mediawiki/core@REL1_36] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771648

Change 771647 merged by jenkins-bot:

[mediawiki/core@REL1_37] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771647

Change 771646 merged by jenkins-bot:

[mediawiki/core@REL1_38] listFiles: Display file name instead of version

https://gerrit.wikimedia.org/r/771646

matmarex assigned this task to Func.
matmarex subscribed.
Krinkle subscribed.

This change didn't work.

For example, on Beta Cluster:
https://commons.m.wikimedia.beta.wmflabs.org/w/index.php?title=Special:ListFiles&ilshowall=1.

The problem is that the class name used in this patch does not exist. The class name is _top not _img_top.

Change 772004 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772004

Change 772004 merged by jenkins-bot:

[mediawiki/core@master] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772004

Change 772357 had a related patch set uploaded (by Zabe; author: Func):

[mediawiki/core@REL1_38] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772357

Change 772358 had a related patch set uploaded (by Zabe; author: Func):

[mediawiki/core@REL1_37] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772358

Change 772359 had a related patch set uploaded (by Zabe; author: Func):

[mediawiki/core@REL1_36] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772359

Change 772360 had a related patch set uploaded (by Zabe; author: Func):

[mediawiki/core@REL1_35] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772360

Change 772360 merged by jenkins-bot:

[mediawiki/core@REL1_35] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772360

Change 772358 merged by jenkins-bot:

[mediawiki/core@REL1_37] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772358

Change 772357 merged by jenkins-bot:

[mediawiki/core@REL1_38] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772357

Change 772359 merged by jenkins-bot:

[mediawiki/core@REL1_36] listFiles: Follow-up 1b432d4c, fix a typo

https://gerrit.wikimedia.org/r/772359