Page MenuHomePhabricator

Run All Validation as WikiFunctions
Closed, ResolvedPublic

Description

Currently, we validate the inputs and outputs of functions by directly running the validators from function-schemata.

This won't work when users define bespoke validation functions. It also won't work for the Union generic type. Therefore, we must wrap all of these validation functions in Z7s as is done in src/validation.js.

Event Timeline

Change 734413 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Call runTypeValidator for declared/return type validation. Also call schema validation when running type validators.

https://gerrit.wikimedia.org/r/734413

Change 734413 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Perform validation of declared/return types using a WikiFunction.

https://gerrit.wikimedia.org/r/734413