[wmf.6] "Missing MediaInfo tabs" console error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Oct 27 2021, 10:59 PM

Description

Go to Special:MediaSearch or Special:Search.
Open the Console and reload the page.

The "Missing MediaInfo tabs" error will be displayed - seems to be triggered by the following:

mw.hook('wikipage.content').add(function($content) {
                   var linkNoticeWidget = new LinkNoticeWidget(), protectionMsgWidget = new ProtectionMsgWidget(), $statements = $content.find('.wbmi-entityview-statementsGroup'), existingProperties = defaultProperties.concat(Object.keys(mediaInfoEntity.statements || {})), deserializer = new StatementListDeserializer(), tabs, existingStatementPanels;
                   try {
                       tabs = infuseTabs($content);
                   } catch (e) {
                       mw.log.error(e.message);
                       return;
                   }

Notes

The issue is not present in commons betalabs.
The error is not displayed on File pages - but it is displayed on RC, Watchlist, and User, User talk namespaces
No user impact
I could not find the error on "Special:MediaSearch" dashboard in logstash

Details

	Subject	Repo	Branch	Lines +/-
	Ensure media search shows the "no result found" banner	mediawiki/extensions/MediaSearch	master	+0 -6

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Oct 27 2021, 10:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2021, 10:59 PM

Etonkovidova updated the task description. (Show Details)Oct 27 2021, 11:02 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Nov 1 2021, 4:46 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

@Etonkovidova I tried to reproduce this on local and on commons and I cannot reproduce it. Can you please reach out so that I can try and evaluate it with you.

@Simonethis - sorry for a delayed response. I re-tested it and the issue looks more impactful than I realized.

The steps (the issue is in production commons wmf.7and betalabs)

In the search box on any page enter a search term(s) that would return no results and hit 'Enter'
Special:MediaSearch Image tab (the default) will correctly display "We didn't find any results" and the error "Missing MediaInfo tabs" will be present in the Console:

Screen Shot 2021-11-08 at 6.23.06 PM.png (1×3 px, 342 KB)

Switch to a different tab, e.g. Audio - the message "We didn't find any results" will not be present

Screen Shot 2021-11-08 at 6.25.03 PM.png (1×2 px, 235 KB)

Refresh the page - "We didn't find any results" will appear and the error "Missing MediaInfo tabs" will be displayed in the Console.

Amazing thank you! I will work on this as soon as I complete the current ticket!

@Etonkovidova I am going to fix this issue now, but I do not think that this and the error you mention at the very top are related to the error message you mentioned at the very top of the ticket. Also I cannot reproduce that error message in the console myself both locally and in beta, even after following your instruction.

Change 737654 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Ensure media search shows the \"no result found\" banner

https://gerrit.wikimedia.org/r/737654

gerritbot added a project: Patch-For-Review.Nov 9 2021, 11:35 AM

SimoneThisDot claimed this task.Nov 9 2021, 11:35 AM

SimoneThisDot moved this task from Ready for Estimation to Code Review on the Structured-Data-Backlog (Current Work) board.

@SimoneThisDot - I re-checked different browsers and different users, the issue is present only if Gadget-ACDC is enabled.

So, since there is no user impact, the issue is invalid. But since https://gerrit.wikimedia.org/r/737654 is associated with this task, I'll wait for the patch to be deployed to production and then close the task.

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Nov 11 2021, 4:03 PM

Change 737654 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Ensure media search shows the \"no result found\" banner

https://gerrit.wikimedia.org/r/737654

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 11 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2021, 5:10 PM