Page MenuHomePhabricator
Create Task
Maniphest T294519

Ctrl + Del in the new template editor not working on Mac?
Closed, ResolvedPublic
Actions

Description

This is split from T290262: Add keyboard shortcuts for VE template dialog.

We consider this a deployment blocker:

  • The Ctrl + Del shortcut is reported to not work on Mac. It should be, I believe ⌘ instead of Ctrl on Mac. As of now it appears like neither is working.

Nice to have:

  • Please check Ctrl + Shift + cursor keys on Mac as well.
  • I believe these shortcuts are currently implemented in a way that they work only when you use the tab key to navigate to the element in the sidebar you want to move/delete. They don't work when the focus is somewhere else. Please check if this is good enough or if it makes sense to make the shortcut work in more situations, e.g. when the focus is in the parameter search field.

Details

SubjectRepoBranchLines +/-
Support both DELETE and DEL when using template shortcuts on MacOSmediawiki/extensions/VisualEditormaster+2 -2
Exclusively use CMD instead of CTRL for shortcuts on MacOSmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Oct 28 2021, 7:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2021, 7:52 AM
thiemowmde mentioned this in T290262: Add keyboard shortcuts for VE template dialog.Oct 28 2021, 8:09 AM
thiemowmde added a parent task: T290262: Add keyboard shortcuts for VE template dialog.Oct 28 2021, 8:17 AM
Andrew-WMDE claimed this task.Oct 28 2021, 8:22 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-10-27 board.
gerritbot added a comment.Oct 28 2021, 9:59 AM

Change 735312 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Exclusively use CMD instead of CTRL for shortcuts on MacOS

https://gerrit.wikimedia.org/r/735312

gerritbot added a project: Patch-For-Review.Oct 28 2021, 9:59 AM
gerritbot added a comment.Oct 28 2021, 10:21 AM

Change 735315 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Support both DELETE and DEL when using template shortcuts on MacOS

https://gerrit.wikimedia.org/r/735315

thiemowmde moved this task from Doing to UX/PM Review on the WMDE-TechWish-Sprint-2021-10-27 board.Oct 28 2021, 3:36 PM

@ECohen_WMDE, we wonder if on Mac both CMD + Del as well as Ctrl + Del should be supported, or only CMD + Del?

ECohen_WMDE added a comment.Oct 29 2021, 3:30 PM

Good question @thiemowmde - I'm not aware of what the standard approach is. What do the rest of the VE shortcuts do? As a Mac user, I only use CMD so I feel like that would be enough, but I'm not sure if there others have the expectation that Ctrl should work.

thiemowmde added a comment.Oct 29 2021, 3:49 PM

Ah, good point. Other shortcuts in VE are indeed set up in a way that there is only Cmd+… on Mac, and only Ctrl+… on PC. Example: https://phabricator.wikimedia.org/diffusion/GVED/browse/master/src/ui/ve.ui.TriggerRegistry.js$227. Our code should be consistent.

gerritbot added a comment.Oct 29 2021, 4:10 PM

Change 735312 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Exclusively use CMD instead of CTRL for shortcuts on MacOS

https://gerrit.wikimedia.org/r/735312

gerritbot added a comment.Oct 29 2021, 4:10 PM

Change 735315 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Support both DELETE and DEL when using template shortcuts on MacOS

https://gerrit.wikimedia.org/r/735315

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2021, 4:10 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Oct 29 2021, 5:00 PM
ECohen_WMDE added a comment.Nov 1 2021, 10:18 AM

Other shortcuts in VE are indeed set up in a way that there is only Cmd+… on Mac, and only Ctrl+… on PC.

Great! Glad there was an easy answer there.

Lena_WMDE moved this task from UX/PM Review to Sprint Backlog on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 3 2021, 9:16 AM
Andrew-WMDE moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 4 2021, 8:42 AM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Nov 4 2021, 3:42 PM
thiemowmde closed this task as Resolved.Nov 9 2021, 9:33 AM
thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-10-27 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits