Page MenuHomePhabricator

FlaggedRevs does not work in german wiktionary
Closed, ResolvedPublicBUG REPORT

Description

  1. You have to have the "Editors" rights
  2. Goto https://de.wiktionary.org/wiki/ank%C3%BCndigen
  3. Currently there are "Pending Changes" on this page (two edits of an anonymous user)
  4. Click on "review pending changes"
  5. Then on the Button "Accept revision"

What happens?:

  1. There is no error message, but the revision is not accepted.

See: https://de.wiktionary.org/wiki/Wiktionary:Teestube#Manuelles_Sichten_scheint_derzeit_nicht_zu_funktionieren

What should have happened instead?:
The revision should be accepted.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Does this affect all pages or just this single one?

Yeah, I can reproduce this on test2wiki and see this in my browser console from the new rest.php endpoint:

Mandatory field "wpaccuracy" missing from request body.

Since FlaggedRevs seems to be working on group 2 wikis I would agree that this looks new.

Change 735327 had a related patch set uploaded (by RhinosF1; author: RhinosF1):

[mediawiki/extensions/FlaggedRevs@master] Revert \"Create and make use RESTful interface for the review endpoint\"

https://gerrit.wikimedia.org/r/735327

I am investigating this issue. Need some time to give an answer.

Something else is happening, I've just tested this locally and I'm unable to reproduce but yes, this needs some investigation.

Screen Shot 2021-10-28 at 1.03.02 PM.png (1×2 px, 317 KB)

Screen Shot 2021-10-28 at 1.02.41 PM.png (732×2 px, 131 KB)

As an editor, everything works fine for me over here.

Something else is happening, I've just tested this locally and I'm unable to reproduce but yes, this needs some investigation.

This is the interface that fails for me on test2wiki:

image.png (285×600 px, 8 KB)

I think this is working as expected. I'll go back in time and see what was the behavior but this is what I get with the patch

Before (accepting revision):

Screen Shot 2021-10-28 at 1.09.56 PM.png (1×3 px, 424 KB)

After (accepting revision):

Screen Shot 2021-10-28 at 1.10.06 PM.png (1×3 px, 452 KB)

Do you notice the [review pending changes] to the top right of the content page disappears? And the interface also says that the changes have been accepted.

The only thing I need to confirm is the message above the content of the page that says:
2 changes in this version are pending review. The stable version was checked on 28 October 2021.. I'll see if this was the case before the patch.

I just tested this on REL1_37 and this works exactly the same way like my previous message above. See image after accepting the revision

Screen Shot 2021-10-28 at 1.15.23 PM.png (1×3 px, 422 KB)

I think it works, the user just needs to refresh the page normally. Can you try and let me know if something fails? Maybe something else is happening that we're not seeing.

Request form data on both REL1_37 and master (the recent patch applied) looks innocent. See below:

Screen Shot 2021-10-28 at 1.18.48 PM.png (476×2 px, 83 KB)

Screen Shot 2021-10-28 at 1.18.08 PM.png (470×2 px, 78 KB)

I don't see the "accuracy" checkbox that your screenshots have, which the error message I got is also complaining about: Mandatory field "wpaccuracy" missing from request body.

Can you test with

$wgFlaggedRevsTags = [
	'accuracy' => [ 'levels' => 1, 'quality' => 20, 'pristine' => 21 ],
];

, which is what test2wiki uses? Thanks!

You're right @Majavah, without the 'accuracy' field, things are reproducible. Thanks! I think I can make a patch real quick :)

Change 735374 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/FlaggedRevs@master] REST: Avoid making 'wgaccuracy' required in API requests

https://gerrit.wikimedia.org/r/735374

Change 735327 abandoned by RhinosF1:

[mediawiki/extensions/FlaggedRevs@master] Revert \"Create and make use RESTful interface for the review endpoint\"

Reason:

was fixed, no reverts needed.

https://gerrit.wikimedia.org/r/735327

Change 735374 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] REST: Avoid making 'wpaccuracy' required in API requests

https://gerrit.wikimedia.org/r/735374

Change 735330 had a related patch set uploaded (by RhinosF1; author: Derick Alangi):

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.6] REST: Avoid making 'wpaccuracy' required in API requests

https://gerrit.wikimedia.org/r/735330

Hi @Majavah
The bug was fixed. It works. Could you try and let us know if it works? Maybe we could mark this ticket as resolved?

Hi @Vlad.shapik and @Majavah,

in German Wiktionary the bug seems to be fixed and changes can be reviewed again.

Thank you very much.
Best regards Udo T.

Hi @Vlad.shapik and @Majavah,

in German Wiktionary the bug seems to be fixed and changes can be reviewed again.

Thank you very much.
Best regards Udo T.

The issue has not really been fixed on dewiktionary. It's version has only been rolled back to wmf.5, see https://de.wiktionary.org/wiki/Spezial:Version.

Yes, see the comment from the stashbot at 4:04 pm in T293947

Change 735330 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.38.0-wmf.6] REST: Avoid making 'wpaccuracy' required in API requests

https://gerrit.wikimedia.org/r/735330

Mentioned in SAL (#wikimedia-operations) [2021-10-28T19:14:59Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.6/extensions/FlaggedRevs/: 2cd2a4e62af1b66ad29adf27d761129e8fea388a: REST: Avoid making wpaccuracy required in API requests (T294544) (duration: 01m 03s)

@Zabe , but test2. wikipedia.org is also rollbacked to 1.38.0-wmf.5, see https://test2.wikipedia.org/wiki/Special:Version

@Zabe , but test2. wikipedia.org is also rollbacked to 1.38.0-wmf.5, see https://test2.wikipedia.org/wiki/Special:Version

Right, I always forget it's a group1 wiki.

@Zabe, I just have seen in T293947 that group1 wikis have switched to 1.38.0-wmf.6 again.

Can anyone confirm if this is still happening?

German Wiktionary has now Version 1.38.0-wmf.6 again and the bug seems to be fixed

Changes can now be reviewed in Version 1.38.0-wmf.6