trying to deploy RESTBase with scap gives an error
15:22:44 ['/usr/bin/scap', 'deploy-local', '-v', '--repo', 'restbase/deploy', '-g', 'canary', 'config_deploy', '--refresh-config'] (ran as deploy-service@restbase2010.codfw.wmnet) returned [70]: Source basepath: /srv/deployment/restbase/deploy-cache/revs/664a2f8c762ebed9604fdfb04243fe4763da3c60/.git/config-files
Unhandled error:
deploy-local failed: <AttributeError> {}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| conf.yaml.j2: Replace .iteritems() with .items() | mediawiki/services/restbase/deploy | master | +3 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Pchelolo | T294936 RESTBase deployment fails with scap internal error | |||
| Resolved | Legoktm | T294966 Deploy Scap version 4.0.3 |
More info on this
15:22:44 [restbase2010.codfw.wmnet] Unhandled error:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/scap/cli.py", line 352, in run
exit_status = app.main(app.extra_arguments)
File "/usr/lib/python3/dist-packages/scap/deploy.py", line 157, in main
getattr(self, stage)()
File "/usr/lib/python3/dist-packages/scap/deploy.py", line 198, in config_deploy
overrides=overrides,
File "/usr/lib/python3/dist-packages/scap/template.py", line 87, in __init__
env_args = self._make_env_args(loader, erb_syntax, output_format)
File "/usr/lib/python3/dist-packages/scap/template.py", line 95, in _make_env_args
loader = {n: f.decode("utf-8") for n, f in loader.items()}
File "/usr/lib/python3/dist-packages/scap/template.py", line 95, in <dictcomp>
loader = {n: f.decode("utf-8") for n, f in loader.items()}
AttributeError: 'str' object has no attribute 'decode'Which looks like T291990: Scap error when deploying kartotherian
[thcipriani@deploy1002 ~]$ SSH_AUTH_SOCK=/run/keyholder/proxy.sock ssh -l deploy-service -oIdentitiesOnly=yes -oIdentityFile=/etc/keyholder.d/deploy_service.pub restbase2010.codfw.wmnet scap version 4.0.0-1
^ that should be 4.0.2-1 (per T291095: Deploy Scap version 4.0.2).
Pinging serviceops for help: could a serviceopsen ensure that scap is at version 4.0.2 everywhere?
Debmonitor reveals restbase2010 (and a bunch of other servers) are still using scap 4.0.0-1, not 4.0.2-1 with the fixes. I don't have an explanation for the one host running scap 3.17.1 visible on debmonitor, but 4.0.0-1 has a simple explanation: stretch-wikimedia apt repository only has that version, and not the upgraded one.
See the discussion that starts with T294148#7460181 between me and @dancy about the latest scap not being installable on stretch hosts. Can we do a new scap release or should I just cherry-pick 6ba983cb66b16d8095464f58821cd03fc222cd70 to the currently deployed version?
mw2280 has been dead for a while (T290708: decom mw2280 (was: mw2280 unresponsive to powercycle and hardreset)), whenever it comes back online it'll get upgraded.
Mentioned in SAL (#wikimedia-operations) [2021-11-03T22:47:04Z] <legoktm> upgraded scap on A:restbase (T294936)
Actually, different result, now it's UndefinedError instead of AttributeError..
Feel free to try yourself by running scap deploy from /srv/deployment/restbase/deploy. If it succeeds for you it won't deploy anything risky.
Change 736802 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):
[mediawiki/services/restbase/deploy@master] conf.yaml.j2: Replace .iteritems() with .items()
Change 736802 merged by Ppchelko:
[mediawiki/services/restbase/deploy@master] conf.yaml.j2: Replace .iteritems() with .items()