Page MenuHomePhabricator
Create Task
Maniphest T295048

Edit story text manually
Closed, ResolvedPublic
Actions

Assigned To
eamedina
Authored By
• AMuigai
Nov 4 2021, 2:54 PM
Tags
Referenced Files
F34963281: Empty text box.png
Feb 23 2022, 5:34 PM
F34963284: editing complete.png
Feb 23 2022, 5:34 PM
F34963286: Removed text in editing mode.png
Feb 23 2022, 5:34 PM
F34963287: Story page with text.png
Feb 23 2022, 5:34 PM
F34963289: modified text after edit.png
Feb 23 2022, 5:34 PM
F34963285: Editing mode.png
Feb 23 2022, 5:34 PM
F34854777: 01 Info. banner.png
Dec 7 2021, 12:43 PM
F34854662: Add text 14.png
Dec 7 2021, 12:36 PM
View All 19 Files
Subscribers
Aklapper
• AMuigai
eamedina
• EUdoh-WMF
SBisson
SGautam_WMF

Description

User story

As a story creator, I want to edit the text I have selected from a Wikipedia article so it fits my story better.

Design details

Empty text box.png (780×360 px, 295 KB)
  • Show an empty text box after user selects images for story.
Story page with text.png (780×360 px, 267 KB)
Editing mode.png (780×360 px, 127 KB)
editing complete.png (780×360 px, 120 KB)
Removed text in editing mode.png (780×360 px, 142 KB)
  • After text selection, enter in text editing mode by tapping on the text box.
  • Placeholder text becomes available when a user removes the entire text from the text box.
modified text after edit.png (780×360 px, 256 KB)
  • Confirm edits when tap outside the text box or tap on done button on top.

Design file

Note
We are going to decide the what action to assign device back key during the development phase.

Details

SubjectRepoBranchLines +/-
Edit story textmediawiki/extensions/Wikistoriesmaster+175 -34
Make sure the text from image search is in plain text. This is a pre-first step for T295048mediawiki/extensions/Wikistoriesmaster+11 -5
Customize query in gerrit

Related Objects

Event Timeline

• AMuigai created this task.Nov 4 2021, 2:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2021, 2:54 PM
SBisson moved this task from Backlog to Definition on the Inuka-Team (Kanban) board.Nov 5 2021, 3:12 PM
SBisson added subscribers: SGautam_WMF, SBisson.

Dropping this in the design column for @SGautam_WMF to add design details.

• AMuigai updated the task description. (Show Details)Nov 29 2021, 7:48 PM
• AMuigai renamed this task from Introduce edit button on Wikistories prototype to Support text editing on Wikistories prototype.Nov 30 2021, 11:28 AM
• AMuigai updated the task description. (Show Details)
• AMuigai updated the task description. (Show Details)Nov 30 2021, 9:03 PM
• AMuigai updated the task description. (Show Details)
• AMuigai renamed this task from Support text editing on Wikistories prototype to Support text editing on Wikistories prototype after text selection.Nov 30 2021, 9:23 PM
• AMuigai updated the task description. (Show Details)
SGautam_WMF updated the task description. (Show Details)Dec 7 2021, 12:36 PM
SGautam_WMF updated the task description. (Show Details)Dec 7 2021, 12:38 PM
SGautam_WMF updated the task description. (Show Details)
SGautam_WMF updated the task description. (Show Details)Dec 7 2021, 12:41 PM
SGautam_WMF updated the task description. (Show Details)
SGautam_WMF updated the task description. (Show Details)
SGautam_WMF updated the task description. (Show Details)Dec 7 2021, 12:43 PM
• AMuigai edited projects, added Wikistories; removed Wikistories (Prototype).Jan 13 2022, 11:47 AM
SBisson renamed this task from Support text editing on Wikistories prototype after text selection to Edit story text manually.Feb 2 2022, 8:23 PM
SBisson edited projects, added Wikistories (MVP); removed Wikistories.
SBisson updated the task description. (Show Details)
SBisson triaged this task as Medium priority.Feb 4 2022, 7:35 PM
SBisson raised the priority of this task from Medium to High.Feb 10 2022, 7:15 PM
SGautam_WMF updated the task description. (Show Details)Feb 23 2022, 5:34 PM
SBisson moved this task from Definition to Ready for Dev on the Inuka-Team (Kanban) board.Feb 23 2022, 5:41 PM
SBisson added a comment.Mar 10 2022, 3:31 PM

Some idea for an implementation plan

  1. Make sure the text from search results in plain text (it's own patch)
  2. Replace <p> with <textarea>
  3. Save new text to the store when/after edit
  4. Dark overlay with "Done" button when textarea is focused, clicking them will blur the textarea
  5. Text and position of the "edit" button, and only visible when the textarea is empty
  6. Make sure the store keeps track of original text from article or Commons and actual text (after edit)
eamedina claimed this task.Mar 10 2022, 3:32 PM
eamedina subscribed.
eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.Mar 10 2022, 4:50 PM
gerritbot added a comment.Mar 14 2022, 6:53 PM

Change 770574 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Make sure the text from image search is in plain text. This is a pre-first step for T295048

https://gerrit.wikimedia.org/r/770574

gerritbot added a project: Patch-For-Review.Mar 14 2022, 6:53 PM
gerritbot added a comment.Mar 14 2022, 8:32 PM

Change 770574 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Make sure the text from image search is in plain text. This is a pre-first step for T295048

https://gerrit.wikimedia.org/r/770574

eamedina mentioned this in rEWSTd90111509e8d: Make sure the text from image search is in plain text. This is a pre-first step….Mar 14 2022, 8:32 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 14 2022, 9:10 PM
gerritbot added a comment.Mar 14 2022, 9:57 PM

Change 770612 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Edit story text

https://gerrit.wikimedia.org/r/770612

gerritbot added a project: Patch-For-Review.Mar 14 2022, 9:57 PM
hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Mar 17 2022, 9:15 AM
eamedina mentioned this in T304388: [Improvement] A more flexible AutoHeightTextarea.Mar 22 2022, 1:22 AM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Mar 22 2022, 5:38 PM
gerritbot added a comment.Mar 22 2022, 5:39 PM

Change 770612 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Edit story text

https://gerrit.wikimedia.org/r/770612

eamedina mentioned this in rEWST6bfdbd957c73: Edit story text.Mar 22 2022, 5:39 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 6:10 PM
SBisson moved this task from MVP to Beta on the Wikistories board.Mar 30 2022, 12:29 PM
SBisson edited projects, added Wikistories (Beta); removed Wikistories (MVP).
• EUdoh-WMF subscribed.EditedApr 19 2022, 8:02 PM

Testing:

  • After text selection, user can tap in the text area and edit text.
  • Placeholder text is available when the user deletes all text and taps outside the text box.
  • When user taps outside the text area, user can navigate to another story page and upon returning, the text entered in the previous story page in still present the text area.

All passed.

• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Apr 19 2022, 8:02 PM
SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.May 20 2022, 10:44 AM
SGautam_WMF closed this task as Resolved.May 20 2022, 11:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL