Page MenuHomePhabricator

ModeSelector relies on new ZType to be fetched, and breaks when the type has already been used in the UI
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Access Special:CreateZObject page
  • Select a list as the type
  • Add an item as select "key"
  • Add another item and also select "key"
  • Change the mode selector of the Type within the first key item
  • Change the mode selector of the type of the second item

What happens?:

  • The mode selector in the second items do not act as the first and it breaks

What should have happened instead?:

  • The mode selector should allow you to change between different modes without breaking

Note:
The issue currently it is that the ModeSelector assign a literal Type (in the ZObjectKey.vue) only when the getZKeys changes (it is on a watch). This just trigger the first time and not subsequent times.

This was done on purpose, so changing things need lots of testing

Event Timeline

SimoneThisDot renamed this task from ModeSelector relies on zType to be changed for it to be anabled to ModeSelector relies on new ZType to be fetched, and breaks when the type has already been used in the UI.Nov 5 2021, 12:48 PM
DVrandecic triaged this task as Medium priority.Dec 8 2021, 11:32 PM

Change 765583 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] update logic for determining the literal type for type creation

https://gerrit.wikimedia.org/r/765583

Change 765583 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] update logic for determining the literal type for type creation

https://gerrit.wikimedia.org/r/765583