Page MenuHomePhabricator
Create Task
Maniphest T295149

Payment session lost causing error page throwing exception
Closed, ResolvedPublic
Actions

Description

Noticed this while working through the fraud filters. On "reject" in the Phase_Validate case, the page is redirected without the payment parameters which causes the error page attached below (url: https://localhost:9001/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&ffname=error-cc&gateway=adyen). On digging deeper, it was realised that the session was lost at some point in the process.

Screenshot 2021-11-05 at 15.03.35.png (1×1 px, 506 KB)

WIP Gerrit patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/736651/

To reproduce locally
Make a donation attempt that triggers the filters that gives a Referrer risk score of 70

Details

SubjectRepoBranchLines +/-
WIP: Handle payment result on reject in validation phasemediawiki/extensions/DonationInterfacemaster+5 -1
Show error form when error in getPaymentMethodsmediawiki/extensions/DonationInterfacemaster+9 -8
Catch errors in setClientVariablesmediawiki/extensions/DonationInterfacemaster+28 -2
Adyen: Return array on errors in getCheckoutConfigurationmediawiki/extensions/DonationInterfacemaster+17 -15
Validate params for getPaymentMethods before callwikimedia/fundraising/SmashPigmaster+33 -0
Customize query in gerrit

Related Objects

Event Timeline

Damilare created this task.Nov 5 2021, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2021, 2:04 PM
Damilare updated the task description. (Show Details)Nov 5 2021, 2:05 PM
Damilare updated the task description. (Show Details)Nov 5 2021, 2:14 PM
gerritbot added a comment.Nov 8 2021, 3:54 PM

Change 736651 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[mediawiki/extensions/DonationInterface@master] WIP: Handle payment result on reject in validation phase

https://gerrit.wikimedia.org/r/736651

gerritbot added a project: Patch-For-Review.Nov 8 2021, 3:54 PM
XenoRyet added a project: fundraising sprint Universal Cereal Bus.Nov 8 2021, 8:42 PM
XenoRyet moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
XenoRyet added a project: Fundraising Sprint Visual C Saw.Nov 9 2021, 9:20 PM
XenoRyet added a project: fundraising sprint Wireless Zipline.Nov 23 2021, 9:23 PM
• DStrine triaged this task as Medium priority.Dec 3 2021, 5:18 PM
• DStrine removed a project: fundraising sprint Wireless Zipline.Dec 7 2021, 8:13 PM
• DStrine moved this task from Current Sprint to Q3 2021-2022 on the Fundraising-Backlog board.
Cstone subscribed.Dec 23 2021, 9:12 PM

I ran into this today testing on production when I forgot to add the utm_campaign to the test URL. The donations were authed in the Adyen console.

frauderror.png (237×1 px, 39 KB)

Cstone mentioned this in T293292: Adyen forms for Big Bundle.Dec 31 2021, 7:08 PM
gerritbot added a comment.Jan 13 2022, 1:19 AM

Change 753599 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Validate params for getPaymentMethods before call

https://gerrit.wikimedia.org/r/753599

gerritbot added a comment.Jan 13 2022, 1:37 AM

Change 753600 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Adyen: Don't throw errors in getCheckoutConfiguration

https://gerrit.wikimedia.org/r/753600

gerritbot added a comment.Jan 18 2022, 9:43 PM

Change 753599 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Validate params for getPaymentMethods before call

https://gerrit.wikimedia.org/r/753599

gerritbot added a comment.Oct 13 2022, 9:57 PM

Change 753600 abandoned by Ejegg:

[mediawiki/extensions/DonationInterface@master] Adyen: Return array on errors in getCheckoutConfiguration

Reason:

see I66904685ea9b1c1b6ec6d701de0584b17c6840a3

https://gerrit.wikimedia.org/r/753600

gerritbot added a comment.Oct 14 2022, 12:58 AM

Change 842549 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Catch errors in setClientVariables

https://gerrit.wikimedia.org/r/842549

gerritbot added a comment.Oct 14 2022, 1:05 AM

Change 842550 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Show error form when error in getPaymentMethods

https://gerrit.wikimedia.org/r/842550

Ejegg added a project: Fundraising Tech - Chaos Crew.EditedOct 14 2022, 1:15 AM
Ejegg subscribed.

The same patches should solve this and T293131

Ejegg moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.Oct 14 2022, 1:15 AM
AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Tech - Chaos Crew board.Oct 14 2022, 11:53 PM
AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Tech - Chaos Crew board.Oct 20 2022, 8:05 PM
gerritbot added a comment.Oct 20 2022, 8:18 PM

Change 842549 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Catch errors in setClientVariables

https://gerrit.wikimedia.org/r/842549

gerritbot added a comment.Oct 20 2022, 8:18 PM

Change 842550 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Show error form when error in getPaymentMethods

https://gerrit.wikimedia.org/r/842550

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 20 2022, 9:00 PM
Ejegg moved this task from Pending Deployment to Completed 20221025 - 20221107 on the Fundraising Tech - Chaos Crew board.Oct 27 2022, 1:49 AM
greg closed this task as Resolved.Nov 9 2022, 8:27 PM
greg assigned this task to Ejegg.
greg set the point value for this task to 1.
Dwisehaupt removed the point value for this task.Nov 9 2022, 8:38 PM
Dwisehaupt set Final Story Points to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits