OpenSeaDragon (OSD) button tooltips are not translated
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Samwilson
	Nov 15 2021, 7:39 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Edit a Page page in a language other than English, e.g. qqx: https://en.wikisource.beta.wmflabs.org/w/index.php?title=Page:War_and_Peace.djvu/58&action=edit&uselang=qqx

What happens?:

The tooltips for the three zooms are still in English.

What should have happened instead?:

They should be displayed as their message names in parentheses, e.g. (proofreadpage-zoom-in)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

ProofreadPage version 1bb92ca59ab28b45c4324606cab9f0ada1e2bffc

Details

	Subject	Repo	Branch	Lines +/-
	OSD: Use MW translations for OSD controls	mediawiki/extensions/ProofreadPage	master	+29 -9

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T276530 JumpToFile: tracking
Resolved		None	T276042 JumpToFile: make high-res loading optional and add offset
Stalled		None	T276052 Make page-carousel icon zones shareable, generic areas for multi-script use
Open	Feature	None	T294903 ProofreadPage: Implement region selection UI for the OCR tool directly in the PRP page editor
Resolved		Inductiveload	T288146 JumpToFile: Port to OpenSeadragon implementation
Resolved		Inductiveload	T288318 PageCarousel: Port to OpenSeadragon implementation
Resolved		Inductiveload	T288141 ProofreadPage: use OpenSeadragon for the Page NS image viewer
Resolved	BUG REPORT	Inductiveload	T295662 OpenSeaDragon (OSD) button tooltips are not translated

Event Timeline

(Oops, sorry didn't mean to add you all as subscribers; I used the 'create subtask' link.)

No that's fine, I'll take a look. I did notice it, but there's such a backlog of unmerged OSD-related changes I didn't want to work on it just yet because it'll probably need rebasing over and over again before it merges.

Change 738914 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] OSD: Use MW translations for OSD controls

https://gerrit.wikimedia.org/r/738914

gerritbot added a project: Patch-For-Review.Nov 15 2021, 2:54 PM

Inductiveload moved this task from Backlog to Usability/UX/Batch actions on the ProofreadPage board.Nov 19 2021, 5:53 PM

Nemo_bis added a project: I18n.Nov 21 2021, 8:51 AM

Billinghurst renamed this task from OSD button tooltips are not translated to OpenSeaDragon (OSD) button tooltips are not translated.Nov 21 2021, 9:51 AM

Inductiveload triaged this task as Medium priority.Nov 21 2021, 11:55 AM

Change 738914 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] OSD: Use MW translations for OSD controls

https://gerrit.wikimedia.org/r/738914

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 21 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2021, 9:10 PM

Inductiveload moved this task from Usability/UX/Batch actions to Done: to deploy/check on the ProofreadPage board.Nov 23 2021, 1:14 PM

This is now working.

Alex_brollo mentioned this in T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.Jan 4 2022, 7:29 PM