Page MenuHomePhabricator
Create Task
Maniphest T295799

Get libup to work for parsoid
Closed, ResolvedPublic
Actions

Description

Maybe not for master (though, why not?), but certainly for supported release branches... Any chance we can run LibUp against parsoid. Due to issues like T295797: Fix mwgate-node12-docker failures in Parsoid branches

Not necessarily urgent we make releases afterwards, but having the release branches of parsoid not fail when someone tries to make further changes would be awesome

Details

SubjectRepoBranchLines +/-
Move .eslintrc to .eslintrc.jsonmediawiki/services/parsoidREL1_37+108 -108
Move .eslintrc to .eslintrc.jsonmediawiki/services/parsoidREL1_37+73 -76
Move .eslintrc to .eslintrc.jsonmediawiki/services/parsoidREL1_36+70 -73
Move .eslintrc to .eslintrc.jsonmediawiki/services/parsoidREL1_35+71 -74
Bump Parsoid to 0.15.0-a11mediawiki/vendormaster+7 K -5 K
Move .eslintrc to .eslintrc.jsonmediawiki/services/parsoidmaster+108 -108
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Nov 16 2021, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2021, 6:18 PM
Legoktm subscribed.Nov 16 2021, 6:33 PM

It's running...or at least trying and failing: https://libraryupgrader2.wmcloud.org/r/mediawiki/services/parsoid?branch=main

IIRC it used to fail because of shrinkwrap but that's no longer an issue. The current failure is because https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/parsoid/+/refs/heads/master/.eslintrc has comments in it.

Legoktm renamed this task from Can we run libup for parsoid? to Get libup to work for parsoid.Nov 16 2021, 6:34 PM
gerritbot added a comment.Nov 16 2021, 6:42 PM

Change 739322 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@master] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/739322

gerritbot added a project: Patch-For-Review.Nov 16 2021, 6:42 PM
gerritbot added a comment.Nov 17 2021, 10:58 PM

Change 739322 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/739322

Arlolra closed this task as Resolved.Nov 17 2021, 11:08 PM
Arlolra claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Nov 17 2021, 11:10 PM
Reedy added a comment.Nov 17 2021, 11:33 PM

Do we need to "backport" this to the release branches so libup is happy?

Legoktm added a comment.Nov 18 2021, 12:11 AM

Probably, might also be worth waiting a day for the next libup run to see if anything else fails.

Arlolra reopened this task as Open.Nov 18 2021, 5:04 PM
Arlolra moved this task from Needs Triage to Testing on the Parsoid board.

Sorry, did I close this prematurely

Arlolra removed Arlolra as the assignee of this task.Nov 18 2021, 5:04 PM
Arlolra subscribed.
Zabe subscribed.Nov 19 2021, 11:26 PM

Seems to be working now: https://libraryupgrader2.wmcloud.org/logs2/543690

gerritbot added a comment.Nov 19 2021, 11:30 PM

Change 740248 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_37] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740248

gerritbot added a project: Patch-For-Review.Nov 19 2021, 11:30 PM
gerritbot added a comment.Nov 23 2021, 6:37 PM

Change 740869 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_36] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740869

gerritbot added a comment.Nov 23 2021, 6:38 PM

Change 740870 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/services/parsoid@REL1_35] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740870

gerritbot added a comment.Nov 29 2021, 10:18 PM

Change 742570 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a11

https://gerrit.wikimedia.org/r/742570

gerritbot added a comment.Nov 30 2021, 1:12 AM

Change 742570 merged by jenkins-bot:

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a11

https://gerrit.wikimedia.org/r/742570

gerritbot added a comment.Dec 11 2021, 11:07 PM

Change 740870 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_35] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740870

gerritbot added a comment.Dec 11 2021, 11:08 PM

Change 740869 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_36] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740869

gerritbot added a comment.Dec 11 2021, 11:09 PM

Change 740248 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_37] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/740248

gerritbot added a comment.Aug 15 2022, 10:11 PM

Change 823249 had a related patch set uploaded (by Arlolra; author: Zabe):

[mediawiki/services/parsoid@REL1_37] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/823249

gerritbot added a comment.Aug 15 2022, 11:42 PM

Change 823249 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_37] Move .eslintrc to .eslintrc.json

https://gerrit.wikimedia.org/r/823249

Umherirrender closed this task as Resolved.Dec 15 2022, 3:03 PM
Umherirrender subscribed.

LibUp commits against parsoid - https://gerrit.wikimedia.org/r/q/project:mediawiki/services/parsoid+owner:tools.libraryupgrader%2540tools.wmflabs.org

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits