Accepts negative change id numbers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Nov 30 2021, 5:04 PM

Description

The number chooser on https://deploy-commands.toolforge.org/bacc will let you enter negative numbers (press down arrow).

Hitting Get commands then results in a Internal Server Error

Details

	Subject	Repo	Branch	Lines +/-
	Fix input attribute name	labs/tools/deploy-commands	master	+1 -1
	Turn change ID input from type=number into inputmode=numeric	labs/tools/deploy-commands	master	+1 -1

Customize query in gerrit

Event Timeline

Reedy created this task.Nov 30 2021, 5:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2021, 5:04 PM

Change 742772 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[labs/tools/deploy-commands@master] Turn change ID input from type=number into inputmode=numeric

https://gerrit.wikimedia.org/r/742772

gerritbot added a project: Patch-For-Review.Nov 30 2021, 5:43 PM

Change 742772 merged by Ladsgroup:

[labs/tools/deploy-commands@master] Turn change ID input from type=number into inputmode=numeric

https://gerrit.wikimedia.org/r/742772

You have my sincere apologies, by being a member in phabricator, it doesn't send you an email for each ticket in the project (which I thought it would) so I didn't get any notification for any of these. I'm so sorry.

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 9:10 PM

Feel free to reopen if you think it's not fixed yet.

I can still type in -1 and hit Get commands and it gives an Internal Server Error.

Screen Recording 2021-12-08 at 22.58.44.mov285 KBDownload

Bah, the attribute is called pattern, not format 🤦

Change 745483 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[labs/tools/deploy-commands@master] Fix input attribute name

https://gerrit.wikimedia.org/r/745483

gerritbot added a project: Patch-For-Review.Dec 9 2021, 10:10 AM

(This doesn’t fix the backend error, of course, but it should prevent you from reaching it unless you do naughty things. I think that’s generally acceptable for a Toolforge tool, as long as the internal server error doesn’t cause problems beyond the one request, which I wouldn’t expect here.)

In T296760#7558927, @Lucas_Werkmeister_WMDE wrote:

(This doesn’t fix the backend error, of course, but it should prevent you from reaching it unless you do naughty things. I think that’s generally acceptable for a Toolforge tool, as long as the internal server error doesn’t cause problems beyond the one request, which I wouldn’t expect here.)

This is not a mission critical productions service, if people do naughty things, they will get naughty responses.

Change 745483 merged by Ladsgroup:

[labs/tools/deploy-commands@master] Fix input attribute name

https://gerrit.wikimedia.org/r/745483