Page MenuHomePhabricator

Very long words cause overflow on watchlist/rc pages on mobile
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • add a page to your watchlist
  • make an edit and in the edit summary use a very long word without a single space to that page
  • open your watchlist or recent changes pages

What happens?:

  • The contents of the edit summary overflow the viewport

What should have happened instead?:

  • The contents should have wrapped

This happens because this element is floated and will therefore grow unless bounded with max-width

Screenshot 2021-12-04 at 13.21.10.png (824×1 px, 123 KB)

QA steps

QA Results - Beta

ACStatusDetails
1T297045#7556705
2T297045#7556705

QA Results - Prod

ACStatusDetails
1T297045#7579268
2T297045#7579268

Event Timeline

screenshot with patch:

Screenshot 2021-12-04 at 13.20.48.png (840×982 px, 90 KB)

Change 743571 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/skins/MinervaNeue@master] Fix viewport overflow in RC/Watchlist editsummaries

https://gerrit.wikimedia.org/r/743571

Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Upcoming to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)

Change 743571 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix viewport overflow in RC/Watchlist editsummaries

https://gerrit.wikimedia.org/r/743571

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Confirm that the summaries on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson do wrap

Screen Shot 2021-12-08 at 8.40.51 AM.png (899×415 px, 84 KB)

✅ AC2: Watch the page https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_mention_test_0.32663851022409507 and find the same edit on your watchlist and check it does wrap there https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&enhanced=1&urlversion=2

Screen Shot 2021-12-08 at 8.41.52 AM.png (898×415 px, 68 KB)

Edtadros added a subscriber: Edtadros.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Confirm that the summaries on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson do wrap

en.m.wikipedia.org_wiki_Special_Contributions_Jdlrobson(iPhone 11 Pro Max).png (2×1 px, 476 KB)

✅ AC2: Watch the page https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_mention_test_0.32663851022409507 and find the same edit on your watchlist and check it doesn't wrap there https://en.m.wikipedia.org/wiki/Special:Watchlist?hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&enhanced=1&urlversion=2

en.m.wikipedia.org_w_index.php_hidepreviousrevisions=1&hidecategorization=1&hideWikibase=1&limit=250&days=30&enhanced=1&title=Special_Watchlist&watchlistview=a-z&urlversion=2(iPhone 11 Pro Max).png (2×1 px, 341 KB)