Glosses get double margin-right because of duplicated div
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	jhsoby
	Dec 9 2021, 12:09 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Go to a lexeme with a gloss, for example https://www.wikidata.org/wiki/Lexeme:L622500
Notice that the field is very narrow (it is even more noticeable when you edit)

What happens?:
The field with the actual gloss is way too narrow. It happens because a div.wikibase-lexeme-sense-glosses (which has margin-right: 252px;) for some reason is wrapped in another div.wikibase-lexeme-sense-glosses, resulting in a total margin-right of 504px.

What should have happened instead?:

Only one div.wikibase-lexeme-sense-glosses

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Wikidata production

Details

	Subject	Repo	Branch	Lines +/-
	Fix LexemeHeader and GlossWidget mounting	mediawiki/extensions/WikibaseLexeme	master	+11 -3
	Fix LexemeHeader and GlossWidget mounting	mediawiki/extensions/WikibaseLexeme	wmf/1.38.0-wmf.12	+11 -3

Customize query in gerrit

Event Timeline

jhsoby created this task.Dec 9 2021, 12:09 AM

jhsoby updated the task description. (Show Details)

It happens because a div.wikibase-lexeme-sense-glosses … for some reason is wrapped in another div.wikibase-lexeme-sense-glosses

Probably due to Use createMwApp() instead of new Vue(), changing the mounting behavior. Shouldn’t be too hard to fix+backport tomorrow.

Maintenance_bot added a project: Wikidata.Dec 9 2021, 12:45 AM

Lydia_Pintscher added a project: Wikidata-Campsite.Dec 9 2021, 9:23 AM

Lydia_Pintscher moved this task from Incoming to Needs Wikidata PM Work on the Wikidata-Campsite board.

Manuel moved this task from Needs Wikidata PM Work to Unconnected Stories on the Wikidata-Campsite board.Dec 9 2021, 9:28 AM

Manuel moved this task from Unconnected Stories to Team A Hearth 🏰🔥 on the Wikidata-Campsite board.Dec 9 2021, 9:33 AM

Manuel edited projects, added Wikidata-Campsite (Team A Hearth 🏰🔥); removed Wikidata-Campsite.

Manuel moved this task from Incoming to Prioritized Backlog on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.

Manuel moved this task from Prioritized Backlog to Incoming on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.

Lucas_Werkmeister_WMDE claimed this task.Dec 9 2021, 9:52 AM

Lucas_Werkmeister_WMDE moved this task from Incoming to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.

Change 745481 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Fix LexemeHeader and GlossWidget mounting

https://gerrit.wikimedia.org/r/745481

gerritbot added a project: Patch-For-Review.Dec 9 2021, 9:52 AM

Change 745372 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.12] Fix LexemeHeader and GlossWidget mounting

https://gerrit.wikimedia.org/r/745372

Change 745372 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.12] Fix LexemeHeader and GlossWidget mounting

https://gerrit.wikimedia.org/r/745372

Mentioned in SAL (#wikimedia-operations) [2021-12-09T11:07:47Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/WikibaseLexeme/resources/widgets/: Backport: [[gerrit:745372|Fix LexemeHeader and GlossWidget mounting (T297328)]] (duration: 01m 06s)

The master change is still open due to CI issues, will investigate. Should be fixed in production for now, though.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 9 2021, 12:00 PM

Change 745481 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Fix LexemeHeader and GlossWidget mounting

https://gerrit.wikimedia.org/r/745481

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 10 2021, 12:00 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Product Verification on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Dec 10 2021, 12:05 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 12:10 PM

@Lucas_Werkmeister_WMDE: I just tried this and it still seems to be an issue. Can you confirm this?

No, for me it seems to be fixed:

Thank you for checking! I have avoided getting familiar with Lexemes so far, so I did not know how it should look like.

Speaking of very narrow: The input field for the Lemma looks a bit off as well. But admittedly, I chose a very long word and don't know how this was intended to look like. :)

Lemmas have always looked like this, let’s not turn this into a general WikibaseLexeme UI review 😅

@jhsoby can you paste the screenshot you’d posted in Telegram, of what it looked like with the bug?

That's definitely fixed, yeah. 😊 Lemma input is narrow, but always has been, so not a new issue.

In T297328#7563124, @Lucas_Werkmeister_WMDE wrote:

let’s not turn this into a general WikibaseLexeme UI review 😅

Haha, fair! That was not my intention, lets close this one! \o/

Thank you @jhsoby!

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 10 2021, 5:16 PM

	F34877084: Screenshot 2021-12-10 at 15-28-55 kondolere.png
	Dec 10 2021, 2:29 PM

	F34877106: image.png
	Dec 10 2021, 2:45 PM

	F34877103: image.png
	Dec 10 2021, 2:45 PM

Glosses get double margin-right because of duplicated divClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Glosses get double margin-right because of duplicated div
Closed, ResolvedPublicBUG REPORT
Actions