Page MenuHomePhabricator
Create Task
Maniphest T297338

Switching to horizontal mode in ProofreadPage leaves the edit window narrow
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Switch to horizontal mode while editing a page in Page: namespace in Wikisource using the "Proofread tools" -> "Vertical/horizontal layout" icon

What happens?:
The edit window remains half-screen width, leaving the right-half as a blue empty square

What should have happened instead?:
The edit window should be full-screen width to effectively use whole screen in edit mode.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
MediaWiki 1.38.0-wmf.12 (rMW9574ef2738c8), tested on FF but this probably does not matter.

obraz.png (967×1 px, 333 KB)

Related Objects

Event Timeline

Ankry created this task.Dec 9 2021, 4:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2021, 4:29 AM
Ankry updated the task description. (Show Details)Dec 9 2021, 4:33 AM
Inductiveload mentioned this in T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie".Dec 16 2021, 9:45 PM
Xover merged a task: T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie".Dec 22 2021, 8:21 AM
Xover added subscribers: Starshollow, Inductiveload, Xover and 3 others.
Inductiveload added a comment.Dec 22 2021, 8:26 AM

The Bug tag doesn't link this issue (it also fixes T297339), but this should be fixed when https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/745460 deploys (maybe today?)

Soda subscribed.Dec 22 2021, 8:36 AM
In T297338#7585354, @Inductiveload wrote:

The Bug tag doesn't link this issue (it also fixes T297339), but this should be fixed when https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/745460 deploys (maybe today?)

The commit is in 1.38.0-wmf.14 so based on the schedule, not before 4th Jan 2022.

Inductiveload added a comment.Dec 22 2021, 8:40 AM

Also no backport windows for two weeks either: https://wikitech.wikimedia.org/wiki/Deployments

Aklapper renamed this task from Swithing to horizontal mode in ProofreadPage leaves the edit window narrow to Switching to horizontal mode in ProofreadPage leaves the edit window narrow.Dec 22 2021, 9:14 AM
Inductiveload closed this task as Resolved.Jan 7 2022, 4:57 PM
Inductiveload claimed this task.

This should now have been fixed (works at enWS, at least)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits