Page MenuHomePhabricator

Special:EditGrowthConfig violates writes=0 expectation in SpecialPageFactory::executePath
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
Expectation (writes <=) 0 by MediaWiki\SpecialPage\SpecialPageFactory::executePath not met (actual: {actual}) in trx #{trxId}:
{query}
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/TransactionProfiler.php(468)
#0 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/TransactionProfiler.php(289): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated(string, Wikimedia\Rdbms\GeneralizedSql, integer, string, string)
#1 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/Database.php(1520): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion(Wikimedia\Rdbms\GeneralizedSql, double, boolean, integer, string, string)
#2 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/Database.php(1400): Wikimedia\Rdbms\Database->executeQueryAttempt(string, string, boolean, string, integer)
#3 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/Database.php(1323): Wikimedia\Rdbms\Database->executeQuery(string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/Database.php(2679): Wikimedia\Rdbms\Database->query(string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->update(string, array, string, string)
#6 /srv/mediawiki/php-1.38.0-wmf.12/includes/libs/rdbms/database/DBConnRef.php(386): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#7 /srv/mediawiki/php-1.38.0-wmf.12/includes/page/WikiPage.php(1459): Wikimedia\Rdbms\DBConnRef->update(string, array, array, string)
#8 /srv/mediawiki/php-1.38.0-wmf.12/includes/Storage/PageUpdater.php(1274): WikiPage->updateRevisionOn(Wikimedia\Rdbms\DBConnRef, MediaWiki\Revision\RevisionStoreRecord, NULL, boolean)
#9 /srv/mediawiki/php-1.38.0-wmf.12/includes/Storage/PageUpdater.php(870): MediaWiki\Storage\PageUpdater->doModify(CommentStoreComment)
#10 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php(186): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#11 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(905): GrowthExperiments\Config\WikiPageConfigWriter->save(string)
#12 /srv/mediawiki/php-1.38.0-wmf.12/includes/htmlform/HTMLForm.php(718): GrowthExperiments\Specials\SpecialEditGrowthConfig->onSubmit(array, OOUIHTMLForm)
#13 /srv/mediawiki/php-1.38.0-wmf.12/includes/htmlform/HTMLForm.php(608): HTMLForm->trySubmit()
#14 /srv/mediawiki/php-1.38.0-wmf.12/includes/htmlform/HTMLForm.php(624): HTMLForm->tryAuthorizedSubmit()
#15 /srv/mediawiki/php-1.38.0-wmf.12/includes/specialpage/FormSpecialPage.php(187): HTMLForm->show()
#16 /srv/mediawiki/php-1.38.0-wmf.12/extensions/GrowthExperiments/includes/Specials/SpecialEditGrowthConfig.php(123): FormSpecialPage->execute(NULL)
#17 /srv/mediawiki/php-1.38.0-wmf.12/includes/specialpage/SpecialPage.php(647): GrowthExperiments\Specials\SpecialEditGrowthConfig->execute(NULL)
#18 /srv/mediawiki/php-1.38.0-wmf.12/includes/specialpage/SpecialPageFactory.php(1377): SpecialPage->run(NULL)
#19 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#20 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(903): MediaWiki->performRequest()
#21 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(563): MediaWiki->main()
#22 /srv/mediawiki/php-1.38.0-wmf.12/index.php(53): MediaWiki->run()
#23 /srv/mediawiki/php-1.38.0-wmf.12/index.php(46): wfIndexMain()
#24 /srv/mediawiki/w/index.php(3): require(string)
#25 {main}
Impact

Just noise. ~30/day.

Notes

Details

Request URL
https://ca.wikipedia.org/wiki/Especial:EditGrowthConfig
Related Changes in Gerrit:

Event Timeline

Change 747680 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Hardcode EditGrowthConfig requiresWrite/doesWrites

https://gerrit.wikimedia.org/r/747680

Change 747680 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Hardcode EditGrowthConfig requiresWrite/doesWrites

https://gerrit.wikimedia.org/r/747680

Krinkle triaged this task as Medium priority.Jan 11 2022, 11:43 PM
Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.