Page MenuHomePhabricator
Create Task
Maniphest T298037

Exception thrown and comment not highlighted when replying to non-subscribable sections
Closed, ResolvedPublic
Actions

Description

e.g. in lede sections.

Testing

  1. Add a comment manually to the top of the page, above the first heading
  2. Reply with the reply tool
  3. Observe your new comment is not highlighted

Details

SubjectRepoBranchLines +/-
Implement getSubscribableHeading/isSubscribable in JS and usemediawiki/extensions/DiscussionToolsmaster+35 -8
Customize query in gerrit

Event Timeline

• Esanders created this task.Dec 20 2021, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2021, 4:29 PM
gerritbot added a comment.Dec 20 2021, 4:31 PM

Change 748742 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Implement getSubscribableHeading/isSubscribalble in JS and use

https://gerrit.wikimedia.org/r/748742

gerritbot added a project: Patch-For-Review.Dec 20 2021, 4:31 PM
• Esanders claimed this task.Dec 20 2021, 4:31 PM
• Esanders added a project: Editing-team (Kanban Board).
• Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
matmarex subscribed.Dec 20 2021, 9:44 PM

Observe your new comment is not highlighted

The highlighting actually still worked for me (which may be the reason why we didn't notice this).

gerritbot added a comment.Dec 20 2021, 9:49 PM

Change 748742 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Implement getSubscribableHeading/isSubscribable in JS and use

https://gerrit.wikimedia.org/r/748742

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Dec 20 2021, 9:56 PM
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 20 2021, 10:00 PM
• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:04 AM
JJMC89 reopened this task as Open.Dec 21 2021, 12:06 AM
ppelberg closed this task as Resolved.Dec 22 2021, 1:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits