PhanCommentAbstractOnInheritedMethod false positive
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jan 4 2022, 11:11 PM

Description

22:52:26 includes/libs/rdbms/database/MWMySQLPlatform.php:7 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWMySQLPlatform inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it
22:52:26 includes/libs/rdbms/database/MWPostgreSqlPlatform.php:8 PhanCommentAbstractOnInheritedMethod Class \Wikimedia\Rdbms\MWPostgreSqlPlatform inherits a method \Doctrine\DBAL\Platforms\AbstractPlatform::createReservedKeywordsList declared at vendor/doctrine/dbal/src/Platforms/AbstractPlatform.php:3521 marked as @abstract in phpdoc but does not override it

Trying to upgrade doctrine/dbal to 3.1.5 brings in https://github.com/doctrine/dbal/blob/3.1.5/src/Platforms/AbstractPlatform.php#L3517

Details

	Subject	Repo	Branch	Lines +/-
	build: Update mediawiki/mediawiki-phan-config to 0.12.0	mediawiki/core	REL1_39	+29 -64
	build: Update mediawiki/mediawiki-phan-config to 0.12.0	mediawiki/core	master	+29 -64

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T298571 PhanCommentAbstractOnInheritedMethod false positive
Resolved	Daimona	T298576 Upgrade phan to 5.3.2 or later
Resolved	Daimona	T311452 Taint Check Plugin release

Event Timeline

Reedy created this task.Jan 4 2022, 11:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2022, 11:11 PM

Reedy added a project: Upstream.Jan 4 2022, 11:13 PM

Filed upstream https://github.com/phan/phan/issues/4640

Worked around using @phan-file-suppress PhanCommentAbstractOnInheritedMethod in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/751201 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/751202

Reedy moved this task from Backlog to Reported Upstream on the Upstream board.Jan 5 2022, 12:03 AM

Fixed in https://github.com/phan/phan/pull/4641

In T298571#7599121, @Reedy wrote:

Fixed in https://github.com/phan/phan/pull/4641

Which should become 5.3.2.... T298576: Upgrade phan to 5.3.2 or later may bring this in depending on when it happens (if later than 5.3.1)

Reedy added a subtask: T298576: Upgrade phan to 5.3.2 or later.Feb 3 2022, 5:37 PM

Reedy closed subtask T298576: Upgrade phan to 5.3.2 or later as Resolved.Mar 5 2022, 6:14 PM

Daimona reopened subtask T298576: Upgrade phan to 5.3.2 or later as Open.Mar 5 2022, 6:19 PM

Daimona closed subtask T298576: Upgrade phan to 5.3.2 or later as Resolved.Oct 6 2022, 12:53 PM

Daimona claimed this task.Oct 8 2022, 1:44 PM

Change 840274 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] build: Update mediawiki/mediawiki-phan-config to 0.12.0

https://gerrit.wikimedia.org/r/840274

gerritbot added a project: Patch-For-Review.Oct 8 2022, 1:46 PM

Change 840274 merged by jenkins-bot:

[mediawiki/core@master] build: Update mediawiki/mediawiki-phan-config to 0.12.0

https://gerrit.wikimedia.org/r/840274

Daimona closed this task as Resolved.Oct 9 2022, 12:00 AM

Daimona removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 9 2022, 1:00 AM

Change 934280 had a related patch set uploaded (by Reedy; author: Daimona Eaytoy):

[mediawiki/core@REL1_39] build: Update mediawiki/mediawiki-phan-config to 0.12.0

https://gerrit.wikimedia.org/r/934280

gerritbot added a project: Patch-For-Review.Jun 29 2023, 10:01 AM

Change 934280 merged by jenkins-bot: