Taint Check Plugin release
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jun 27 2022, 7:37 PM

Description

https://github.com/wikimedia/phan-taint-check-plugin/compare/3.3.2...master

Details

	Subject	Repo	Branch	Lines +/-
	Bump phan to 5.4.1 and prepare for 4.0.0 release	mediawiki/tools/phan/SecurityCheckPlugin	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
Open	None	T379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Open	None	T378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Open	None	T358666 Drop PHP 8.1 support from MediaWiki
Open	None	T380185 Prepare for newer geoip2/geoip2 library
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled	None	T334726 Use return type `never` in Wikibase
Stalled	None	T373753 Drop symfony/polyfill-php80 and symfony/polyfill-php81 from mediawiki-vendor
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved	Jdforrester-WMF	T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved	Jdforrester-WMF	T319065 All Wikimedia production extensions and skins must support PHP 8.1
Resolved	Daimona	T311451 Re-enable PHP 8.1 CI on css-sanitizer
Open	None	T319596 Upgrade, release, and use new PHP 7.4+ versions of all our home-grown CI libraries
Resolved	Daimona	T319538 Release new version of mediawiki-phan-config with phan 5.4.1 and taint-check 4.0.0 and tell LibUp about it
Resolved	Daimona	T298571 PhanCommentAbstractOnInheritedMethod false positive
Resolved	Daimona	T301079 PhanPossiblyUndeclaredVariable false positive
Resolved	Daimona	T298576 Upgrade phan to 5.3.2 or later
Resolved	Daimona	T311452 Taint Check Plugin release

Event Timeline

Reedy created this task.Jun 27 2022, 7:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2022, 7:37 PM

Reedy added a parent task: T311451: Re-enable PHP 8.1 CI on css-sanitizer.Jun 27 2022, 7:38 PM

Reedy added a parent task: T298576: Upgrade phan to 5.3.2 or later.Jun 27 2022, 7:43 PM

Daimona mentioned this in T318184: phan-taint-check-plugin does not support complex Hooks declaration.Oct 4 2022, 11:57 AM

So, last time I thought we should've waited for some work in taint-check to be finished before tagging a new release. However, a few months have passed without me being able to do anything to the plugin, so I think we may as well just tag a new version now, especially because some bugfixes are needed in various repos (e.g., T318184). There are roughly 80 commits between 3.3.2 and master, some of which are fairly large. In particular, there are two breaking changes that may introduce lots of "unused suppression" warnings and potentially other warnings. All in all, I think this should be version 4.0.0, and I'm gonna write the pre-release commit now.

Change 838128 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] BUmp phan to 5.4.1 and prepare for 4.0.0 release

https://gerrit.wikimedia.org/r/838128

gerritbot added a project: Patch-For-Review.Oct 4 2022, 12:05 PM

• dcausse awarded a token.Oct 4 2022, 12:13 PM

Change 838128 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Bump phan to 5.4.1 and prepare for 4.0.0 release

https://gerrit.wikimedia.org/r/838128

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 10:30 PM