Page MenuHomePhabricator
Create Task
Maniphest T319432

Migrate WMF production from PHP 7.4 to PHP 8.1
Open, Stalled, MediumPublic
Actions

Assigned To
Krinkle
Authored By
Krinkle
Oct 5 2022, 3:28 PM
Tags
Referenced Files
F53712686: 2023_php_EOL_Composer.png
May 18 2024, 3:17 PM
F53712005: 2023_php_EOL_wmf.png
May 18 2024, 3:17 PM
Subscribers
Aklapper
akosiaris
ArielGlenn
Daimona
freephile
gmodena
Izno
View All 27 Subscribers
Tokens
"Love" token, awarded by Michael."Love" token, awarded by hashar."Yellow Medal" token, awarded by kostajh.

Description

T271736: Migrate WMF production from PHP 7.2 to PHP 7.4 | T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3

The next target for WMF production after PHP 7.4, is PHP 8.1. This will incorporate:

  • Assurance that this should work
    • CI configured to require PHP 8.1 to pass for all production code
      • Making CI passing and enforced ("voting") for MediaWiki core on PHP 8.0 and PHP 8.1.
      • Making CI passing wmf-deployed MediaWiki extensions and skins on PHP 8.0 and PHP 8.1.
    • Other tooling changes as needed
  • Preparation of Wikimedia production
    • Provision PHP 8.1 in production via puppet and docker (including any ports or changes needed for php extension packages such as php-apcu, php-luasandbox, php-excimer, etc.)
    • Configure MW with ICU emulation for PHP 8.1 that matches PHP 7.4 (see also: T263437, T292552).
  • Pre-launch testing
    • Benchmarks for different workloads and different clusters.
    • ? Add an option to WikimediaDebug to select which version is used
    • Add ability to do consistent client-side ramp-up via a WikimediaEvents cookie.
  • Per-cluster ramp-up:
    • App servers
      • N% of all cookie-based traffic to Appservers and API appservers
      • Parsoid
      • Job runners
      • Appservers
      • API appservers
    • Snapshot hosts ("dumps")
    • Deployment hosts
    • Maintenance hosts
    • Wikitech host
  • Decommission support for PHP 7.4 from production
  • Drop PHP 7.4 and 8.0 testing from CI, if not otherwise needed for release branches

Details

SubjectRepoBranchLines +/-
MediaWiki-Docker: Switch PHP images to PHP 8.1mediawiki/coremaster+4 -2
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Add PHP 8.1 imagesrepos/releng/dev-images!23jforresterphp81main
Customize query in GitLab

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT328919 Upgrade to PHPUnit 10
 OpenNoneT338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
 OpenNoneT328921 Drop PHP 7.4 support from MediaWiki
 StalledNoneT334726 Use return type `never` in Wikibase
 OpenNoneT328922 Drop PHP 8.0 support from MediaWiki
 StalledNoneT319055 Upgrade to psr/container 2.x
 StalledFeatureNoneT364249 New upstream release for Pygments (2.18.0)
 StalledKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedtstarlingT292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 ResolvedtstarlingT314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedReedyT311448 Echo PHP 8.1 support
 ResolvedBUG REPORTtstarlingT289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
 ResolvedtstarlingT320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
 ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
 ResolvedDaimonaT311452 Taint Check Plugin release
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
 ResolvedJdforrester-WMFT311463 Re-enable PHP 8.1 CI on Zest
 Resolved• ssastryT307632 mediawiki/libs/Zest phan issues under 8.1
 ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
 ResolvedkostajhT321691 StructuredDiscussions support for PHP 8.1
 ResolvedthiemowmdeT321692 FileImporter support for PHP 8.1
 ResolvedtstarlingT322098 GeoData support for PHP 8.1
 ResolvedtstarlingT322099 TwoColConflict support for PHP 8.1
 ResolvedBUG REPORTLucas_Werkmeister_WMDET319219 Wikibase gives deprecated warnings on php 8.1
 ResolvedhooT301249 Handle deprecation of Serializable interface in Wikibase
 ResolvedhooT305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
 ResolvedJdforrester-WMFT322233 PageViewInfo support for PHP 8.1
 ResolvedthiemowmdeT322408 CirrusSearch support for PHP 8.1
 ResolvedkostajhT322838 PageTriage PHP 8.1 support
 ResolvedUmherirrenderT323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
 ResolvedPRODUCTION ERROR• brookeT289189 getid3: PHP Warning: Division by zero
 ResolvedTheresNoTimeT332356 function strftime() is deprecated in php8.1 used by Calendar extension
 ResolvedtstarlingT322278 MediaWiki core should pass Phan on PHP 8.1
 OpenJdforrester-WMFT320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4
 ResolvedlarissagauliaT321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
 ResolvedJMeybohmT345561 Upgrade the MediaWiki servers to ICU 67
 ResolvedMoritzMuehlenhoffT350767 Rebuild PHP 7.4 packages for Bullseye
 OpenNoneT290536 Serve production traffic via Kubernetes
 ResolvedjijikiT280497 Benchmark performance of MediaWiki on k8s
 ResolvedaaronT293630 Investigate performance degradation at high concurrencies in php-fpm
OpenjijikiT292707 Migrate Wikitech to Kubernetes
 In ProgressClement_GoubertT321786 Deploy mediawiki kubernetes services
 ResolvedClement_GoubertT321895 Create mw-api-int helmfile deployment
 ResolvedClement_GoubertT321896 Create mw-api-ext helmfile deployment
 ResolvedClement_GoubertT321897 Create mw-jobrunner helmfile deployment
 StalledClement_GoubertT321899 Create mw-videoscaler helmfile deployment
 ResolvedClement_GoubertT321900 Create mw-web helmfile deployment
 ResolvedClement_GoubertT323296 Stop spamming SAL with helmfile on scap deployments
 ResolvedClement_GoubertT323621 Make mw-web and mw-api-ext available behind LVS
 ResolvedJoeT323349 Improve performance of deployment to mw on k8s
 ResolvedcolewhiteT325085 Increase in Logstash warnings
 ResolvedClement_GoubertT331318 Find a sensible way to direct traffic to mw-on-k8s
 ResolvedClement_GoubertT331268 Migrate testwikidata to Kubernetes
 In ProgressClement_GoubertT333120 Migrate internal traffic to k8s
 ResolvedClement_GoubertT334060 Migrate linkrecommendations to mw-api-int
 ResolvedClement_GoubertT334061 Migrate push-notifications to mw-api-int
 ResolvedClement_GoubertT334062 Migrate recommendation-api to mw-api-int
 InvalidClement_GoubertT334063 Migrate tegola-vector-tiles to mw-api-int
 ResolvedJoeT334064 Migrate termbox to mw-api-int
 ResolvedClement_GoubertT334065 Migrate api-gateway to mw-api-int
 ResolvedClement_GoubertT334204 Migrate cxserver to mw-api-int
 ResolvedClement_GoubertT334456 Monitor all mw-on-k8s deployments with httpbb
 ResolvedClement_GoubertT334561 Add mw-on-k8s deployments to mediawiki certificates
 ResolvedJoeT342252 Migrate rdf-streaming-updater to connect to mw-on-k8s
 ResolvedJoeT346447 Migrate wikifeeds to mw-api-int
 ResolvedJoeT346448 Migrate all eventgate installations to mw-api-int
 ResolvedJMeybohmT347397 Migrate functions-orchestrator service to mw-api-int
 ResolvedJoeT350846 Migrate mobileapps to k8s
 ResolvedClement_GoubertT357785 Migrate mw-page-content-change-enrich to mw-api-int
 ResolvedClement_GoubertT358213 Migrate restbase from mwapi-async to mw-api-int
 ResolvedClement_GoubertT298265 Have internal MediaWiki to MediaWiki HTTP requests use an envoyproxy on appservers
 DeclinedClement_GoubertT360625 Alter changeprop chart to use the service mesh
 ResolvedClement_GoubertT360767 Migrate changeprop to mw-api-int
 ResolvedelukeyT362316 Migrate ml-services to mw-api-int
 StalledKrinkleT333269 Benchmark baremetal vs k8s mediawiki perf (2023)
 ResolvedjijikiT336025 ResourceLoader icon rasterization fails via MediaWiki-on-Kubernetes
 ResolvedJoeT336037 Add configuration file support to mw-on-k8s.lua ATS script
 ResolvedJoeT336038 Add traffic sampling support to mw-on-k8s.lua ATS script
 ResolvedClement_GoubertT337490 Migrate group0 to Kubernetes
 ResolvedBUG REPORTClement_GoubertT340483 ExtensionDistributor is broken on k8s
 ResolvedClement_GoubertT337489 Run QTE test suite on testwiki on kubernetes
 ResolvedClement_GoubertT340549 Migrate group1 to Kubernetes
 ResolvedClement_GoubertT341078 Direct 0.5% of all traffic to mw-on-k8s
 ResolvedClement_GoubertT341463 Direct 1% of all traffic to mw-on-k8s
 ResolvedClement_GoubertT341780 Direct 5% of all traffic to mw-on-k8s
 ResolvedJoeT341825 Max upload size on k8s is 2M
 ResolvedClement_GoubertT342748 mw-on-k8s app container CPU throttling at low average load
 ResolvedClement_GoubertT343306 Wikikube CPU capacity issue
 ResolvedJclark-ctrT343708 Physical re-labeling of mw1497 and mw1498 to kubernetes1025 and kubernetes1026
 ResolvedJMeybohmT343978 Allow more flexibility in ResourceQuota and LimitRanger config
 ResolvedJoeT283056 Create a mwdebug deployment for mediawiki on kubernetes
 ResolvedJoeT284417 Add the puppet CA to the MediaWiki deployment
 ResolvedNoneT284418 Add conditional to mediawiki-config for stuff running on kubernetes
 ResolvedjijikiT284420 Add all redis and memcached backends to mw on k8s automatically
 ResolvedjijikiT284421 Enable TLS termination on the mwdebug deployment. fix the service definition in the chart
 ResolveddancyT284581 Ownership of the /tmp/mw-cache directories should be www-data in the mediawiki-multiversion image
 ResolveddancyT284582 The restricted/mediawiki-multiversion image should include the production version of private/PrivateSettings.php
 ResolvedJoeT285298 Make all httpbb tests pass on the mwdebug deployment.
 ResolvedJoeT285309 Install wiki-specific php extensions in the mediawiki production image
 ResolvedjeenaT285325 Check out www-portals repo in the mediawiki-webserver and in the mediawiki-multiversion images
 ResolvedJoeT285232 The restricted/mediawiki-webserver image should include skins and resources
 ResolvedJoeT286491 Access mwdebug kubernetes deployment via the 'X-Wikimedia-Debug' header
 ResolveddancyT287512 GitInfo is missing from mwdebug-kubernetes deployment
 ResolvedJoeT287570 Ensure the code is deployed to mediawiki on k8s when it is deployed to production
 Resolved• dpifkeT288164 Ensure WikimediaDebug "log" and "profile" features work with k8s-mwdebug
 ResolveddancyT287495 Create a variant of mediawiki-multiversion which installs php-tideways-xhprof
 ResolvedJoeT288851 Make logging work for mediawiki in k8s
 ResolvedClement_GoubertT326794 Ingest php-slowlog in logstash
 ResolvedcolewhiteT328318 Index orchestrator object fields from ECS 1.11.0 in OpenSearch
 ResolvedjijikiT290485 mediawiki-debug image does not produce profiling info
Resolved• dpifkeT288165 Create separate ArcLamp pipeline for k8s-mwdebug
 ResolvedLegoktmT288848 Make HTTP calls work within mediawiki on kubernetes
ResolvedClement_GoubertT343390 MW-on-k8s traffic logs fewer errors than expected (increase in jsonTruncated)
ResolvedJMeybohmT277876 Reserve resources for system daemons on kubernetes nodes
 ResolvedClement_GoubertT346422 Move 10% of mediawiki external requests to mw on k8s
 ResolvedClement_GoubertT344814 mw-on-k8s tls-proxy container CPU throttling at low average load
 OpenNoneT354532 Limit the concurrency of envoy in service mesh
 OpenClement_GoubertT345243 Remove tls-proxy cpu limits on eventstreams
 In ProgressClement_GoubertT345244 Remove tls-proxy cpu limits on eventgate
 ResolvedClement_GoubertT347493 Serve Wikidata traffic via Kubernetes
 ResolvedClement_GoubertT348122 Move 25% of mediawiki external requests to mw on k8s
 ResolvedhnowlanT349796 Move MediaWiki jobs to mw-on-k8s
 ResolvedakosiarisT352906 mediawiki k8s jobrunner fails connecting to cloudelastic with a TLS error
 OpenhnowlanT354791 Reclaim jobrunner hardware for k8s
 ResolvedClement_GoubertT355622 scap not installed on mw1486.eqiad.wmnet which breaks deployment: /usr/bin/scap: No such file or directory
 ResolvedNoneT355243 MediaModeration maintenance script scanFilesInScanTable.php indirectly calls $wgImageMagickConvertCommand
 ResolvedDreamy_JazzT355309 Don't use RENDER_NOW when generating thumbnails for PhotoDNA scans
 ResolvedPRODUCTION ERRORDreamy_JazzT355177 Error creating thumbnail: mkdir: cannot create directory '/sys/fs/cgroup/memory/mediawiki/job/XXXXX':
 ResolvedkostajhT356047 Attempt to generate thumbnail by requesting URL
 ResolvedjijikiT359154 Update DC switchover cookbooks to handle mw-jobrunners
 OpenNoneT351074 Move servers from the appserver/api cluster to kubernetes
 ResolvedkamilaT354413 Reboot issues for mw13[77-83].eqiad.wmnet
 ResolvedJhancock.wmT367736 Relabel codfw kubernetes nodes
 ResolvedJclark-ctrT367789 Relabel eqiad kubernetes nodes
 OpenNoneT368079 Relabel codfw kubernetes nodes
 ResolvedClement_GoubertT355532 Move 40% of mediawiki external requests to mw on k8s
 ResolvedClement_GoubertT355534 Move testwiki over to mw-on-k8s
 ResolvedakosiarisT357392 Create parsoid mediawiki deployment and migrate parsoid-php.discovery.wmnet traffic to it
 OpenNoneT358588 A lot of `[info] Wikitext for this page has duplicate ids:` in logstash for mw-parsoid. Possibly related to PageBundle
 ResolvedakosiarisT358752 Reimage parse* hosts as kubernetes nodes
 ResolveddancyT357402 Scap should check errors coming from mw-on-k8s canaries during deployments
 ResolvedClement_GoubertT357508 Move 60% of mediawiki external requests to mw on k8s
 ResolvedClement_GoubertT358117 Adapt scap's testing strategy to mw-on-k8s
 ResolvedClement_GoubertT357507 Move 50% of mediawiki external requests to mw on k8s
 ResolvedClement_GoubertT360763 Move 70% of mediawiki external requests to mw on k8s
 OpenClement_GoubertT362323 Move 100% of external traffic to Kubernetes
 ResolvedCDanisT367894 update status page latency for mw-on-k8s
 OpenjijikiT277711 Memcached, mcrouter in MediaWiki on Kubernetes
 ResolvedJoeT278220 Define the size of a pod for mediawiki in terms of resource usage
 In ProgressjijikiT346690 mcrouter daemonset on mw-on-k8s
 ResolvedjijikiT362766 2024-04-17 mw-on-k8s eqiad outage
 OpenNoneT363186 Cache mw-mcrouter service ClusterIP in apcu cache
 ResolvedJdforrester-WMFT362662 Rename X-Wikimedia-Debug k8s-experimental option
 ResolvedjijikiT365478 XWD: Allow choosing datacentre in k8s-mwdebug
 OpenClement_GoubertT367949 Turn down api_appserver and appserver clusters
 ResolvedClement_GoubertT368058 Set all appservers to pooled=inactive in scap

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
hashar added a comment.Oct 17 2022, 8:34 AM
In T319432#8315497, @Jdforrester-WMF wrote:

The wmf-quibble jobs are rather expensive. Do we really need to run these for 8.0 as well as 8.1 if we're not going planning to deploy to that target ever?

The wmf-quibble jobs should use whatever PHP versions are currently in use at Wikimedia so indeed that would be 8.1.

That being said, we should still test them with 8.0, but with the regular quibble jobs rather than the wmf-quibble integration one.

Krinkle triaged this task as Medium priority.Oct 17 2022, 7:15 PM
Krinkle moved this task from Inbox, needs triage to To-do: Goals, prioritized next 4 Quarters on the Performance-Team board.
Krinkle claimed this task.Oct 18 2022, 7:08 PM
Krinkle moved this task from To-do: Goals, prioritized next 4 Quarters to To-do: Goals prioritized current Quarter on the Performance-Team board.
kostajh awarded a token.Oct 18 2022, 7:12 PM
kostajh subscribed.
Krinkle added a subscriber: Reedy.EditedOct 24 2022, 3:31 PM
In T319432#8315497, @Jdforrester-WMF wrote:

8.1 not 8.0 or 8.2?

The next target for production is PHP 8.1. In practical terms, this was decided by perf and SRE as the ones proposing and pushing for the objective and resourcing it as-needed. (I recognise of course that yourself and @Reedy have already been doing a lot of work in addressing deprecation warnings as part of making MediaWiki master pass CI, for releases and local dev on PHP 8.x, and thus in prep for production PHP 8.x).

We choose PHP 8.1, based on PHP 8.2 not being ready yet, and possibly too big a jump from PHP 7.4 in one go to ease vendor management. We can skip PHP 8.0 and doing so reduces the number of migrations we have to carry out. If there are benefits to individual teams and maintainers if we stop at PHP 8.0 first, though, this is certainly something we can consider. I'm not aware of a major reason against PHP 8.0 in prod. But let us know soon in that case so that we can adjust plans, or alternatively by helping resolve the issue another way.

Jdforrester-WMF added a comment.Oct 24 2022, 4:58 PM
In T319432#8338918, @Krinkle wrote:
In T319432#8315497, @Jdforrester-WMF wrote:

8.1 not 8.0 or 8.2?

The next target for production is PHP 8.1. In practical terms, this was decided by perf and SRE as the ones proposing and pushing for the objective and resourcing it as-needed. (I recognise of course that yourself and @Reedy have already been doing a lot of work in addressing deprecation warnings as part of making MediaWiki master pass CI, for releases and local dev on PHP 8.x, and thus in prep for production PHP 8.x).

We choose PH 8.1 based on PHP 8.2 not being ready yet, and possibly too big a jump from PHP 7.4 in one go to ease vendor management. We can skip PHP 8.0 and doing so reduces the number of migrations we have to carry out. If there are benefits to individual teams and maintainers if we stop at PHP 8.0 first, though, this is certainly something we can consider. I'm not aware of a major reason against PHP 8.0 in prod. But let us know soon in that case so that we can adjust plans, or alternatively by helping resolve the issue another way.

Happy the decision has been made; no particular pressure for 8.0 from me! Could the decision, who made it, and what went into it be documented somewhere (and ideally announced)? Thanks!

kostajh mentioned this in T256822: [EPIC] Upgrade MediaWiki-Vagrant to Debian Buster.Oct 26 2022, 12:31 PM
larissagaulia mentioned this in T321709: PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination.Oct 26 2022, 3:51 PM
tstarling closed subtask T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11 as Resolved.Oct 27 2022, 2:58 AM
larissagaulia added a subtask: T321709: PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination.Oct 28 2022, 11:54 AM
tstarling mentioned this in T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries).Oct 31 2022, 4:35 AM
Mainframe98 mentioned this in T319167: [EPIC] Upgrade MediaWiki-Vagrant to Debian Bullseye.Oct 31 2022, 12:07 PM
hashar awarded a token.Nov 3 2022, 1:24 PM
Jdforrester-WMF closed subtask T316078: Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries) as Resolved.Nov 10 2022, 1:10 AM
Jdforrester-WMF closed subtask T320818: Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4 as Resolved.
TK-999 subscribed.Nov 10 2022, 8:21 AM
gerritbot added a comment.Nov 10 2022, 2:45 PM

Change 855580 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] MediaWiki-Docker: Switch PHP images to PHP 8.1

https://gerrit.wikimedia.org/r/855580

gerritbot added a project: Patch-For-Review.Nov 10 2022, 2:45 PM
Umherirrender mentioned this in T323868: category sortkey generation of german letter ß changed.Nov 29 2022, 9:32 PM
Paladox subscribed.Dec 6 2022, 8:28 PM
gerritbot added a comment.Dec 7 2022, 10:00 PM

Commit 9e7b5c19... pushed by jforrester:

[ repos/releng/dev-images @php81] Add PHP 8.1 images

gerritbot added a comment.Dec 7 2022, 10:56 PM

Commit 9e7b5c19... pushed by brennen:

[ repos/releng/dev-images @main] Add PHP 8.1 images

gerritbot added a comment.Dec 7 2022, 10:56 PM

brennen merged https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/23

Add PHP 8.1 images

Stashbot added a comment.Dec 7 2022, 10:59 PM

Mentioned in SAL (#wikimedia-releng) [2022-12-07T22:59:44Z] <brennen> Updating development images on contint primary to release php 8.1 images for T319432

gerritbot added a comment.Dec 15 2022, 8:24 AM

Change 855580 merged by jenkins-bot:

[mediawiki/core@master] MediaWiki-Docker: Switch PHP images to PHP 8.1

https://gerrit.wikimedia.org/r/855580

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 15 2022, 9:00 AM
Lucas_Werkmeister_WMDE mentioned this in T325988: MonthNameUnlocalizer may unlocalize dates in an undesired way.Jan 6 2023, 5:15 PM
hashar unsubscribed.Jan 16 2023, 3:01 PM
Reedy mentioned this in T319055: Upgrade to psr/container 2.x.Jan 16 2023, 4:25 PM
Krinkle moved this task from To-do: Goals prioritized current Quarter to Doing: Goals on the Performance-Team board.Jan 19 2023, 7:18 AM
Krinkle removed projects: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Patch-For-Review.Jan 19 2023, 7:28 AM
akosiaris added a comment.Jan 19 2023, 7:54 AM

Thanks for this task.

Just to put this in writing, serviceops has planned to do the Per Cluster ramp-up in the April-Jun quarter (this quarter we are focusing on MediaWiki on Kubernetes, which should contribute to making future PHP migrations easier). The prep work (e.g. CI, some ICU work needed by SRE) can happen well before that of course.

Michael subscribed.Jan 31 2023, 3:18 PM
Michael awarded a token.Jan 31 2023, 3:32 PM
Lucas_Werkmeister_WMDE subscribed.Jan 31 2023, 3:43 PM
Daimona mentioned this in T328919: Upgrade to PHPUnit 10.Feb 6 2023, 2:16 PM
kostajh added a parent task: T328919: Upgrade to PHPUnit 10.Mar 9 2023, 10:12 AM
Jdforrester-WMF edited parent tasks, added: T328921: Drop PHP 7.4 support from MediaWiki, T328922: Drop PHP 8.0 support from MediaWiki; removed: T328919: Upgrade to PHPUnit 10.Mar 9 2023, 5:55 PM
Krinkle changed the task status from Open to Stalled.May 1 2023, 7:36 PM
Novem_Linguae subscribed.Jun 7 2023, 12:40 AM
Michael mentioned this in T227900: Phase out usage of tests/phpunit/suite.xml.Jul 14 2023, 8:52 AM
Krinkle edited projects, added MediaWiki-Platform-Team; removed Performance-Team.Aug 2 2023, 9:14 PM
Krinkle moved this task from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.Aug 17 2023, 3:50 AM
Tacsipacsi subscribed.Sep 19 2023, 8:22 AM
In T319432#8338918, @Krinkle wrote:

We choose PHP 8.1, based on PHP 8.2 not being ready yet

In the meantime, 8.2 has been out for over nine months, and it’s the version included in Debian Bookworm. Are you sure it makes sense to stick with 8.1, despite it not being included in any Debian version? It would be important to support at least one PHP version Debian includes (i.e. 7.4 or 8.2) for the benefit of third-party wikis; while it doesn’t need to be the one used in WMF production, it’s easier to support a PHP version if we ourselves use it.

gmodena subscribed.Sep 19 2023, 4:01 PM
ArielGlenn added a project: Dumps-Generation.Sep 25 2023, 1:19 PM
ArielGlenn subscribed.
matmarex subscribed.Sep 25 2023, 7:35 PM

Configure MW with ICU emulation for PHP 8.1 that matches PHP 7.4 (see also: T263437: Allow easier ICU transitions in MediaWiki (change how sortkey collation is managed in the categorylinks table), T292552: Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11).

I'm not sure where to raise this, so I'll raise it here: the category collation transition should also be done for 'uppercase' collations, not just ICU collations, as they are also affected by upgrades. For example, see T323868 and T251698 where this problem was reported.

Reedy added a comment.Sep 25 2023, 9:43 PM
In T319432#9177477, @Tacsipacsi wrote:
In T319432#8338918, @Krinkle wrote:

We choose PHP 8.1, based on PHP 8.2 not being ready yet

In the meantime, 8.2 has been out for over nine months, and it’s the version included in Debian Bookworm. Are you sure it makes sense to stick with 8.1, despite it not being included in any Debian version? It would be important to support at least one PHP version Debian includes (i.e. 7.4 or 8.2) for the benefit of third-party wikis; while it doesn’t need to be the one used in WMF production, it’s easier to support a PHP version if we ourselves use it.

https://www.mediawiki.org/wiki/Support_policy_for_PHP

Milimetric subscribed.Oct 3 2023, 9:16 PM

Hi, Data Products owns dumps now, and so I think we're responsible for the snapshot hosts mentioned in the description here. Do we have a timeline for this upgrade?

kostajh added a comment.Oct 9 2023, 8:08 AM

@Krinkle this task is marked as stalled, is it blocked on something?

Also, to bump @Tacsipacsi's question above (T319432#9177477), should we consider 8.2 for WMF production, since the decision to go with 8.1 instead of 8.2 (T319432#8338918) was made ~1 year ago?

MoritzMuehlenhoff subscribed.Oct 9 2023, 8:20 AM
In T319432#9234692, @kostajh wrote:

@Krinkle this task is marked as stalled, is it blocked on something?

The ICU migration needs to happen first: https://phabricator.wikimedia.org/T329491

Aklapper added a comment.Oct 9 2023, 8:33 AM

Please set subtasks in tasks to express dependencies. T329491 and T345561 are not connected to anything so it's not obvious what needs to happen first.

Clement_Goubert added a subtask: T329491: ICU transition towards ICU 67.Oct 9 2023, 8:39 AM
Aklapper mentioned this in T349214: Proof-of-concept: Run MediaWiki tests in latest Zuul.Oct 18 2023, 5:41 PM
Physikerwelt subscribed.Oct 23 2023, 8:45 PM
JMeybohm closed subtask T329491: ICU transition towards ICU 67 as Declined.Oct 25 2023, 1:44 PM
Krinkle added a subtask: T345561: Upgrade the MediaWiki servers to ICU 67.Nov 3 2023, 1:08 AM
Jdforrester-WMF removed a subtask: T329491: ICU transition towards ICU 67.Nov 3 2023, 3:38 PM
tstarling subscribed.Nov 4 2023, 4:55 AM
In T319432#9177477, @Tacsipacsi wrote:

In the meantime, 8.2 has been out for over nine months, and it’s the version included in Debian Bookworm. Are you sure it makes sense to stick with 8.1, despite it not being included in any Debian version? It would be important to support at least one PHP version Debian includes (i.e. 7.4 or 8.2) for the benefit of third-party wikis; while it doesn’t need to be the one used in WMF production, it’s easier to support a PHP version if we ourselves use it.

Given the amount of work that went into getting 8.1 running in CI and making everything pass, I would suggest upgrading to 8.1 within the next three months, and then starting a PHP 8.3 upgrade project immediately after that, with target completion in 2024.

We can start work on 8.3 CI whenever. I found out at php-src#11469 that Drupal are constantly running their CI against PHP master. My PR was merged on June 6 and they filed a bug about it on June 18 asking for a revert, which they immediately got. That's the kind of CI I'd like to have.

Jdforrester-WMF added a comment.Nov 6 2023, 7:28 PM
In T319432#9306384, @tstarling wrote:

We can start work on 8.3 CI whenever.

Yup, T339350 is tracking that; right now we're blocked by a lack of releases, particularly of php-ast; I believe 8.3.0's release date will be as is traditional US Thanksgiving again, so I'll have some time around then to see if we can get it out then.

Ladsgroup subscribed.Nov 6 2023, 8:47 PM
JMeybohm closed subtask T345561: Upgrade the MediaWiki servers to ICU 67 as Resolved.Nov 9 2023, 10:03 AM
Krinkle moved this task from Soon to Within 2 Qs on the MediaWiki-Platform-Team board.Nov 13 2023, 5:41 PM
Krinkle moved this task from Within 2 Qs to Blocked/waiting on the MediaWiki-Platform-Team board.Nov 16 2023, 11:25 PM
Umherirrender mentioned this in T353276: Make Phan on PHP 8.1 voting for wmf-deployed extensions/skins.Dec 12 2023, 4:01 PM
Reedy added a comment.Jan 31 2024, 3:33 PM
In T319432#9234734, @MoritzMuehlenhoff wrote:
In T319432#9234692, @kostajh wrote:

@Krinkle this task is marked as stalled, is it blocked on something?

The ICU migration needs to happen first: https://phabricator.wikimedia.org/T329491

Which was replaced by T345561: Upgrade the MediaWiki servers to ICU 67, which is resolved..

Jdforrester-WMF added a comment.Jan 31 2024, 4:30 PM

Yup, AIUI that for simplicity it's been decided that this is blocked by T290536: Serve production traffic via Kubernetes; should we mark that formally in Phab?

Reedy added a comment.Jan 31 2024, 4:36 PM

Yeah, otherwise it's unclear what/why this is stalled

Jdforrester-WMF added a subtask: T290536: Serve production traffic via Kubernetes.Jan 31 2024, 4:39 PM
Nikerabbit subscribed.Feb 13 2024, 9:49 AM
freephile subscribed.Feb 22 2024, 5:55 AM
Reedy mentioned this in T358771: Unable to login on iPhone with Passkey Enabled.Mar 5 2024, 10:33 PM
Reedy mentioned this in T328921: Drop PHP 7.4 support from MediaWiki.Mar 11 2024, 2:50 PM
Jdforrester-WMF added a parent task: T319055: Upgrade to psr/container 2.x.Mar 18 2024, 4:34 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 26 2024, 11:18 AM
Jdforrester-WMF mentioned this in T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.Mar 26 2024, 11:20 AM
Jdforrester-WMF updated the task description. (Show Details)
Lucas_Werkmeister_WMDE mentioned this in T362412: Wikibase CI jobs wikibase-repo and wikibase-client broken on REL1_42.Apr 12 2024, 2:17 PM
hashar reopened subtask T320818: Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4 as Open.Apr 17 2024, 5:58 AM
bd808 mentioned this in T364249: New upstream release for Pygments (2.18.0).May 16 2024, 9:59 PM
Krinkle added a comment.EditedMay 18 2024, 3:17 PM

(Disparate notes for ease of linking during an upcoming internal WMF presentation.)

Upstreams: PHP.net, Debian, Composer (lib dependencies)

We benefit from Debian Linux and their LTS packages for PHP, which maintain and provide security patches beyond the official PHP.net support at https://www.php.net/supported-versions. For example, while php.net ended "Active support" for PHP 7.4 in 2021, and ended Security support in 2022; We actually use Debian Linux 11 ("Bullseye") which provides LTS and security support for php7.4 until June 2027 per https://wiki.debian.org/LTS.

2023_php_EOL_wmf.png (526×1 px, 31 KB)

However, this is limited to the PHP engine itself. It does not help us with our runtime dependency on specific libraries, which we install from Packagist.org via Composer. Examples of libraries that we deploy in production to run Wikipedia on MediaWiki, include: Monolog, JWT, Symfony, PHPUnit, etc.

Libraries have much shorter support in practice. Plus, bugs in an old version rarely receive a published CVE that one could subscribe to. This just isn't a practice for most individually maintained libraries, since only the latest version at any given time is supported. Individual releases generally do not enjoy long-term support. In practice, "support" from a library translates to a patch to the latest version, and you have to upgrade to latest version to get it.

Over 30% of the 1000 most popular Composer packages require PHP 8.0 or later. This is not theoretical, this is today. From https://stitcher.io/blog/php-version-stats-july-2023:

2023_php_EOL_Composer.png (954×1 px, 18 KB)

This is already affecting MediaWiki dependencies. Below is a list of packages we have in production ("mediawiki-vendor") that have incompatible upgrades available upstream. We are unable to install these due to running an outdated PHP version.

f we look at upstream "main" branches, there are several more who discontinued PHP 7.4 in their main branch, but have not released it yet. This means any upcoming of security fix, bug fix, or other improvement will be part of a release we can't install.

Misc links

  • Example of six months period from June 2023 to Feb 2024, where our own performance tooling did not work in our official MediaWiki-Docker dev environment. This because we moved from PHP 7.4 to PHP 8.1, and thus by extent away from WMF packaging to a third-party (deb.sury.org) which happened to lack some of the required packages. https://github.com/oerdnj/deb.sury.org/issues/1952
TheDJ added a parent task: T364249: New upstream release for Pygments (2.18.0).May 20 2024, 1:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL