Page MenuHomePhabricator
Create Task
Maniphest T311451

Re-enable PHP 8.1 CI on css-sanitizer
Closed, ResolvedPublic
Actions

Description

As per T307506: Address PHP 8.1 job failures on various PHP libs, we're waiting on a new release of the taint check plugin with a fix...

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Zuul: [css-sanitizer] Re-enable PHP 8.1 jobintegration/configmaster+2 -13
Zuul: [css-sanitizer] Re-disable PHP 8.1 job, still brokenintegration/configmaster+13 -2
Zuul: [css-sanitizer] Re-enable PHP 8.1 jobsintegration/configmaster+0 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
ResolvedDaimonaT311452 Taint Check Plugin release
· · ·

Event Timeline

Reedy created this task.Jun 27 2022, 7:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2022, 7:35 PM
Reedy renamed this task from Re-enable PHP 8.1 CI on css-sanitizr to Re-enable PHP 8.1 CI on css-sanitizer.Jun 27 2022, 7:36 PM
Reedy changed the task status from Open to Stalled.
Reedy updated the task description. (Show Details)
Reedy added a subtask: T311452: Taint Check Plugin release.Jun 27 2022, 7:38 PM
Reedy updated the task description. (Show Details)
Reedy added a project: css-sanitizer.Jul 10 2022, 1:11 AM
Daimona closed subtask T311452: Taint Check Plugin release as Resolved.Oct 6 2022, 12:18 PM
Jdforrester-WMF changed the task status from Stalled to Open.Oct 13 2022, 7:58 PM
gerritbot added a comment.Oct 13 2022, 8:43 PM

Change 842535 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [css-sanitizer] Re-enable PHP 8.1 jobs

https://gerrit.wikimedia.org/r/842535

gerritbot added a project: Patch-For-Review.Oct 13 2022, 8:43 PM
Jdforrester-WMF subscribed.Oct 13 2022, 8:43 PM

Should have been fixed in rCSSS3f43dc74e7cb: build: Updating mediawiki/mediawiki-phan-config to 0.12.0.

gerritbot added a comment.Oct 14 2022, 1:47 PM

Change 842535 merged by jenkins-bot:

[integration/config@master] Zuul: [css-sanitizer] Re-enable PHP 8.1 jobs

https://gerrit.wikimedia.org/r/842535

Stashbot added a comment.Oct 14 2022, 1:48 PM

Mentioned in SAL (#wikimedia-releng) [2022-10-14T13:48:09Z] <James_F> Zuul: [css-sanitizer] Re-enable PHP 8.1 jobs for T311451

Jdforrester-WMF added a project: PHP 8.1 support.Oct 14 2022, 1:49 PM
Jdforrester-WMF moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.
Jdforrester-WMF added a parent task: T319065: All Wikimedia production extensions and skins must support PHP 8.1.Oct 14 2022, 1:51 PM
Jdforrester-WMF closed this task as Resolved.Oct 14 2022, 2:14 PM
Jdforrester-WMF claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Oct 14 2022, 2:30 PM
Umherirrender reopened this task as Open.Nov 16 2022, 8:37 PM
Umherirrender subscribed.

It seems that is not fixed, because on https://gerrit.wikimedia.org/r/c/css-sanitizer/+/857096 the php8.1 fails with the old known error - https://integration.wikimedia.org/ci/job/composer-package-php81-docker/1449/console

gerritbot added a comment.Dec 1 2022, 2:15 PM

Change 862926 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [css-sanitizer] Re-disable PHP 8.1 job, still broken

https://gerrit.wikimedia.org/r/862926

gerritbot added a project: Patch-For-Review.Dec 1 2022, 2:15 PM
gerritbot added a comment.Dec 1 2022, 2:19 PM

Change 862926 merged by jenkins-bot:

[integration/config@master] Zuul: [css-sanitizer] Re-disable PHP 8.1 job, still broken

https://gerrit.wikimedia.org/r/862926

Stashbot added a comment.Dec 1 2022, 2:20 PM

Mentioned in SAL (#wikimedia-releng) [2022-12-01T14:20:56Z] <James_F> Zuul: [css-sanitizer] Re-disable PHP 8.1 job, still broken T311451

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Dec 1 2022, 2:21 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Reedy changed the task status from Open to Stalled.Jan 8 2023, 11:37 PM
Umherirrender unsubscribed.Jul 12 2023, 8:35 PM
Daimona changed the task status from Stalled to Open.Oct 14 2023, 12:41 PM
Daimona claimed this task.
gerritbot added a comment.Oct 14 2023, 12:42 PM

Change 965703 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] Zuul: [css-sanitizer] Re-enable PHP 8.1 job

https://gerrit.wikimedia.org/r/965703

gerritbot added a project: Patch-For-Review.Oct 14 2023, 12:42 PM
gerritbot added a comment.Oct 14 2023, 3:16 PM

Change 965703 merged by jenkins-bot:

[integration/config@master] Zuul: [css-sanitizer] Re-enable PHP 8.1 job

https://gerrit.wikimedia.org/r/965703

Stashbot added a comment.Oct 14 2023, 3:17 PM

Mentioned in SAL (#wikimedia-releng) [2023-10-14T15:17:02Z] <hashar> Reloaded Zuul for https://gerrit.wikimedia.org/r/965703 # T311451

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2023, 3:30 PM
Jdforrester-WMF closed this task as Resolved.Oct 18 2023, 6:05 PM
Jdforrester-WMF removed a subtask: T324207: Phan crashes on css-sanitizer on PHP 8.1.
Izno moved this task from Unsorted to Done on the css-sanitizer board.Apr 2 2024, 6:59 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits