| Lucas_Werkmeister_WMDE | |
| Apr 14 2023, 12:12 PM |
build: Enable PhanPluginNeverReturnMethod and make pass added several @return never types to Wikibase code. Once we can require PHP 8.1 and have access to a language-level never return type, we should convert those return types; at that point, we can also remove this kind of code:
// @phan-suppress-next-line PhanPluginUnreachableCode Wanted to guarantee return never at the language level throw new LogicException( 'ApiUsageException not thrown' );
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ApiErrorReporter: Use `never` return type | mediawiki/extensions/Wikibase | master | +5 -76 |
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Stalled | None | T334726 Use return type `never` in Wikibase | ||
| Open | None | T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10 | ||
| Resolved | Jdforrester-WMF | T328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki | ||
| · · · |
Change #1169695 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] ApiErrorReporter: Use `never` return type
Hm, this might be blocked further on T328919: Upgrade PHPUnit in MediaWiki code to PHPUnit 10:
PHP Fatal error: Cannot use 'never' as class name as it is reserved in /workspace/src/vendor/phpunit/phpunit/src/Framework/MockObject/MockClass.php(51) : eval()'d code on line 3
The fix for this issue – i.e. mocking classes with never-returning methods – was only included in PHPUnit 10.4.2, apparently.