Page MenuHomePhabricator

Use return type `never` in Wikibase
Open, Stalled, Needs TriagePublic

Description

build: Enable PhanPluginNeverReturnMethod and make pass added several @return never types to Wikibase code. Once we can require PHP 8.1 and have access to a language-level never return type, we should convert those return types; at that point, we can also remove this kind of code:

// @phan-suppress-next-line PhanPluginUnreachableCode Wanted to guarantee return never at the language level
throw new LogicException( 'ApiUsageException not thrown' );

Related Objects

StatusSubtypeAssignedTask
StalledNone
OpenNone
StalledKrinkle
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
Resolvedtstarling
ResolvedReedy
ResolvedBUG REPORTtstarling
Resolvedtstarling
ResolvedDaimona
ResolvedDaimona
ResolvedNone
ResolvedJdforrester-WMF
ResolvedBUG REPORTNone
Resolvedtstarling
ResolvedJdforrester-WMF
Resolved ssastry
Resolvedkostajh
Resolvedkostajh
Resolvedthiemowmde
Resolvedtstarling
Resolvedtstarling
ResolvedBUG REPORTLucas_Werkmeister_WMDE
Resolvedhoo
Resolvedhoo
ResolvedJdforrester-WMF
Resolvedthiemowmde
Resolvedkostajh
ResolvedUmherirrender
ResolvedPRODUCTION ERROR brooke
ResolvedTheresNoTime
Resolvedtstarling
OpenJdforrester-WMF
Resolvedlarissagaulia
ResolvedJMeybohm
Resolved MoritzMuehlenhoff
Opendduvall
ResolvedJdforrester-WMF
OpenNone