Page MenuHomePhabricator
Create Task
Maniphest T321600

GrowthExperiments PHP 8.1 support
Closed, ResolvedPublic
Actions

Description

PHP Fatal error:  During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.133 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.133 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.133  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12
00:01:21.133 
00:01:21.133 Fatal error: During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.134 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.134 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.134  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[general] PHP 8.1 compatibilitymediawiki/extensions/GrowthExperimentsREL1_39+6 -6
[general] PHP 8.1 compatibilitymediawiki/extensions/GrowthExperimentsmaster+11 -10
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
ResolvedNoneT320744 [Epic] Q2 FY 2022-23 Growth Maintenance Work
ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
· · ·

Event Timeline

Jdforrester-WMF created this task.Oct 25 2022, 5:52 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 25 2022, 5:52 PM
kostajh claimed this task.Oct 26 2022, 11:03 AM
kostajh subscribed.

Seems like mostly instances of T311919: JsonSerializable function return types

kostajh triaged this task as Medium priority.Oct 26 2022, 11:03 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a parent task: T320744: [Epic] Q2 FY 2022-23 Growth Maintenance Work.
gerritbot added a comment.Oct 26 2022, 11:10 AM

Change 849529 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/849529

gerritbot added a project: Patch-For-Review.Oct 26 2022, 11:10 AM
kostajh changed the task status from Open to In Progress.Oct 26 2022, 12:20 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Oct 26 2022, 1:08 PM

Change 849529 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/849529

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2022, 1:31 PM
Jdforrester-WMF closed this task as Resolved.Oct 26 2022, 1:34 PM

Thank you!

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 26 2022, 2:00 PM
gerritbot added a comment.May 20 2025, 8:53 PM

Change #1148451 had a related patch set uploaded (by Reedy; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@REL1_39] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/1148451

gerritbot added a project: Patch-For-Review.May 20 2025, 8:53 PM
gerritbot added a comment.May 20 2025, 9:31 PM

Change #1148451 merged by Reedy:

[mediawiki/extensions/GrowthExperiments@REL1_39] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/1148451

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits