Page MenuHomePhabricator

GrowthExperiments PHP 8.1 support
Closed, ResolvedPublic

Description

PHP Fatal error:  During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.133 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.133 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.133  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12
00:01:21.133 
00:01:21.133 Fatal error: During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.134 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.134 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.134  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12

Event Timeline

Change 849529 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/849529

kostajh changed the task status from Open to In Progress.Oct 26 2022, 12:20 PM

Change 849529 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [general] PHP 8.1 compatibility

https://gerrit.wikimedia.org/r/849529