GrowthExperiments PHP 8.1 support
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Oct 25 2022, 5:52 PM

Description

PHP Fatal error:  During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.133 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.133 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.133  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12
00:01:21.133 
00:01:21.133 Fatal error: During inheritance of JsonSerializable: Uncaught Return type of GrowthExperiments\NewcomerTasks\AddImage\ImageRecommendationImage::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
00:01:21.133 
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:115
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php:12
00:01:21.133 /workspace/src/includes/AutoLoader.php:245
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:242
00:01:21.133 /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationMetadataProvider.php:306
00:01:21.134 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/NewcomerTasks/AddImage/ImageRecommendationMetadataProviderTest.php:35
00:01:21.134 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:116
00:01:21.134  in /workspace/src/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ImageRecommendationImage.php on line 12

Details

	Subject	Repo	Branch	Lines +/-
	[general] PHP 8.1 compatibility	mediawiki/extensions/GrowthExperiments	master	+11 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
Open	None	T379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Open	None	T378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Open	None	T358666 Drop PHP 8.1 support from MediaWiki
Open	None	T380185 Prepare for newer geoip2/geoip2 library
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled	None	T334726 Use return type `never` in Wikibase
Stalled	None	T373753 Drop symfony/polyfill-php80 and symfony/polyfill-php81 from mediawiki-vendor
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Resolved	Jdforrester-WMF	T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
Resolved	Jdforrester-WMF	T319065 All Wikimedia production extensions and skins must support PHP 8.1
Resolved	None	T311850 [Epic] FY 2022-23 Growth Maintenance Work
Resolved	None	T320744 [Epic] Q2 FY 2022-23 Growth Maintenance Work
Resolved	kostajh	T321600 GrowthExperiments PHP 8.1 support