Page MenuHomePhabricator

Upgrade to psr/container 2.x
Open, Stalled, Needs TriagePublic

Event Timeline

There's a handful of usages (mostly extensions) that would need updating for the change in type hint, and/or #[ReturnTypeWillChange]...

Reedy changed the task status from Open to Stalled.Sep 30 2022, 5:09 PM

symfony/service-contracts might be a problem here.. We can't upgrade (without hacking around) due to code that from memory is only PHP8+ compatible; so fails our linting...

Change 837156 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

But we can do some prep work to allow the version, especially in libraries where they're not actually implementing ContainerInterface (like ObjectFactory)...

Change 837158 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 837156 merged by jenkins-bot:

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

Change 837158 merged by jenkins-bot:

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 841143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

Change 841143 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

TLDR here, this is basically all blocked till we get upgraded to PHP 8.0 in production.

Which probably means is both blocked by, and also blocks T319065: All Wikimedia production extensions and skins must support PHP 8.1 and T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.

Linked for cross referencing at least...