Page MenuHomePhabricator

Upgrade to psr/container 2.x
Open, Stalled, Needs TriagePublic

Related Objects

StatusSubtypeAssignedTask
StalledNone
OpenNone
StalledNone
StalledNone
StalledKrinkle
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
Resolvedtstarling
ResolvedReedy
ResolvedBUG REPORTtstarling
Resolvedtstarling
ResolvedDaimona
ResolvedDaimona
ResolvedNone
ResolvedJdforrester-WMF
ResolvedBUG REPORTNone
Resolvedtstarling
ResolvedJdforrester-WMF
Resolved ssastry
Resolvedkostajh
Resolvedkostajh
Resolvedthiemowmde
Resolvedtstarling
Resolvedtstarling
ResolvedBUG REPORTLucas_Werkmeister_WMDE
Resolvedhoo
Resolvedhoo
ResolvedJdforrester-WMF
Resolvedthiemowmde
Resolvedkostajh
ResolvedUmherirrender
ResolvedPRODUCTION ERROR brooke
ResolvedTheresNoTime
Resolvedtstarling
OpenJdforrester-WMF
Resolvedlarissagaulia
ResolvedJMeybohm
ResolvedMoritzMuehlenhoff
OpenNone
Resolvedjijiki
Resolvedaaron
Openjijiki
In ProgressClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
StalledClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedJoe
Resolvedcolewhite
ResolvedClement_Goubert
ResolvedClement_Goubert
In ProgressClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
InvalidClement_Goubert
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedJoe
ResolvedJoe
ResolvedJoe
ResolvedJMeybohm
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
DeclinedClement_Goubert
ResolvedClement_Goubert
Resolvedelukey
StalledKrinkle
Resolvedjijiki
ResolvedJoe
ResolvedJoe
ResolvedClement_Goubert
ResolvedBUG REPORTClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedJoe
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedJclark-ctr
ResolvedJMeybohm
ResolvedJoe
ResolvedJoe
ResolvedNone
Resolvedjijiki
Resolvedjijiki
Resolveddancy
Resolveddancy
ResolvedJoe
ResolvedJoe
Resolvedjeena
ResolvedJoe
ResolvedJoe
Resolveddancy
ResolvedJoe
Resolved dpifke
Resolveddancy
ResolvedJoe
ResolvedClement_Goubert
Resolvedcolewhite
Resolvedjijiki
Resolved dpifke
ResolvedLegoktm
ResolvedClement_Goubert
ResolvedJMeybohm
ResolvedClement_Goubert
ResolvedClement_Goubert
OpenNone
OpenClement_Goubert
In ProgressClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
Resolvedhnowlan
Resolvedakosiaris
Openhnowlan
ResolvedClement_Goubert
ResolvedNone
ResolvedDreamy_Jazz
ResolvedPRODUCTION ERRORDreamy_Jazz
Resolvedkostajh
Resolvedjijiki
OpenNone
Resolvedkamila
ResolvedJhancock.wm
ResolvedJclark-ctr
OpenNone
ResolvedClement_Goubert
ResolvedClement_Goubert
Resolvedakosiaris
OpenNone
Resolvedakosiaris
Resolveddancy
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
ResolvedClement_Goubert
OpenClement_Goubert
ResolvedCDanis
Openjijiki
ResolvedJoe
In Progressjijiki
Resolvedjijiki
OpenNone
ResolvedJdforrester-WMF
Resolvedjijiki
OpenClement_Goubert
OpenClement_Goubert

Event Timeline

There's a handful of usages (mostly extensions) that would need updating for the change in type hint, and/or #[ReturnTypeWillChange]...

Reedy changed the task status from Open to Stalled.Sep 30 2022, 5:09 PM

symfony/service-contracts might be a problem here.. We can't upgrade (without hacking around) due to code that from memory is only PHP8+ compatible; so fails our linting...

Change 837156 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

But we can do some prep work to allow the version, especially in libraries where they're not actually implementing ContainerInterface (like ObjectFactory)...

Change 837158 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 837156 merged by jenkins-bot:

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

Change 837158 merged by jenkins-bot:

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 841143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

Change 841143 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

TLDR here, this is basically all blocked till we get upgraded to PHP 8.0 in production.

Which probably means is both blocked by, and also blocks T319065: All Wikimedia production extensions and skins must support PHP 8.1 and T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.

Linked for cross referencing at least...