Page MenuHomePhabricator

Upgrade to psr/container 2.x
Closed, ResolvedPublic

Related Objects

StatusSubtypeAssignedTask
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
ResolvedNone
ResolvedJdforrester-WMF
ResolvedKrinkle
Resolvedtstarling
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
Resolvedtstarling
ResolvedReedy
ResolvedBUG REPORTtstarling
Resolvedtstarling
ResolvedDaimona
ResolvedDaimona
ResolvedNone
ResolvedJdforrester-WMF
ResolvedBUG REPORTNone
Resolvedtstarling
ResolvedJdforrester-WMF
Resolvedssastry
Resolvedkostajh
Resolvedkostajh
Resolvedthiemowmde
Resolvedtstarling
Resolvedtstarling
ResolvedBUG REPORTLucas_Werkmeister_WMDE
Resolvedhoo
Resolvedhoo
ResolvedJdforrester-WMF
Resolvedthiemowmde
Resolvedkostajh
ResolvedUmherirrender
ResolvedPRODUCTION ERROR brooke
ResolvedTheresNoTime
Resolvedtstarling
ResolvedJdforrester-WMF
Resolved larissagaulia
ResolvedJMeybohm
ResolvedMoritzMuehlenhoff
ResolvedNone
DuplicateNone
ResolvedNone
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORNone
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERRORNone
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERRORNone
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORhashar
ResolvedPRODUCTION ERRORUmherirrender
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORthiemowmde
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORTacsipacsi
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORdcausse
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERROR mszabo
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORUmherirrender
ResolvedPRODUCTION ERRORUmherirrender
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORjijiki
ResolvedScott_French
ResolvedPRODUCTION ERRORABreault-WMF
ResolvedPRODUCTION ERRORdaniel
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORihurbain
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORJdforrester-WMF
DuplicatePRODUCTION ERRORNone
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORUmherirrender
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
DuplicatePRODUCTION ERRORNone
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORPaladox
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedBUG REPORTWargo
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedBUG REPORTScott_French
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORssastry
ResolvedPRODUCTION ERRORReedy
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORUmherirrender
ResolvedPRODUCTION ERRORJdforrester-WMF
ResolvedPRODUCTION ERRORUmherirrender
ResolvedLadsgroup
ResolvedPRODUCTION ERRORUmherirrender
ResolvedFeaturebd808
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedKrinkle
ResolvedMSantos
ResolvedTgr
ResolvedScott_French
ResolvedScott_French
Resolveddduvall
ResolvedClement_Goubert
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
Resolvedori
ResolvedClement_Goubert
ResolvedScott_French
In ProgressScott_French
ResolvedScott_French
OpenNone
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedScott_French
ResolvedJdforrester-WMF

Event Timeline

There's a handful of usages (mostly extensions) that would need updating for the change in type hint, and/or #[ReturnTypeWillChange]...

Reedy changed the task status from Open to Stalled.Sep 30 2022, 5:09 PM

symfony/service-contracts might be a problem here.. We can't upgrade (without hacking around) due to code that from memory is only PHP8+ compatible; so fails our linting...

Change 837156 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

But we can do some prep work to allow the version, especially in libraries where they're not actually implementing ContainerInterface (like ObjectFactory)...

Change 837158 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 837156 merged by jenkins-bot:

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

Change 837158 merged by jenkins-bot:

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Change 841143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

Change 841143 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

TLDR here, this is basically all blocked till we get upgraded to PHP 8.0 in production.

Which probably means is both blocked by, and also blocks T319065: All Wikimedia production extensions and skins must support PHP 8.1 and T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.

Linked for cross referencing at least...

Change #1154312 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Upgrade psr/container from 1.1.2 to 2.0.2, and symfony/service-contracts from 2.4.1 to 3.6.0

https://gerrit.wikimedia.org/r/1154312

Change #1154313 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade psr/container from 1.1.2 to 2.0.2

https://gerrit.wikimedia.org/r/1154313

Change #1154316 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Shellbox@master] [BREAKING CHANGE] Drop PHP 7.4 support, re-build composer.lock based on this

https://gerrit.wikimedia.org/r/1154316

Jdforrester-WMF changed the task status from Stalled to In Progress.Jun 6 2025, 4:00 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF changed the status of subtask T327093: Allow psr/container 2.x in Shellbox from Stalled to In Progress.

Change #1154312 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrade psr/container from 1.1.2 to 2.0.2, and symfony/service-contracts from 2.4.1 to 3.6.0

https://gerrit.wikimedia.org/r/1154312

Change #1154313 merged by jenkins-bot:

[mediawiki/core@master] Upgrade psr/container from 1.1.2 to 2.0.2

https://gerrit.wikimedia.org/r/1154313