Page MenuHomePhabricator
Create Task
Maniphest T319055

Upgrade to psr/container 2.x
Open, Stalled, Needs TriagePublic
Actions

Description

https://github.com/php-fig/container/releases/tag/2.0.0

Details

SubjectRepoBranchLines +/-
composer.json: Allow psr/container 2mediawiki/libs/ObjectFactorymaster+1 -1
Bump parsoid to 0.17.0-a3mediawiki/vendormaster+800 -593
composer.json: Allow psr/container 2mediawiki/services/parsoidmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT319055 Upgrade to psr/container 2.x
 OpenNoneT327092 Allow psr/container 2.x in StructuredDiscussions
 StalledNoneT327093 Allow psr/container 2.x in Shellbox
 StalledNoneT327094 Allow psr/container 2.x in Metrics Platform
 StalledKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 Resolved• tstarlingT292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 Resolved• tstarlingT314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedReedyT311448 Echo PHP 8.1 support
 ResolvedBUG REPORT• tstarlingT289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
 Resolved• tstarlingT320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
 ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
 ResolvedDaimonaT311452 Taint Check Plugin release
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 Resolved• tstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
 ResolvedJdforrester-WMFT311463 Re-enable PHP 8.1 CI on Zest
 ResolvedssastryT307632 mediawiki/libs/Zest phan issues under 8.1
 ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
 ResolvedkostajhT321691 StructuredDiscussions support for PHP 8.1
 ResolvedthiemowmdeT321692 FileImporter support for PHP 8.1
 Resolved• tstarlingT322098 GeoData support for PHP 8.1
 Resolved• tstarlingT322099 TwoColConflict support for PHP 8.1
 ResolvedBUG REPORTLucas_Werkmeister_WMDET319219 Wikibase gives deprecated warnings on php 8.1
 ResolvedhooT301249 Handle deprecation of Serializable interface in Wikibase
 ResolvedhooT305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
 ResolvedJdforrester-WMFT322233 PageViewInfo support for PHP 8.1
 ResolvedthiemowmdeT322408 CirrusSearch support for PHP 8.1
 ResolvedkostajhT322838 PageTriage PHP 8.1 support
 ResolvedUmherirrenderT323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
 ResolvedPRODUCTION ERROR• brookeT289189 getid3: PHP Warning: Division by zero
 ResolvedTheresNoTimeT332356 function strftime() is deprecated in php8.1 used by Calendar extension
 Resolved• tstarlingT322278 MediaWiki core should pass Phan on PHP 8.1
 OpenJdforrester-WMFT320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4
 ResolvedlarissagauliaT321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
 ResolvedJMeybohmT345561 Upgrade the MediaWiki servers to ICU 67
 ResolvedMoritzMuehlenhoffT350767 Rebuild PHP 7.4 packages for Bullseye
 OpenNoneT373752 Build php-uuid package, and add to WMF production and CI
 DuplicateNoneT378043 Route requests with PHP_ENGINE=8.1 cookie to "next" deployment via ATS plugin
 OpenScott_FrenchT377042 Support cookie-driven fractional migration to PHP 8.1 deployments of mw-web and mw-api-ext
 OpenScott_FrenchT377040 Turn up PHP 8.1-flavored k8s deployments for all MediaWiki services
 ResolvedKrinkleT377987 Prepare sticky cookie for gradual PHP 8.1 rollout
 ResolvedScott_FrenchT372603 Regenerate UcfirstOverrides.php for PHP 7.4 -> 8.1 transition
 OpenNoneT379874 PHP 8.1 issues found during WMF rollout/ramp up
 ResolvedPRODUCTION ERRORReedyT379834 PHP Deprecated: Automatic conversion of false to array is deprecated
 OpenNoneT343229 Scribunto's use of dynamic Parser::$scribunto_engine should be rewritten/removed
 ResolvedReedyT324891 Deprecated: Creation of dynamic property Parser::$scribunto_engine is deprecated
 OpenNoneT343226 TemplateStyles's use of dynamic Parser::$extTemplateStylesCache should be rewritten/removed
 ResolvedReedyT324890 Deprecated: Creation of dynamic property Parser::$extTemplateStylesCache is deprecated in Hooks.php on line 208
 OpenPRODUCTION ERRORNoneT357593 FundraisingEmailUnsubscribe doesn't pass tests in PHP 8.1
 ResolvedScott_FrenchT372604 Turn up PHP 8.1-flavored mw-debug k8s deployment
 ResolveddduvallT370934 Build and publish multiple MediaWiki production images for a given set of PHP versions
 ResolvedClement_GoubertT376895 mw-debug-repl fails with `container mediawiki-pinkunicorn-app is not valid for pod mw-debug.codfw.next-5d785576b4-sq6dv`
 ResolvedScott_FrenchT372605 Extend x-wikimedia-debug-routing.lua to support PHP 8.1 mw-debug deployment
 OpenMSantosT379986 Testing and verification of MediaWiki on PHP 8.1 in mwdebug-next
 OpenNoneT380485 Transition parsoidtest1001 to PHP 8.1
 OpenFeature• bd808T378752 Install PHP 8.1 on deployment-prep bullseye MediaWiki instances

Event Timeline

Reedy created this task.Sep 30 2022, 4:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2022, 4:54 PM
Reedy updated the task description. (Show Details)Sep 30 2022, 5:00 PM
Reedy added a comment.Sep 30 2022, 5:04 PM

There's a handful of usages (mostly extensions) that would need updating for the change in type hint, and/or #[ReturnTypeWillChange]...

Reedy changed the task status from Open to Stalled.Sep 30 2022, 5:09 PM

symfony/service-contracts might be a problem here.. We can't upgrade (without hacking around) due to code that from memory is only PHP8+ compatible; so fails our linting...

gerritbot added a comment.Sep 30 2022, 5:12 PM

Change 837156 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

gerritbot added a project: Patch-For-Review.Sep 30 2022, 5:12 PM
Reedy added projects: ObjectFactory, Parsoid.Sep 30 2022, 5:14 PM

But we can do some prep work to allow the version, especially in libraries where they're not actually implementing ContainerInterface (like ObjectFactory)...

gerritbot added a comment.Sep 30 2022, 5:19 PM

Change 837158 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

gerritbot added a comment.Oct 1 2022, 4:15 AM

Change 837156 merged by jenkins-bot:

[mediawiki/libs/ObjectFactory@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837156

gerritbot added a comment.Oct 1 2022, 4:22 AM

Change 837158 merged by jenkins-bot:

[mediawiki/services/parsoid@master] composer.json: Allow psr/container 2

https://gerrit.wikimedia.org/r/837158

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2022, 4:30 AM
ssastry edited projects, added Parsoid (Tracking); removed Parsoid.Oct 5 2022, 4:07 AM
gerritbot added a comment.Oct 10 2022, 2:44 PM

Change 841143 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

gerritbot added a project: Patch-For-Review.Oct 10 2022, 2:44 PM
gerritbot added a comment.Oct 10 2022, 3:09 PM

Change 841143 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a3

https://gerrit.wikimedia.org/r/841143

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2022, 3:30 PM
Reedy changed the status of subtask T327093: Allow psr/container 2.x in Shellbox from Open to Stalled.Jan 16 2023, 4:10 PM
Reedy changed the status of subtask T327094: Allow psr/container 2.x in Metrics Platform from Open to Stalled.Jan 16 2023, 4:14 PM
Reedy changed the status of subtask T327092: Allow psr/container 2.x in StructuredDiscussions from Open to Stalled.Jan 16 2023, 4:21 PM
Reedy added a comment.Jan 16 2023, 4:25 PM

TLDR here, this is basically all blocked till we get upgraded to PHP 8.0 in production.

Which probably means is both blocked by, and also blocks T319065: All Wikimedia production extensions and skins must support PHP 8.1 and T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.

Linked for cross referencing at least...

Jdforrester-WMF added a subtask: T319432: Migrate WMF production from PHP 7.4 to PHP 8.1.Mar 18 2024, 4:34 PM
Reedy changed the status of subtask T327092: Allow psr/container 2.x in StructuredDiscussions from Stalled to Open.Mar 18 2024, 4:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits