https://gerrit.wikimedia.org/r/c/mediawiki/libs/Zest/+/734381
https://integration.wikimedia.org/ci/job/composer-package-php81-docker/99/console
23:27:26 src/ZestInst.php:305 PhanCoalescingNeverNullInLoop Using non-null $el->getAttribute('id') of type string as the left hand side of a null coalescing (??) operation. The right hand side may be unnecessary. (in a loop body - this is likely a false positive)(Not sure how to tag Zest)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Open | None | T328919 Upgrade to PHPUnit 10 | |||
| Open | None | T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+ | |||
| Open | None | T328921 Drop PHP 7.4 support from MediaWiki | |||
| Stalled | None | T334726 Use return type `never` in Wikibase | |||
| Open | None | T328922 Drop PHP 8.0 support from MediaWiki | |||
| Stalled | None | T319055 Upgrade to psr/container 2.x | |||
| Stalled | Feature | None | T364249 New upstream release for Pygments (2.18.0) | ||
| Stalled | Krinkle | T319432 Migrate WMF production from PHP 7.4 to PHP 8.1 | |||
| Resolved | Jdforrester-WMF | T316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries) | |||
| Resolved | Jdforrester-WMF | T319065 All Wikimedia production extensions and skins must support PHP 8.1 | |||
| Resolved | None | T307506 Address PHP 8.1 job failures on various PHP libs | |||
| Resolved | Jdforrester-WMF | T311463 Re-enable PHP 8.1 CI on Zest | |||
| Resolved | • ssastry | T307632 mediawiki/libs/Zest phan issues under 8.1 |
Change 790413 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/libs/Zest@master] Suppress PhanCoalescingNeverNullInLoop
Change 790413 abandoned by Arlolra:
[mediawiki/libs/Zest@master] Suppress PhanCoalescingNeverNullInLoop
Reason:
Meh
This seems intractable; disabling PhanCoalescingNeverNullInLoop on that line makes phan pass on 8.1 but fail on 7.4/8.0 with an UnusedPluginSuppression; suppressing UnusedPluginSuppression makes it then fail on 8.1.
How about if you set $elid = $el->getAttribute( 'id' ); and set a '@phan-var $elid ?string` phan type hint above?
Change 842826 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):
[mediawiki/libs/Zest@master] WIP: Work around Phan issues in 8.1 and 7.4
Change 842826 merged by jenkins-bot:
[mediawiki/libs/Zest@master] Work around Phan issues in 8.1 and 7.4