Zest phan issues under 8.1
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 4 2022, 9:39 PM

Project Tags

Referenced Files

None

Subscribers

Description

https://gerrit.wikimedia.org/r/c/mediawiki/libs/Zest/+/734381
https://integration.wikimedia.org/ci/job/composer-package-php81-docker/99/console

23:27:26 src/ZestInst.php:305 PhanCoalescingNeverNullInLoop Using non-null $el->getAttribute('id') of type string as the left hand side of a null coalescing (??) operation. The right hand side may be unnecessary. (in a loop body - this is likely a false positive)

(Not sure how to tag Zest)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Work around Phan issues in 8.1 and 7.4	Subramanya Sastry	mediawiki/libs/Zest	master	+11 -3
	Suppress PhanCoalescingNeverNullInLoop	Arlolra	mediawiki/libs/Zest	master	+3 -2

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Jdforrester-WMF	T311463 Re-enable PHP 8.1 CI on Zest
Resolved	ssastry	T307632 mediawiki/libs/Zest phan issues under 8.1
		· · ·

Event Timeline

Umherirrender created this task.May 4 2022, 9:39 PM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 4 2022, 9:39 PM

Umherirrender mentioned this in T307506: Address PHP 8.1 job failures on various PHP libs.May 4 2022, 9:40 PM

Change 790413 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/libs/Zest@master] Suppress PhanCoalescingNeverNullInLoop

https://gerrit.wikimedia.org/r/790413

gerritbot added a project: Patch-For-Review.May 9 2022, 6:26 PM

Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.May 9 2022, 6:26 PM

Change 790413 abandoned by Arlolra:

[mediawiki/libs/Zest@master] Suppress PhanCoalescingNeverNullInLoop

Reason:

Meh

https://gerrit.wikimedia.org/r/790413

Maintenance_bot removed a project: Patch-For-Review.May 9 2022, 7:30 PM

Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.May 21 2022, 8:22 AM

Umherirrender unsubscribed.Jun 19 2022, 7:31 PM

Reedy added a parent task: T311463: Re-enable PHP 8.1 CI on Zest.Jun 27 2022, 9:11 PM

Reedy moved this task from Wikimedia production to Other on the PHP 8.1 support board.Jun 30 2022, 12:31 AM

This seems intractable; disabling PhanCoalescingNeverNullInLoop on that line makes phan pass on 8.1 but fail on 7.4/8.0 with an UnusedPluginSuppression; suppressing UnusedPluginSuppression makes it then fail on 8.1.

Jdforrester-WMF moved this task from Other to Wikimedia production on the PHP 8.1 support board.Oct 14 2022, 2:14 PM

How about if you set $elid = $el->getAttribute( 'id' ); and set a '@phan-var $elid ?string` phan type hint above?

Change 842826 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/libs/Zest@master] WIP: Work around Phan issues in 8.1 and 7.4

https://gerrit.wikimedia.org/r/842826

gerritbot added a project: Patch-For-Review.Oct 14 2022, 2:36 PM

In T307632#8317148, @ssastry wrote:

How about if you set $elid = $el->getAttribute( 'id' ); and set a '@phan-var $elid ?string` phan type hint above?

Very neat. :-)

Change 842826 merged by jenkins-bot:

[mediawiki/libs/Zest@master] Work around Phan issues in 8.1 and 7.4

https://gerrit.wikimedia.org/r/842826

Jdforrester-WMF closed this task as Resolved.Oct 14 2022, 4:02 PM

Jdforrester-WMF assigned this task to SubrahamanyamVarma.

Jdforrester-WMF reassigned this task from SubrahamanyamVarma to ssastry.

Jdforrester-WMF added a subscriber: SubrahamanyamVarma.

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2022, 4:31 PM