A lot of `[info] Wikitext for this page has duplicate ids:` in logstash for mw-parsoid. Possibly related to PageBundle
Open, HighPublic
Actions

Assigned To

None

Authored By

	akosiaris
	Feb 27 2024, 2:24 PM

Description

Since the first batch of RESTBase hosts (1 host per DC, roughly 4% for eqiad and 6% for codfw) were switched to mw-parsoid from parsoid-php, that is at ~2024-02-2024T13:52Z (T357392#9580018) we are seeing in Logstash a number of Information messages that appear somewhat worrying.

[info] Wikitext for this page has duplicate ids: Summary
[info] Wikitext for this page has duplicate ids: fileinfotpl_creator_image
[info] Wikitext for this page has duplicate ids: creator
[info] Wikitext for this page has duplicate ids: fileinfotpl_desc
[info] Wikitext for this page has duplicate ids: rationale_repl

No trace available.

Impact

Probably minimal since the messages are logged at info level. However, the only result in codesearch that returns something relevant is

https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/master/src/Utils/DOMDataUtils.php#452

which has a big FIXME above it.

The number of messages is worrying. At 4% traffic, we log ~10k messages per hour.

Notes

A quick grep for similar errors in all parse* hosts shows that no similar messages like that were emitted in production.

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.19.0-a20	mediawiki/vendor	master	+206 -81
	Remove bogus comment in storeInPageBundle	mediawiki/services/parsoid	master	+0 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Open	None	T291916 Tracking task for Bullseye migrations in production
Stalled	None	T356293 Migrate MW appservers' base images to bullseye
Open	None	T290536 Serve production traffic via Kubernetes
Resolved	akosiaris	T357392 Create parsoid mediawiki deployment and migrate parsoid-php.discovery.wmnet traffic to it
Open	None	T358588 A lot of `[info] Wikitext for this page has duplicate ids:` in logstash for mw-parsoid. Possibly related to PageBundle

Event Timeline

akosiaris created this task.Feb 27 2024, 2:24 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 27 2024, 2:24 PM

akosiaris triaged this task as High priority.Feb 27 2024, 2:24 PM

It doesn't show up in production because the logging level is set to warn or higher there. Separately, we should probably suppress non-actionable logspam like this (there are a few of those in Parsoid).

T200517: Emit lint error or category when a page uses duplicate HTML IDs has some work done on it that could maybe change where this is being 'logged'. :)

Change 1007031 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove bogus comment in storeInPageBundle

https://gerrit.wikimedia.org/r/1007031

gerritbot added a project: Patch-For-Review.Feb 28 2024, 3:05 AM

Change 1007031 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove bogus comment in storeInPageBundle

https://gerrit.wikimedia.org/r/1007031

Change 1008400 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a20

https://gerrit.wikimedia.org/r/1008400

Change 1008400 merged by jenkins-bot: