Remove custom handling of aria-expanded in Vector checkbox hack buttons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bwang
	Jan 13 2022, 9:57 PM

Project Tags

Referenced Files

	F35021871: Screen Recording 2022-03-23 at 6.57.57 PM.mov.gif
	Mar 24 2022, 2:03 AM

	F35021873: Screen Recording 2022-03-23 at 6.59.35 PM.mov.gif
	Mar 24 2022, 2:03 AM

	F35021869: Screen Recording 2022-03-23 at 6.56.24 PM.mov.gif
	Mar 24 2022, 2:02 AM

	F35021867: Screen Recording 2022-03-23 at 6.54.32 PM.mov.gif
	Mar 24 2022, 2:02 AM

Subscribers

Description

Background

Prior to T294164 (specifically this patch) Vector was not using all of core's checkbox hack JS implementation. Instead, we were using a no-js solution that spoofed aria-expanded status for checkbox hack buttons in Vector.

Now that we are relying on JS from core to provide this behavior, the expanded status is being announced twice. If we want to support the expanded status for no-js users in the future this could be made in core, or inside the new design system.

More context

AC

When accessing a dropdown button in a screenreader, it reads out "expanded" or "collapsed" only once.
No-js users won't read out "expanded"/"collapsed"

Developer notes

This should mostly be deleting code inside Menu.mustache and MenuDropdown.less

QA Results - Beta

AC	Status	Details
1	✅	T299173#7802352
2	✅	T299173#7802352

QA Results - Prod

AC	Status	Details
1	✅	T299173#7802353
2	✅	T299173#7802353

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove custom handling of aria-expanded in Vector checkbox hack buttons	Abhigya Pandey	mediawiki/skins/Vector	master	+2 -36

Customize query in gerrit

Related Objects

Mentioned Here: T294164: [Bug] Pressing enter key on mobile site's hamburger menu opens search overlay

Event Timeline

bwang created this task.Jan 13 2022, 9:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2022, 9:57 PM

bwang updated the task description. (Show Details)Jan 13 2022, 9:58 PM

Jdlrobson moved this task from Backlog to Vector code cleanup on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.Jan 14 2022, 12:12 AM

bwang added a project: good first task.Mar 1 2022, 4:30 PM

Change 770833 had a related patch set uploaded (by Abhigya Pandey; author: Abhigya Pandey):

[mediawiki/skins/Vector@master] Remove custom handling of aria-expanded in Vector checkbox hack buttons

https://gerrit.wikimedia.org/r/770833

gerritbot added a project: Patch-For-Review.Mar 15 2022, 6:36 AM

Hi, @Jdlrobson and @bwang I made a PR on this issue with correct changes to my knowledge, please review it if something more is needed to be done then kindly suggest me:) .