Unable to edit on beta cluster while logged in: Cannot unpack array with string keys
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AlexisJazz
	Jan 14 2022, 2:51 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

[YeDiaGGa2KasF5qkD0EbIwAAABU] /w/index.php?title=Bert&action=edit Error: Cannot unpack array with string keys

Backtrace:

from /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/Tag.php(219)
#0 /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/mixins/GroupElement.php(96): OOUI\Tag->appendContent(array)
#1 /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/layouts/HorizontalLayout.php(26): OOUI\HorizontalLayout->addItems(array)
#2 /srv/mediawiki/php-master/includes/EditPage.php(3892): OOUI\HorizontalLayout->__construct(array)
#3 /srv/mediawiki/php-master/includes/EditPage.php(3138): EditPage->showStandardInputs()
#4 /srv/mediawiki/php-master/includes/EditPage.php(727): EditPage->showEditForm()
#5 /srv/mediawiki/php-master/includes/actions/EditAction.php(71): EditPage->edit()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(543): EditAction->show()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(903): MediaWiki->performRequest()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MediaWiki->main()
#10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

[YeDiRWGa2KasF5qkD0Ea8wAAAA4] /w/index.php?title=User_talk:AJ&action=edit Error: Cannot unpack array with string keys

Backtrace:

from /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/Tag.php(219)
#0 /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/mixins/GroupElement.php(96): OOUI\Tag->appendContent(array)
#1 /srv/mediawiki/php-master/vendor/oojs/oojs-ui/php/layouts/HorizontalLayout.php(26): OOUI\HorizontalLayout->addItems(array)
#2 /srv/mediawiki/php-master/includes/EditPage.php(3892): OOUI\HorizontalLayout->__construct(array)
#3 /srv/mediawiki/php-master/includes/EditPage.php(3138): EditPage->showStandardInputs()
#4 /srv/mediawiki/php-master/includes/EditPage.php(727): EditPage->showEditForm()
#5 /srv/mediawiki/php-master/includes/actions/EditAction.php(71): EditPage->edit()
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(543): EditAction->show()
#7 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(903): MediaWiki->performRequest()
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MediaWiki->main()
#10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

When logged out, the edit form loads. Editing with the API also works fine.

One or two hours ago it was fine. This edit at 00:42, 14 January 2022 (UTC) was clearly not an API edit.

What should have happened instead?:
Load the edit form.

Details

	Subject	Repo	Branch	Lines +/-
	EditPage: Don't use string array keys for OOUI HorizontalLayout items	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T293959 1.38.0-wmf.18 deployment blockers
		Resolved	BUG REPORT	matmarex	T299191 Unable to edit on beta cluster while logged in: Cannot unpack array with string keys

Event Timeline

AlexisJazz created this task.Jan 14 2022, 2:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2022, 2:51 AM

AlexisJazz mentioned this in T293958: 1.38.0-wmf.17 deployment blockers.Jan 14 2022, 2:58 AM

taavi added a parent task: T293959: 1.38.0-wmf.18 deployment blockers.Jan 14 2022, 5:53 AM

Caused by OOUI v0.43.0 version released today, probably needs a fix similar to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/753743.

matmarex mentioned this in T293959: 1.38.0-wmf.18 deployment blockers.Jan 14 2022, 6:17 AM

Change 753871 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] EditPage: Don't use string array keys for OOUI HorizontalLayout items

https://gerrit.wikimedia.org/r/753871

gerritbot added a project: Patch-For-Review.Jan 14 2022, 6:31 AM

Change 753871 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Don't use string array keys for OOUI HorizontalLayout items

https://gerrit.wikimedia.org/r/753871

Zabe merged a task: T299205: Can't edit common.css at Beta Cluster.Jan 14 2022, 9:19 AM

Zabe added subscribers: SunAfterRain, Stang.

Zabe subscribed.

Zabe closed this task as Resolved.Jan 14 2022, 9:26 AM

Zabe assigned this task to matmarex.

Zabe added a project: MediaWiki-Page-editing.Jan 14 2022, 9:38 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 14 2022, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2022, 10:10 AM

Stang unsubscribed.Jan 14 2022, 12:14 PM

Zabe mentioned this in T299463: Viewing Abusefilter history throws "Error: Cannot unpack array with string keys".Jan 18 2022, 10:23 PM

Unable to edit on beta cluster while logged in: Cannot unpack array with string keysClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Unable to edit on beta cluster while logged in: Cannot unpack array with string keys
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...