Page MenuHomePhabricator
Create Task
Maniphest T299463

Viewing Abusefilter history throws "Error: Cannot unpack array with string keys"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Go to https://www.mediawiki.org/wiki/Special:AbuseFilter/history/71.

[6a89a0d7-5891-42d0-8c03-a9e10ff713d7] /wiki/Special:AbuseFilter/history/71   Error: Cannot unpack array with string keys

from /srv/mediawiki/php-1.38.0-wmf.18/vendor/oojs/oojs-ui/php/Tag.php(219)
#0 /srv/mediawiki/php-1.38.0-wmf.18/vendor/oojs/oojs-ui/php/mixins/GroupElement.php(96): OOUI\Tag->appendContent(array)
#1 /srv/mediawiki/php-1.38.0-wmf.18/vendor/oojs/oojs-ui/php/layouts/HorizontalLayout.php(26): OOUI\HorizontalLayout->addItems(array)
#2 /srv/mediawiki/php-1.38.0-wmf.18/extensions/AbuseFilter/includes/View/AbuseFilterViewHistory.php(102): OOUI\HorizontalLayout->__construct(array)
#3 /srv/mediawiki/php-1.38.0-wmf.18/extensions/AbuseFilter/includes/Special/SpecialAbuseFilter.php(166): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewHistory->show()
#4 /srv/mediawiki/php-1.38.0-wmf.18/includes/specialpage/SpecialPage.php(671): MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter->execute(string)
#5 /srv/mediawiki/php-1.38.0-wmf.18/includes/specialpage/SpecialPageFactory.php(1378): SpecialPage->run(string)
#6 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(903): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.38.0-wmf.18/includes/MediaWiki.php(563): MediaWiki->main()
#9 /srv/mediawiki/php-1.38.0-wmf.18/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.38.0-wmf.18/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Details

SubjectRepoBranchLines +/-
Don't use array keys for OOUI in AbuseFilterViewDiffmediawiki/extensions/AbuseFilterwmf/1.38.0-wmf.18+1 -1
Don't use array keys for OOUImediawiki/extensions/AbuseFilterwmf/1.38.0-wmf.18+1 -1
Don't use array keys for OOUI in AbuseFilterViewDiffmediawiki/extensions/AbuseFiltermaster+1 -1
Don't use array keys for OOUImediawiki/extensions/AbuseFiltermaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT293959 1.38.0-wmf.18 deployment blockers
 ResolvedPRODUCTION ERRORZabeT299463 Viewing Abusefilter history throws "Error: Cannot unpack array with string keys"

Event Timeline

Zabe created this task.Jan 18 2022, 10:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2022, 10:10 PM
Zabe updated the task description. (Show Details)Jan 18 2022, 10:11 PM
gerritbot added a comment.Jan 18 2022, 10:11 PM

Change 755032 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AbuseFilter@master] Don't use array keys for OOUI

https://gerrit.wikimedia.org/r/755032

gerritbot added a project: Patch-For-Review.Jan 18 2022, 10:11 PM
Zabe changed the subtype of this task from "Task" to "Production Error".Jan 18 2022, 10:11 PM
Zabe added a parent task: T293958: 1.38.0-wmf.17 deployment blockers.
Zabe removed a parent task: T293958: 1.38.0-wmf.17 deployment blockers.
Zabe triaged this task as Unbreak Now! priority.Jan 18 2022, 10:13 PM
Zabe added a parent task: T293959: 1.38.0-wmf.18 deployment blockers.
Zabe added a comment.Jan 18 2022, 10:23 PM

Like T299191 this has been caused by OOUI v0.43.0 version release which is part of this train.

Zabe renamed this task from Viewing Abusefilter history throws fatals to Viewing Abusefilter history throws "Error: Cannot unpack array with string keys".Jan 18 2022, 10:33 PM
matmarex subscribed.Jan 18 2022, 10:44 PM

There was one very similar fix in AbuseFilter already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/753743 (this one was caught by unit tests).

Zabe added a comment.Jan 18 2022, 10:48 PM

Quickly auditing the code there are more. Diffs are at least also broken https://www.mediawiki.org/wiki/Special:AbuseFilter/history/3/diff/prev/cur.

gerritbot added a comment.Jan 18 2022, 10:52 PM

Change 755037 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AbuseFilter@master] Don't use array keys for OOUI in AbuseFilterViewDiff

https://gerrit.wikimedia.org/r/755037

gerritbot added a comment.Jan 18 2022, 11:04 PM

Change 755032 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Don't use array keys for OOUI

https://gerrit.wikimedia.org/r/755032

gerritbot added a comment.Jan 18 2022, 11:05 PM

Change 754917 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AbuseFilter@wmf/1.38.0-wmf.18] Don't use array keys for OOUI

https://gerrit.wikimedia.org/r/754917

gerritbot added a comment.Jan 18 2022, 11:36 PM

Change 755037 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Don't use array keys for OOUI in AbuseFilterViewDiff

https://gerrit.wikimedia.org/r/755037

gerritbot added a comment.Jan 18 2022, 11:39 PM

Change 754918 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AbuseFilter@wmf/1.38.0-wmf.18] Don't use array keys for OOUI in AbuseFilterViewDiff

https://gerrit.wikimedia.org/r/754918

Agusbou2015 subscribed.Jan 18 2022, 11:42 PM
matmarex added a comment.Jan 18 2022, 11:50 PM

(As far as I can tell, there are no more similar issues in AbuseFilter.)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 12:00 AM
gerritbot added a comment.Jan 19 2022, 12:48 AM

Change 754917 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@wmf/1.38.0-wmf.18] Don't use array keys for OOUI

https://gerrit.wikimedia.org/r/754917

gerritbot added a comment.Jan 19 2022, 12:48 AM

Change 754918 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@wmf/1.38.0-wmf.18] Don't use array keys for OOUI in AbuseFilterViewDiff

https://gerrit.wikimedia.org/r/754918

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 19 2022, 1:00 AM
Stashbot added a comment.Jan 19 2022, 1:00 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-19T01:00:43Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/AbuseFilter/: Backport: [[gerrit:754917|Don't use array keys for OOUI (T299463)]] and [[gerrit:754918|Don't use array keys for OOUI in AbuseFilterViewDiff (T299463)]] (duration: 00m 54s)

Zabe closed this task as Resolved.Jan 19 2022, 1:03 AM
Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 12:47 AM
Zabe removed a project: Patch-For-Review.Apr 13 2022, 10:18 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL