| Jdlrobson | |
| Jan 20 2022, 5:30 PM |
| F34924731: image.png | |
| Jan 20 2022, 5:38 PM |
Occurring in production.
Can be replicated at this URL:
https://login.wikimedia.org/wiki/Special:Log/block?page=User:Majavah&useskinversion=2&useskin=vector
Impact:
14 exceptions in last hour, seems to only impact login wiki logged in users
Loginwiki offline for Vector: https://login.wikimedia.org/wiki/Main_Page VS https://login.wikimedia.org/wiki/Main_Page?useskin=minerva
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | jeena | T293959 1.38.0-wmf.18 deployment blockers | ||
| Resolved | Jdlrobson | T299671 Loginwiki fatals (TypeError: Argument 1 passed to Vector\Hooks::makeMenuItemCollapsible() must be of the type array, null given, called in /srv/mediawiki/php-1.38.0-wmf.18/skins/Vector/includes/Hooks.php on line 226) |
Not reproducible on beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log/block?page=User:Majavah&useskinversion=2&useskin=vector so we've probably merged the fix to master already... Investigating.
What's special about the setup on loginwiki?
Can't replicate on beta cluster login wiki either https://login.wikimedia.beta.wmflabs.org/wiki/Special:Log/block?page=User:Majavah&useskinversion=2&useskin=vector (when anonymous)
Loginwiki has most extensions disabled that normal wikis have
Can't replicate on beta cluster login wiki either https://login.wikimedia.beta.wmflabs.org/wiki/Special:Log/block?page=User:Majavah&useskinversion=2&useskin=vector
I can:
I can replicate with:
$wgGroupPermissions['*']['viewmywatchlist'] = false; `` SO I'm guessing loginwiki does this somewhere.
Change 755740 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Do not try to make watchlist collapsible on wikis where watchlist is disabled
Change 755740 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Do not try to make watchlist collapsible on wikis where watchlist is disabled
Change 755682 had a related patch set uploaded (by Majavah; author: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Do not try to make watchlist collapsible on wikis where watchlist is disabled
Change 755682 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.38.0-wmf.18] Do not try to make watchlist collapsible on wikis where watchlist is disabled
Mentioned in SAL (#wikimedia-operations) [2022-01-20T18:29:54Z] <taavi@deploy1002> Synchronized php-1.38.0-wmf.18/skins/Vector/includes/Hooks.php: Backport: [[gerrit:755682|Do not try to make watchlist collapsible on wikis where watchlist is disabled (T299671)]] (duration: 00m 50s)