Page MenuHomePhabricator

References created/edited in Visual Editor displaying "blanks" & error messages
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Using Visual Editor in Wikipedia, insert a citation by using "Cite / Re-use"...but also edit the original reference by adding more page numbers, for example

What happens?:

  • After you submit your edit, you get a big red error message in the References section for that source that looks something like this (although usually it has a slightly different message)

Screenshot 2022-01-25 at 17.09.39.png (348×968 px, 100 KB)

  • In some cases, References have been completely overwritten by other References (and disappeared / incorrectly consolidated with the wrong source after triggering errors)
  • In some cases, two versions of the same Reference seem to exist for a while...one with the page number change, one without the page number change...in other cases, the newly edited Reference causes the other to be overwritten/blanked but NOT updated correctly, if that makes sense
  • A big clue that something is wrong is when you mouse over the footnote number and all you see is a "blank" even though you KNOW it used to be a valid citation – later it turns out that sometimes it really is broken and sometimes it's not (at least temporarily)

Screenshot 2022-01-25 at 17.15.21.png (344×566 px, 78 KB)

What should have happened instead?:

  • I used to be able to add in page numbers for re-used references, no problem, using Visual Editor...it didn't matter how "old" the reference was.
  • Now I have had to go back and delete all the broken references and re-add them again "fresh"

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

  • Here are a bunch of pages where I have recently encountered problems and found myself trying to go back and do manual workarounds... If you look in the History of these pages, you will see how I encountered these issues over and over again (tried to flag it in my Comments for each edit)...I'm sorry I didn't submit this bug sooner but what is strange is that on some pages, I haven't encountered this problem at all...

Tatiana Saunders
Margaret Bonga Fahlstrom
Daniel Robertson (British Army Officer)

Event Timeline

Hi @Cielquiparle, thanks for taking the time to report this! Does this also happen in safemode with zero gadgets or user scripts involved?

Yes! I switched to safemode and was able to recreate the problem just now:

Screenshot 2022-01-25 at 19.03.27.png (462×866 px, 117 KB)

(Though I wasn't sure if I need to do something else to disable all my gadgets besides viewing in safemode? A further detail is that I use the "Timeless" skin by default, which I think sometimes behaves differently from other skins, but maybe it's not relevant.)

Looks promising, it definitely had something to do with the Reference numbers not updating / shifting properly,

In fact, come to think of it, what seemed to be triggering the problem initially was when I would try to Re-use Citations that had occurred lower down on the page and insert them much higher up on the page. (But now I think that's not the only time it happens.)

Not sure if the fix has gone live yet...but I just encountered this problem again. (I was also wondering if it's likely that the fix will prevent the problem moving forward but won't be able to address existing instances of errors...?)

Screenshot 2022-01-27 at 22.51.18.png (284×930 px, 126 KB)

Not sure if the fix has gone live yet...but I just encountered this problem again.

I'm not sure if it was live at the time you tested, but it definitely is now, if you'd like to re-test. (Note that we have one other significant known issue related to re-using references: T299378.)

(I was also wondering if it's likely that the fix will prevent the problem moving forward but won't be able to address existing instances of errors...?)

Yes, if a page was already saved with the error, it won't be changed until the page is edited and the reference definition is corrected.

Still happening. Specifically:

  • When you insert / re-use an existing citation higher up on the page than where it was first inserted/created, and edit it (for example, by adding page numbers) using Visual Editor, you get this error:

Screenshot 2022-01-31 at 08.39.34.png (200×1 px, 198 KB)

  • The error states that "The named reference ":NUMBER" was defined multiple times with different content."

@Cielquiparle I'm sorry for being late to respond. I tried and I can't reproduce the problem.

It looks like you were editing the page https://en.wikipedia.org/wiki/Harriet_Robinson_Scott. Here's a screen recording that shows me re-using the citation that way without problems:
(better quality video: https://drive.google.com/file/d/1oP88f6Cl6PqabggDxv1uV3f79kwtH4bG/view – Phabricator won't let me upload it here)

In the video, I go to the first use of the citation, re-use it above (by copy-pasting), change it, confirm it looks fine in visual editor, preview the wikitext diff and switch to wikitext editor, and confirm that it looks fine in the wikitext editor preview. I also didn't see any issues when it's a newly inserted citation, or when re-using using the toolbar menu (not shown in the recording).

Are you doing something differently?

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.

As far as I know, this is fixed. Handing over to QA to double-check.

@Cielquiparle Please let us know if you still see the issue.

As far as I know, this is fixed. Handing over to QA to double-check.

@Cielquiparle Please let us know if you still see the issue.

The issue must have been fixed as it works fine on my end as well. Thanks for the attached video @matmarex.

For visual reference, see T300066#7723733.

ppelberg claimed this task.