Maniphest T300588

NearbyPages skeleton cards generate a broken link
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jan 31 2022, 11:44 PM

Tags

Referenced Files

None

Subscribers

Description

During the loading state, the cards are clickable and lead to /wiki/Undefined. That seems unintended.

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby

QA

Load https://en.wikipedia.beta.wmflabs.org/wiki/Special:Nearby
Click "Show nearby pages"
Click one of the cards quickly before they load.

Expected: No change
Actual: I am navigated to https://en.wikipedia.beta.wmflabs.org/wiki/Undefined

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: Titles returned by geosearch are non canonical	mediawiki/extensions/NearbyPages	master	+16 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T277047 Design inventory of Wikiverse (Codex design system, OOUI, MediaWiki widgets) UI components
		Duplicate		None	T280842 Define and add guidelines for adding skeleton/placeholder UI to the DSG
		Resolved		None	T246493 [EPIC] Deploy NearbyPages everywhere
		Resolved		None	T300588 NearbyPages skeleton cards generate a broken link

Event Timeline

Jdlrobson created this task.Jan 31 2022, 11:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2022, 11:44 PM

Jdlrobson mentioned this in T289738: Performance review of Extension:NearbyPages.Feb 1 2022, 12:31 AM

Jdlrobson moved this task from WVUI migrations to Codex focus on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Feb 1 2022, 4:23 PM

Volker_E added a parent task: T280842: Define and add guidelines for adding skeleton/placeholder UI to the DSG.Feb 1 2022, 5:33 PM

Jdlrobson triaged this task as Medium priority.Feb 14 2022, 11:31 PM

Jdlrobson added a parent task: T246493: [EPIC] Deploy NearbyPages everywhere.Mar 9 2022, 7:25 PM

Jdlrobson moved this task from Backlog to Doing on the NearbyPages board.Aug 17 2022, 8:36 AM

Change 824136 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/NearbyPages@master] Fixes: Titles returned by geosearch are non canonical

https://gerrit.wikimedia.org/r/824136

gerritbot added a project: Patch-For-Review.Aug 17 2022, 8:36 AM

Change 824136 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Fixes: Titles returned by geosearch are non canonical

https://gerrit.wikimedia.org/r/824136

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2022, 4:33 PM

Jdlrobson closed this task as Resolved.Aug 30 2022, 4:45 PM

Jdlrobson claimed this task.

Jdlrobson removed Jdlrobson as the assignee of this task.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog (Needs Prioritization (Tech)).

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.