Page MenuHomePhabricator

[EPIC] Deploy NearbyPages everywhere
Open, Needs TriagePublic

Description

Once NearbyPages is ready and deployed, MobileFrontend will no longer provide Special:Nearby thanks to this patch.

Let's deploy to a single wiki, test extensively and then drop Nearby from MobileFrontend.

Acceptance criteria

  • Team review of NearbyPages Extension (T271251)
  • Security review has occurred (T269291)
  • Enable NearbyPages on beta cluster beta cluster
  • Check in with Performance team about review prior to production deployment
  • verify wikidata version on wikidata beta cluster
  • Enable NearbyPages on test wiki e.g. Catalan Wikipedia
  • Test NearbyPages is working as expected
  • Enable NearbyPages everywhere.
  • Remove MobileFrontend code and bump version number. T246494

Event Timeline

Jdlrobson updated the task description. (Show Details)

Heyo! Quick question, @Jdlrobson: which team will be the steward of this new extension? Thanks!

@greg - readers web (we are just breaking out this functionality from MobileFrontend in a more maintainable form)

Change 713653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

Change 713667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Change 713667 merged by jenkins-bot:

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Heyo again, @Jdlrobson ! I don't see a mention of a performance review in the task description; is one planned for this? I just want to make sure that it's planned/accounted for appropriately by the Perf team. Thanks!

Change 713653 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:17:30Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 1/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:18:50Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 2/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:20:07Z] <urbanecm@deploy1002> Synchronized wmf-config/extension-list: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 3/3) (duration: 01m 05s)

@Ladsgroup the new NearbyPages is at https://wikidata.beta.wmflabs.org/wiki/Special:Nearby
Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

Looks awesome. cc. @Addshore

Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

That'd be @Lydia_Pintscher and @Manuel

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

I had a quick look and it looks really nice!
One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata. It should be Items. Is this something that can be configured or gotten from an existing place?

image.png (374×615 px, 19 KB)

image.png (254×522 px, 26 KB)

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

I suggest avoiding more strings for translations. Adding translation messages adds a lot of burden to volunteer translators (as a person who does a lot for Persian, it's tedious, boring, thankless and annoying).

Also this feature (could) possibly be deployed outside of WMF in a Wikibase repo.

To clarify, I suggest changing "article" to "page" and not adding another message in WikimediaMessages