[EPIC] Deploy NearbyPages everywhere
Open, Needs TriagePublic
Actions

Description

Once NearbyPages is ready and deployed, MobileFrontend will no longer provide Special:Nearby thanks to this patch.

Let's deploy to a single wiki, test extensively and then drop Nearby from MobileFrontend.

Acceptance criteria

Team review of NearbyPages Extension (T271251)
Security review has occurred (T269291)
Enable NearbyPages on beta cluster beta cluster
Check in with Performance team about review prior to production deployment
verify wikidata version on wikidata beta cluster
Enable NearbyPages on test wiki e.g. Catalan Wikipedia
Test NearbyPages is working as expected
Enable NearbyPages everywhere.
Remove MobileFrontend code and bump version number. T246494

Details

	Project	Branch	Lines +/-	Subject
	operations/mediawiki-config	master	+31 -0	Enable NearbyPages on beta cluster
	mediawiki/tools/release	master	+1 -0	Start branching NearbyPages extension

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T246493 [EPIC] Deploy NearbyPages everywhere
Stalled		None	T246494 Drop Nearby code from MobileFrontend
Resolved		Jdlrobson	T246495 [EPIC] Build a new version of Special:Nearby using Vue framework
Resolved		None	T246500 Request geolocation from user
Resolved		None	T246503 Build the Card and PageList component in Vue
Resolved		None	T246505 Create the API component
Resolved		Jdlrobson	T246532 Localize Special:Nearby on trwiki
Resolved		None	T252263 Add tests for JS code
Resolved		Kizule	T246527 Enable phan and seccheck
Resolved		Kizule	T246528 Enable PHPCS
Resolved	Security	Jdlrobson	T269291 Security Readiness Review For Extension:NearbyPages
Open		None	T289738 Performance review of Extension:NearbyPages

Event Timeline

Jdlrobson created this task.Feb 28 2020, 9:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 28 2020, 9:22 PM

Jdlrobson changed the status of subtask T246494: Drop Nearby code from MobileFrontend from Open to Stalled.Feb 28 2020, 9:23 PM

Jdlrobson updated the task description. (Show Details)

Ammarpad mentioned this in T246532: Localize Special:Nearby on trwiki.Feb 29 2020, 1:58 PM

Reedy closed subtask T246527: Enable phan and seccheck as Resolved.Feb 29 2020, 2:52 PM

Reedy closed subtask T246528: Enable PHPCS as Resolved.

Jdlrobson moved this task from Backlog to Todo on the NearbyPages board.Apr 9 2020, 8:59 PM

Jdlrobson closed subtask T246495: [EPIC] Build a new version of Special:Nearby using Vue framework as Resolved.Jul 2 2020, 2:14 AM

Jdlrobson updated the task description. (Show Details)Dec 2 2020, 8:21 PM

sbassett changed the status of subtask T269291: Security Readiness Review For Extension:NearbyPages from Open to Stalled.Dec 7 2020, 4:36 PM

sbassett changed the status of subtask T269291: Security Readiness Review For Extension:NearbyPages from Stalled to Open.Dec 7 2020, 4:56 PM

Heyo! Quick question, @Jdlrobson: which team will be the steward of this new extension? Thanks!

@greg - readers web (we are just breaking out this functionality from MobileFrontend in a more maintainable form)

Jdlrobson added projects: Goal, Readers-Web-Backlog.Aug 3 2021, 5:56 PM

Jdlrobson moved this task from Incoming to unsed on the Readers-Web-Backlog board.

Zabe added a subscriber: Zabe.Aug 4 2021, 3:27 PM

Jdlrobson moved this task from unsed to Needs Prioritization (Tech) on the Readers-Web-Backlog board.Aug 10 2021, 8:50 PM

Jdlrobson edited projects, added Readers-Web-Backlog (Needs Prioritization (Tech)); removed Readers-Web-Backlog.

Jdlrobson moved this task from Backlog to WVUI migrations on the Readers-Web-Backlog (Needs Prioritization (Tech)) board.Aug 11 2021, 6:05 PM

sbassett closed subtask T269291: Security Readiness Review For Extension:NearbyPages as Resolved.Aug 16 2021, 6:47 PM

Change 713653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

gerritbot added a project: Patch-For-Review.Aug 18 2021, 4:24 PM

Change 713667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Change 713667 merged by jenkins-bot:

[mediawiki/tools/release@master] Start branching NearbyPages extension

https://gerrit.wikimedia.org/r/713667

Heyo again, @Jdlrobson ! I don't see a mention of a performance review in the task description; is one planned for this? I just want to make sure that it's planned/accounted for appropriately by the Perf team. Thanks!

Jdlrobson updated the task description. (Show Details)Aug 24 2021, 8:24 PM

Jdlrobson added a subtask: T289738: Performance review of Extension:NearbyPages.Aug 25 2021, 8:47 PM

Change 713653 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable NearbyPages on beta cluster

https://gerrit.wikimedia.org/r/713653

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:17:30Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 1/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:18:50Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 2/3) (duration: 01m 06s)

Mentioned in SAL (#wikimedia-operations) [2021-09-01T23:20:07Z] <urbanecm@deploy1002> Synchronized wmf-config/extension-list: 91ff9273fd9f80b571771a7454d34d63f43405b8: Enable NearbyPages on beta cluster (T246493; 3/3) (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.Thu, Sep 2, 12:10 AM

Jdlrobson updated the task description. (Show Details)Thu, Sep 2, 12:49 AM

@Ladsgroup the new NearbyPages is at https://wikidata.beta.wmflabs.org/wiki/Special:Nearby
Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

In T246493#7329778, @Jdlrobson wrote:

@Ladsgroup the new NearbyPages is at https://wikidata.beta.wmflabs.org/wiki/Special:Nearby

Looks awesome. cc. @Addshore

Who on Wikidata.org side would be able to review it and approve it from a product perspective for deployment?

That'd be @Lydia_Pintscher and @Manuel

The new version is built with Vue.js/WVUI and should fix various problems with the old implementation.

I had a quick look and it looks really nice!
One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata. It should be Items. Is this something that can be configured or gotten from an existing place?

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

In T246493#7337693, @Jdlrobson wrote:

One thing I noticed: There are at least 3 places in the UI that talk about articles, which is not quite right for Wikidata.

We could call these "items" by adding translations to WikimediaMessages but pages is probably more generic than articles (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/719352)

I suggest avoiding more strings for translations. Adding translation messages adds a lot of burden to volunteer translators (as a person who does a lot for Persian, it's tedious, boring, thankless and annoying).

Also this feature (could) possibly be deployed outside of WMF in a Wikibase repo.

To clarify, I suggest changing "article" to "page" and not adding another message in WikimediaMessages

I'm fine with pages as well yeah.

Jdlrobson mentioned this in T117159: uselang parameter doesn't work for labels/descriptions on Special:Nearby.Tue, Sep 21, 8:32 PM

Jdlrobson updated the task description. (Show Details)Wed, Sep 22, 9:10 PM

[EPIC] Deploy NearbyPages everywhereOpen, Needs TriagePublicActions