DonationInterface forms should accept full_name
Closed, ResolvedPublic
Actions

Description

We currently only accept first and last name fields separately. Since Amazon Pay and Google Pay give us a full name, we should send that complete name to Civi. At Civi we can store the full name as well as apply more sophisticated logic to parse out likely first/last/middle initials.

This task will include adding a full_name field to the DonationData object and ensuring it is persisted to session, adding a full_name parameter to any APIs that currently accept first and last name, and adding the full_name to the queue message when data exists.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/DonationInterface	master	+18 -3	Add full_name to queue

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ejegg	T244513 EPIC: Implement GPAY through adyen
		Resolved		AnnWF	T300684 DonationInterface forms should accept full_name

Event Timeline

Ejegg created this task.Feb 1 2022, 11:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2022, 11:36 PM

Ejegg mentioned this in T300691: Amazon Pay should send full name to Civi.Feb 2 2022, 12:00 AM

• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Feb 2 2022, 5:25 PM

• DStrine added a project: FR-Gpay-Integration.Feb 11 2022, 9:41 PM

• DStrine moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.Feb 11 2022, 9:47 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Mar 1 2022, 9:05 PM

Note that on the Civi Side we currently handle in ChecksFile - we should move that to WMFContact::save()

if (!empty($msg['full_name']) && (empty($msg['first_name']) || empty($msg['last_name']))) {
  // Parse name parts into fields if we have the full name and the name parts are
  // not otherwise specified.
  $msg = array_merge(array_filter((array) Name::parse(FALSE)
    ->setNames([$msg['full_name']])
    ->execute()->first()), $msg);
  $msg['addressee_custom'] = $msg['full_name'];
}

• DStrine added a project: Fundraising Sprint Discworld reformatted as ntfs.Mar 1 2022, 9:10 PM

• DStrine triaged this task as Low priority.Mar 1 2022, 9:36 PM

jgleeson claimed this task.Mar 10 2022, 4:58 PM

jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Discworld reformatted as ntfs board.

jgleeson reassigned this task from jgleeson to AnnWF.Mar 10 2022, 5:03 PM

jgleeson added a subscriber: jgleeson.

Change 770521 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add full_name to queue

https://gerrit.wikimedia.org/r/770521

gerritbot added a project: Patch-For-Review.Mar 14 2022, 3:04 PM

AnnWF moved this task from Doing to Review on the Fundraising Sprint Discworld reformatted as ntfs board.Mar 15 2022, 7:12 PM

• DStrine added a project: Fundraising Sprint e^🥧👀=yum.Mar 15 2022, 8:34 PM