Page MenuHomePhabricator
Create Task
Maniphest T300774

Drop fr_img_* columns
Closed, ResolvedPublic
Actions

Description

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/757949/4/backend/schema/mysql/patch-drop-fr_img.sql
  2. Where to run those changes: flaggedrevs.dblist
  3. When to run those changes: after wmf.21 is stable (Feb 14 onwards if everything goes alright)
  4. If the schema change is backwards compatible: No
  5. If the schema change has been tested already on some of the test/beta wikis: Tested locally.
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress:

  • s1
  • s2
  • s3
  • s4 (N/A)
  • s5
  • s6
  • s7
  • s8 (N/A)
  • labtestwiki (N/A)

Details

SubjectRepoBranchLines +/-
filtered_tables.txt: Drop unused columnsoperations/puppetproduction+0 -3
2022/T300774: Make command idempotent.operations/software/schema-changesmaster+5 -1
2022/T300774: Fix logic in check()operations/software/schema-changesmaster+1 -1
Add 2022/drop_fr_img_star_cols_T300774.pyoperations/software/schema-changesmaster+37 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Stashbot added a comment.Feb 24 2022, 12:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T12:44:01Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T300774)', diff saved to https://phabricator.wikimedia.org/P21460 and previous config saved to /var/cache/conftool/dbconfig/20220224-124401-kormat.json

Stashbot added a comment.Feb 24 2022, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T13:29:15Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T300774)', diff saved to https://phabricator.wikimedia.org/P21468 and previous config saved to /var/cache/conftool/dbconfig/20220224-132915-kormat.json

Stashbot added a comment.Feb 24 2022, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T13:29:30Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1134 (T300774)', diff saved to https://phabricator.wikimedia.org/P21469 and previous config saved to /var/cache/conftool/dbconfig/20220224-132923-kormat.json

Stashbot added a comment.Feb 24 2022, 1:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T13:32:03Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T300774)', diff saved to https://phabricator.wikimedia.org/P21470 and previous config saved to /var/cache/conftool/dbconfig/20220224-133202-kormat.json

Stashbot added a comment.Feb 24 2022, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T14:17:17Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T300774)', diff saved to https://phabricator.wikimedia.org/P21478 and previous config saved to /var/cache/conftool/dbconfig/20220224-141717-kormat.json

Stashbot added a comment.Feb 24 2022, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T14:17:32Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1135 (T300774)', diff saved to https://phabricator.wikimedia.org/P21479 and previous config saved to /var/cache/conftool/dbconfig/20220224-141724-kormat.json

Stashbot added a comment.Feb 24 2022, 2:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T14:20:05Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T300774)', diff saved to https://phabricator.wikimedia.org/P21480 and previous config saved to /var/cache/conftool/dbconfig/20220224-142004-kormat.json

Stashbot added a comment.Feb 24 2022, 3:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:05:20Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T300774)', diff saved to https://phabricator.wikimedia.org/P21486 and previous config saved to /var/cache/conftool/dbconfig/20220224-150520-kormat.json

Stashbot added a comment.Feb 24 2022, 3:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:05:35Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1184 (T300774)', diff saved to https://phabricator.wikimedia.org/P21487 and previous config saved to /var/cache/conftool/dbconfig/20220224-150527-kormat.json

Stashbot added a comment.Feb 24 2022, 3:10 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:10:07Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T300774)', diff saved to https://phabricator.wikimedia.org/P21488 and previous config saved to /var/cache/conftool/dbconfig/20220224-151007-kormat.json

Stashbot added a comment.Feb 24 2022, 3:55 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:55:21Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T300774)', diff saved to https://phabricator.wikimedia.org/P21491 and previous config saved to /var/cache/conftool/dbconfig/20220224-155521-kormat.json

Stashbot added a comment.Feb 24 2022, 3:57 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:57:16Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1106 (T300774)', diff saved to https://phabricator.wikimedia.org/P21492 and previous config saved to /var/cache/conftool/dbconfig/20220224-155708-kormat.json

Stashbot added a comment.Feb 24 2022, 3:59 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T15:59:45Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T300774)', diff saved to https://phabricator.wikimedia.org/P21493 and previous config saved to /var/cache/conftool/dbconfig/20220224-155944-kormat.json

Stashbot added a comment.Feb 24 2022, 4:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T16:44:59Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T300774)', diff saved to https://phabricator.wikimedia.org/P21496 and previous config saved to /var/cache/conftool/dbconfig/20220224-164458-kormat.json

Stashbot added a comment.Feb 24 2022, 4:45 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T16:45:12Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1119 (T300774)', diff saved to https://phabricator.wikimedia.org/P21497 and previous config saved to /var/cache/conftool/dbconfig/20220224-164506-kormat.json

Stashbot added a comment.Feb 24 2022, 4:47 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T16:47:46Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T300774)', diff saved to https://phabricator.wikimedia.org/P21498 and previous config saved to /var/cache/conftool/dbconfig/20220224-164745-kormat.json

Stashbot added a comment.Feb 24 2022, 5:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T17:33:00Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T300774)', diff saved to https://phabricator.wikimedia.org/P21501 and previous config saved to /var/cache/conftool/dbconfig/20220224-173259-kormat.json

Stashbot added a comment.Feb 24 2022, 5:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T17:33:16Z] <kormat@cumin1001> dbctl commit (dc=all): 'Depooling db1164 (T300774)', diff saved to https://phabricator.wikimedia.org/P21502 and previous config saved to /var/cache/conftool/dbconfig/20220224-173307-kormat.json

Stashbot added a comment.Feb 24 2022, 5:35 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T17:35:48Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T300774)', diff saved to https://phabricator.wikimedia.org/P21503 and previous config saved to /var/cache/conftool/dbconfig/20220224-173548-kormat.json

Stashbot added a comment.Feb 24 2022, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-02-24T18:21:03Z] <kormat@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T300774)', diff saved to https://phabricator.wikimedia.org/P21508 and previous config saved to /var/cache/conftool/dbconfig/20220224-182102-kormat.json

• Kormat updated the task description. (Show Details)Feb 24 2022, 7:03 PM
• Kormat mentioned this in T301312: Switchover s1 master (db1118 -> db1163).Feb 25 2022, 10:19 AM
• Kormat mentioned this in T301850: Switchover s3 master (db1157 -> db1123).
• Kormat updated the task description. (Show Details)Feb 25 2022, 10:23 AM
• Kormat added subtasks: T301312: Switchover s1 master (db1118 -> db1163), T300510: Upgrade s2 to Bullseye, T301850: Switchover s3 master (db1157 -> db1123), T300473: Upgrade s5 to Bullseye, T300471: Switchover s6 master (db1173 -> db1131), T302363: Upgrade s7 to bullseye.
Marostegui moved this task from In progress to Unclear/blocked to proceed on the Schema-change-in-production board.Mar 8 2022, 12:30 PM
Marostegui moved this task from Ready to Blocked on the DBA board.
Marostegui added a comment.Mar 16 2022, 2:58 PM

This can probably continue on most of the masters as the table is not too big on the majority of the wikis and dropping a column is a DDL operation, so as long as it is done without replication this task can continue without being blocked on master swaps.

Marostegui added a comment.Mar 29 2022, 6:07 AM

s3 old master (db1157) can now proceed, as well as the rest of the masters, see my previous comment.

Marostegui closed subtask T301850: Switchover s3 master (db1157 -> db1123) as Resolved.Mar 29 2022, 6:12 AM
Marostegui added a comment.Mar 31 2022, 6:11 AM
In T300774#7813131, @Marostegui wrote:

s3 old master (db1157) can now proceed, as well as the rest of the masters, see my previous comment.

Same applies to old s5 master (db1130)

Marostegui closed subtask T300473: Upgrade s5 to Bullseye as Resolved.Apr 4 2022, 5:34 AM
Marostegui added a comment.Apr 19 2022, 6:36 AM

Same applies to old s7 master (db1136)

Marostegui closed subtask T302363: Upgrade s7 to bullseye as Resolved.Apr 20 2022, 4:35 AM
Marostegui added a comment.Apr 26 2022, 6:15 AM

Same applies to old s2 master (db1122)

Ladsgroup changed the status of subtask T300510: Upgrade s2 to Bullseye from Stalled to Open.Apr 26 2022, 6:50 AM
Marostegui closed subtask T300510: Upgrade s2 to Bullseye as Resolved.Apr 26 2022, 8:26 AM
Marostegui moved this task from Blocked to Ready on the DBA board.Apr 27 2022, 2:00 PM
• Kormat moved this task from Ready to Blocked on the DBA board.May 2 2022, 8:27 AM
Stashbot added a comment.May 17 2022, 12:57 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T12:57:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1136 (T300774)', diff saved to https://phabricator.wikimedia.org/P27845 and previous config saved to /var/cache/conftool/dbconfig/20220517-125713-ladsgroup.json

Stashbot added a comment.May 17 2022, 1:03 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T13:03:23Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1136 (T300774)', diff saved to https://phabricator.wikimedia.org/P27846 and previous config saved to /var/cache/conftool/dbconfig/20220517-130322-ladsgroup.json

Ladsgroup claimed this task.May 17 2022, 1:04 PM
Ladsgroup moved this task from Blocked to In progress on the DBA board.

Kormat is out sick. I take over.

Ladsgroup updated the task description. (Show Details)May 17 2022, 1:04 PM
Stashbot added a comment.May 17 2022, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T13:48:38Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1136 (T300774)', diff saved to https://phabricator.wikimedia.org/P27855 and previous config saved to /var/cache/conftool/dbconfig/20220517-134838-ladsgroup.json

Stashbot added a comment.May 17 2022, 1:50 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T13:50:09Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1157 (T300774)', diff saved to https://phabricator.wikimedia.org/P27856 and previous config saved to /var/cache/conftool/dbconfig/20220517-135006-ladsgroup.json

Ladsgroup updated the task description. (Show Details)May 17 2022, 1:53 PM
Stashbot added a comment.May 17 2022, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T13:54:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1157 (T300774)', diff saved to https://phabricator.wikimedia.org/P27857 and previous config saved to /var/cache/conftool/dbconfig/20220517-135401-ladsgroup.json

Stashbot added a comment.May 17 2022, 2:39 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T14:39:17Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1157 (T300774)', diff saved to https://phabricator.wikimedia.org/P27865 and previous config saved to /var/cache/conftool/dbconfig/20220517-143916-ladsgroup.json

Stashbot added a comment.May 17 2022, 5:25 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T17:25:23Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1130 (T300774)', diff saved to https://phabricator.wikimedia.org/P27883 and previous config saved to /var/cache/conftool/dbconfig/20220517-172521-ladsgroup.json

Ladsgroup updated the task description. (Show Details)May 17 2022, 5:25 PM
Stashbot added a comment.May 17 2022, 5:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T17:26:32Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1130 (T300774)', diff saved to https://phabricator.wikimedia.org/P27884 and previous config saved to /var/cache/conftool/dbconfig/20220517-172632-ladsgroup.json

Stashbot added a comment.May 17 2022, 9:25 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T21:25:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1122 (T300774)', diff saved to https://phabricator.wikimedia.org/P27892 and previous config saved to /var/cache/conftool/dbconfig/20220517-212530-ladsgroup.json

Ladsgroup updated the task description. (Show Details)May 17 2022, 9:33 PM
Stashbot added a comment.May 17 2022, 9:43 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T21:43:49Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1122 (T300774)', diff saved to https://phabricator.wikimedia.org/P27893 and previous config saved to /var/cache/conftool/dbconfig/20220517-214349-ladsgroup.json

Stashbot added a comment.May 17 2022, 10:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-05-17T22:29:05Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1122 (T300774)', diff saved to https://phabricator.wikimedia.org/P27896 and previous config saved to /var/cache/conftool/dbconfig/20220517-222904-ladsgroup.json

Ladsgroup updated the task description. (Show Details)May 19 2022, 6:18 AM
Ladsgroup closed subtask T301312: Switchover s1 master (db1118 -> db1163) as Resolved.
Ladsgroup closed this task as Resolved.May 25 2022, 8:00 AM
Ladsgroup updated the task description. (Show Details)

I did s6 master live.

Maintenance_bot moved this task from In progress to Done on the DBA board.May 25 2022, 8:29 AM
Ladsgroup closed subtask T302233: Toolforge db: View 'fiwiki_p.flaggedrevs' references invalid table/column/rights to use them as Resolved.May 30 2022, 8:44 AM
Marostegui closed subtask T300471: Switchover s6 master (db1173 -> db1131) as Resolved.Jun 14 2022, 6:19 AM
gerritbot added a comment.Jul 16 2024, 9:12 AM

Change #1054501 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] filtered_tables.txt: Drop unused columns

https://gerrit.wikimedia.org/r/1054501

gerritbot added a project: Patch-For-Review.Jul 16 2024, 9:12 AM

Change #1054501 merged by Marostegui:

[operations/puppet@production] filtered_tables.txt: Drop unused columns

https://gerrit.wikimedia.org/r/1054501

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2024, 10:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits