MentorProvider::getMentorsSafe always returns an empty array, even if only one of the two methods called throws (and the other one returns a list of mentors).
In case a wiki sets both mentor lists (automatically assigned and manual), but only one of them exists (let's say, the automatically assigned one), getMentorsSafe will return an empty list of usernames (even though there are valid mentors on the wiki).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix handling in MentorProvider::getMentorsSafe | mediawiki/extensions/GrowthExperiments | master | +7 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Urbanecm_WMF | T272376 Make it possible for admin to remove a mentor when they quit/are blocked | |||
| Resolved | Urbanecm_WMF | T264343 Have a special page for mentors to sign up | |||
| Resolved | Urbanecm_WMF | T300847 If both types of mentor list are defined, but only one of them exists, MentorProvider::getMentorsSafe() returns an empty array |
I tested at test.wiki (which doesn't yet have MentorProvider and runs on the pre-refactoring code), and I can reproduce there as well. Since it apparently was the case before, it's not urgent to fix this.
Change 759471 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] Fix handling in MentorProvider::getMentorsSafe
Change 759471 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix handling in MentorProvider::getMentorsSafe