Page MenuHomePhabricator
Create Task
Maniphest T300992

Add linter_template and linter_tag columns to the Linter table
Closed, ResolvedPublic
Actions

Description

Two additional columns enable editors to do more refined searches for pages with specific types of errors with good CPU and database efficiency.

ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/720128/12/sql/patch-linter-template-tag-fields.sql
Where to run those changes: all.dblist
When to run those changes: At any time
If the schema change is backwards compatible: Yes
If the schema change has been tested already on some of the test/beta wikis: Tested in beta
if the data should be made available on the labs replicas and/or dumps: Table is public

  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8
  • labtestwiki

Details

SubjectRepoBranchLines +/-
Add add_linter_template_T300992.pyoperations/software/schema-changesmaster+41 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Stashbot added a comment.Mar 4 2022, 3:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-04T15:20:07Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1099:3318 (T300992)', diff saved to https://phabricator.wikimedia.org/P21850 and previous config saved to /var/cache/conftool/dbconfig/20220304-152007-ladsgroup.json

Stashbot added a comment.Mar 4 2022, 3:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-04T15:21:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3318 (T300992)', diff saved to https://phabricator.wikimedia.org/P21851 and previous config saved to /var/cache/conftool/dbconfig/20220304-152114-ladsgroup.json

Stashbot added a comment.Mar 4 2022, 4:06 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-04T16:06:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3318 (T300992)', diff saved to https://phabricator.wikimedia.org/P21856 and previous config saved to /var/cache/conftool/dbconfig/20220304-160629-ladsgroup.json

Ladsgroup updated the task description. (Show Details)Mar 7 2022, 5:14 AM

Deploying on s1

Stashbot added a comment.Mar 7 2022, 5:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T05:18:08Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1169 (T300992)', diff saved to https://phabricator.wikimedia.org/P21859 and previous config saved to /var/cache/conftool/dbconfig/20220307-051807-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 5:22 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T05:22:58Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1169 (T300992)', diff saved to https://phabricator.wikimedia.org/P21860 and previous config saved to /var/cache/conftool/dbconfig/20220307-052257-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 6:08 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T06:08:12Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1169 (T300992)', diff saved to https://phabricator.wikimedia.org/P21863 and previous config saved to /var/cache/conftool/dbconfig/20220307-060811-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 6:08 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T06:08:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1164 (T300992)', diff saved to https://phabricator.wikimedia.org/P21864 and previous config saved to /var/cache/conftool/dbconfig/20220307-060819-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 6:13 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T06:13:18Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T300992)', diff saved to https://phabricator.wikimedia.org/P21865 and previous config saved to /var/cache/conftool/dbconfig/20220307-061318-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 6:58 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T06:58:33Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1164 (T300992)', diff saved to https://phabricator.wikimedia.org/P21871 and previous config saved to /var/cache/conftool/dbconfig/20220307-065832-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 6:58 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T06:58:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1119 (T300992)', diff saved to https://phabricator.wikimedia.org/P21872 and previous config saved to /var/cache/conftool/dbconfig/20220307-065839-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 7:03 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T07:03:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T300992)', diff saved to https://phabricator.wikimedia.org/P21873 and previous config saved to /var/cache/conftool/dbconfig/20220307-070355-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 7:49 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T07:49:10Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T300992)', diff saved to https://phabricator.wikimedia.org/P21883 and previous config saved to /var/cache/conftool/dbconfig/20220307-074909-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 7:49 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T07:49:23Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1106 (T300992)', diff saved to https://phabricator.wikimedia.org/P21884 and previous config saved to /var/cache/conftool/dbconfig/20220307-074923-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 7:54 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T07:54:34Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T300992)', diff saved to https://phabricator.wikimedia.org/P21886 and previous config saved to /var/cache/conftool/dbconfig/20220307-075433-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 8:39 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T08:39:48Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T300992)', diff saved to https://phabricator.wikimedia.org/P21897 and previous config saved to /var/cache/conftool/dbconfig/20220307-083948-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 8:46 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T08:46:41Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1184 (T300992)', diff saved to https://phabricator.wikimedia.org/P21902 and previous config saved to /var/cache/conftool/dbconfig/20220307-084641-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 8:51 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T08:51:39Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T300992)', diff saved to https://phabricator.wikimedia.org/P21904 and previous config saved to /var/cache/conftool/dbconfig/20220307-085139-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 9:36 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T09:36:54Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T300992)', diff saved to https://phabricator.wikimedia.org/P21920 and previous config saved to /var/cache/conftool/dbconfig/20220307-093653-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 9:37 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T09:37:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1135 (T300992)', diff saved to https://phabricator.wikimedia.org/P21921 and previous config saved to /var/cache/conftool/dbconfig/20220307-093701-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 9:42 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T09:42:16Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T300992)', diff saved to https://phabricator.wikimedia.org/P21922 and previous config saved to /var/cache/conftool/dbconfig/20220307-094216-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 10:27 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T10:27:30Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T300992)', diff saved to https://phabricator.wikimedia.org/P21936 and previous config saved to /var/cache/conftool/dbconfig/20220307-102730-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 10:27 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T10:27:38Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1134 (T300992)', diff saved to https://phabricator.wikimedia.org/P21937 and previous config saved to /var/cache/conftool/dbconfig/20220307-102737-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 10:32 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T10:32:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T300992)', diff saved to https://phabricator.wikimedia.org/P21938 and previous config saved to /var/cache/conftool/dbconfig/20220307-103253-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 11:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T11:18:09Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1134 (T300992)', diff saved to https://phabricator.wikimedia.org/P21946 and previous config saved to /var/cache/conftool/dbconfig/20220307-111809-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 11:18 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T11:18:17Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1163 (T300992)', diff saved to https://phabricator.wikimedia.org/P21947 and previous config saved to /var/cache/conftool/dbconfig/20220307-111816-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 11:23 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T11:23:07Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T300992)', diff saved to https://phabricator.wikimedia.org/P21950 and previous config saved to /var/cache/conftool/dbconfig/20220307-112307-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 12:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T12:08:21Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1163 (T300992)', diff saved to https://phabricator.wikimedia.org/P21960 and previous config saved to /var/cache/conftool/dbconfig/20220307-120821-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 12:14 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T12:14:44Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1105:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21963 and previous config saved to /var/cache/conftool/dbconfig/20220307-121443-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 12:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T12:19:58Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21964 and previous config saved to /var/cache/conftool/dbconfig/20220307-121958-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 1:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T13:05:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21973 and previous config saved to /var/cache/conftool/dbconfig/20220307-130512-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 1:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T13:05:20Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1099:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21974 and previous config saved to /var/cache/conftool/dbconfig/20220307-130520-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 1:11 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T13:11:00Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21975 and previous config saved to /var/cache/conftool/dbconfig/20220307-131100-ladsgroup.json

Stashbot added a comment.Mar 7 2022, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-07T13:56:14Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T300992)', diff saved to https://phabricator.wikimedia.org/P21987 and previous config saved to /var/cache/conftool/dbconfig/20220307-135614-ladsgroup.json

Ladsgroup updated the task description. (Show Details)Mar 7 2022, 2:45 PM
Ladsgroup updated the task description. (Show Details)Mar 7 2022, 2:48 PM
Ladsgroup updated the task description. (Show Details)Mar 7 2022, 3:07 PM
Ladsgroup moved this task from In progress to Blocked on the DBA board.
• Marostegui added a comment.Mar 22 2022, 12:10 PM

labtestwiki wasn't done - I just did it

• Marostegui updated the task description. (Show Details)Mar 22 2022, 12:10 PM

Also, for what is worth, adding a column and indexes is a DDL operation, so it can be done on the masters, without replication. s1 (enwiki) is likely going to fail due to activity, but the rest should be doable.

• Marostegui added a comment.Mar 22 2022, 12:15 PM

I have done s8 master

Stashbot added a comment.Mar 22 2022, 12:16 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-22T12:16:04Z] <marostegui> dbmaint s8@eqiad T300992

• Marostegui updated the task description. (Show Details)Mar 22 2022, 12:16 PM
Stashbot added a comment.Mar 22 2022, 12:17 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-22T12:17:34Z] <marostegui> dbmaint s5@eqiad T300992

• Marostegui added a comment.Mar 22 2022, 12:18 PM

Done s5 master

• Marostegui updated the task description. (Show Details)Mar 22 2022, 12:18 PM
Stashbot added a comment.Mar 22 2022, 12:18 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-22T12:18:53Z] <marostegui> dbmaint s6@eqiad T300992

• Marostegui added a comment.Mar 22 2022, 12:19 PM

Done s6 master

• Marostegui updated the task description. (Show Details)Mar 22 2022, 12:19 PM
Stashbot added a comment.Mar 22 2022, 12:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-22T12:21:15Z] <marostegui> dbmaint s7@eqiad T300992

• Marostegui added a comment.Mar 22 2022, 12:21 PM

Done s7 master

• Marostegui updated the task description. (Show Details)Mar 22 2022, 12:21 PM
• Marostegui updated the task description. (Show Details)
Ladsgroup added a comment.Mar 22 2022, 12:41 PM

It failed on s4 in commons but s3 is ongoing.

Ladsgroup updated the task description. (Show Details)Mar 22 2022, 12:51 PM
Ladsgroup updated the task description. (Show Details)Mar 22 2022, 12:54 PM
Stashbot added a comment.Apr 12 2022, 10:58 AM

Mentioned in SAL (#wikimedia-operations) [2022-04-12T10:58:35Z] <marostegui> dbmaint s4@eqiad T300992

• Marostegui updated the task description. (Show Details)Apr 12 2022, 11:04 AM
Ladsgroup moved this task from In progress to Unclear/blocked to proceed on the Schema-change-in-production board.May 9 2022, 10:56 AM
Ladsgroup updated the task description. (Show Details)May 19 2022, 6:14 AM

This is done now. I sincerely apologize for the delay and will make sure this won't happen again.

Ladsgroup closed this task as Resolved.May 19 2022, 6:15 AM
Ladsgroup moved this task from Blocked to Done on the DBA board.
• Marostegui added a comment.Jan 23 2023, 3:27 PM

db1105:3312 and db1170:3317 were missing this change. I have deployed it there

Ladsgroup added a comment.Jan 25 2023, 1:38 AM

I ran drifts tracker on linter and can confirm beside T327806 there is no other drifts reported (both in eqiad and codfw). This is done for real.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits