Page MenuHomePhabricator

A different language cannot be selected in the ime selector in the Vector 2022 search box
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  1. Go to the main page
  2. Log out.
  3. Go to main page of the French Wikipedia: https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal?useskin=vector-2022
  4. Click the search box at the top of the page once.
  5. Click outside the search box.
  6. Click the search box again. (This repetition is needed because of T301540. Instead of steps 4, 5, 6, only step 4 should be needed.)
  7. A little keyboard icon (ime selector) appears in the bottom right corner of the search box.
  8. Click the ime selector. A menu appears.
  9. Click the "..." at the bottom of the menu.

What happens?:

  • A language selection panel appears behind the search box. Searching for a language using the language search box (languagefilter) is impossible.
  • Clicking the language search box makes

What should have happened instead?:

  • A language selection panel is supposed to appear in a location on a screen where it is fully visible.
  • The language search box inside the panel must be usable.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Tested on Chromium 98 and Firefox 96 on Ubuntu 21.10.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson added a project: Language-Team.
Jdlrobson subscribed.

This looks like a bug in Extension:UniversalLanguageSelector. Not sure how to fix.

Nikerabbit set the point value for this task to 2.Mar 1 2022, 8:19 AM
abi_ changed the task status from Open to In Progress.Mar 10 2022, 1:53 PM
abi_ claimed this task.

Change 769931 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] Set higher z-index when opening ULS from the ime

https://gerrit.wikimedia.org/r/769931

@Nikerabbit @abi_ just wanted to check this is the issue we are trying to fix? If so the issue is the different z-indexes of grid.uls-menu.uls-wide and .imeselector.imeselector-toggle

uls.gif (453×649 px, 116 KB)

Off topic: I click hitting the search button instead of the keyboard due to the way the search button moves in when the input is focused, so perhaps we also need to revisit the position of this button.

There are two issues:

  1. The ULS appears below the mw-header: The mw-header (child of body > mw-page-container > .mw-page-container-inner ) has a z-index of 4. The ULS that comes up (child of body) on selection from ime.selector has a z-index of 3. Hence it appears below the mw-header and is unusable. This can be fixed by giving the ULS a z-index of 5.
  2. ime.selector dropdown appears on top of the ULS: While testing this, I noticed the issue that your GIF displays that is ,the ULS appearing below the imeselector-menu (z-index of 1000, child of body > .imeselector.imeselector-toggle). Hence the z-index of 1001 for the ULS is proposed in the patch.

See image below:

vector-uls-z-index-issue-2022-03-16_11.02.19.gif (814×1 px, 975 KB)

Off topic: I click hitting the search button instead of the keyboard due to the way the search button moves in when the input is focused, so perhaps we also need to revisit the position of this button.

Noted. Should we create a task for this?

Related patch: 771318: Set position and z-index for mw-page-container | https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/771318 (Now merged)

Deployed and added a fix for the issue:

image.png (697×1 px, 174 KB)

Note that there is another issue with the ime selector dropdown appearing on top of the ULS, but that does not stop the ULS from being usable. Reported at: T304393: IME dropdown appears on top of ULS when selecting input language

Change 769931 abandoned by Abijeet Patro:

[mediawiki/extensions/UniversalLanguageSelector@master] Set higher z-index when opening ULS from the ime

Reason:

Reported at https://phabricator.wikimedia.org/T304393. Abandoning this patch.

https://gerrit.wikimedia.org/r/769931